benlangmuir added inline comments.
================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:102 +std::vector<std::string> +serializeCompilerInvocation(const CompilerInvocation &CI); + ---------------- jansvoboda11 wrote: > Maybe we could add this API directly to `CompilerInvocation`. I can see lots > of clients not caring about the (potentially more efficient) > `CompilerInvocation::generateCC1CommandLine()` with `StringAllocator` and > inventing their own implementation of this. https://reviews.llvm.org/D132419 ================ Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:438 + +void dependencies::clearImplicitModuleBuildOptions(CompilerInvocation &CI) { + CI.getLangOpts()->ImplicitModules = false; ---------------- jansvoboda11 wrote: > Wondering if we could move this to `CompilerInvocation`, right besides > `resetNonModularOptions()`. https://reviews.llvm.org/D132419 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132405/new/ https://reviews.llvm.org/D132405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
