[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 453207. ChuanqiXu added a comment. Add description to use `-fmodule-header` to generate BMI for header units. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/CPlusPlus20Modules.rst

[PATCH] D128981: [C++20][Modules] Implement include translation.

jansvoboda11 added a comment. Hi @iains, upstream Clang crashes on the attached test case due to an assertion failure. Git bisect pointed me to this commit. Can you please take a look? Previously, the test would result in a warning of incomplete umbrella header. // RUN: rm -rf %t && mkdir %t

[PATCH] D132014: [C++20] [Modules] Replace is ModuleMapModule with isHeaderLikeModules

ChuanqiXu created this revision. ChuanqiXu added a reviewer: iains. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I find that many places we should use `isHeaderLikeModules` instead of `isModuleM

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ChuanqiXu added a comment. In D131938#3727954 , @ychen wrote: >> Since the coroutines are going to split into pieces in the middle end so the >> address of labels are ambiguous that time. > > Do we split in the middle or copy the whole computed goto CFG?

[PATCH] D132008: [clang-format] Handle return type auto followed by l_paren

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

ychen added a comment. > Since the coroutines are going to split into pieces in the middle end so the > address of labels are ambiguous that time. Do we split in the middle or copy the whole computed goto CFG? I'd imagine the branch on a dynamic block address is like `n`-way branch which is not

[PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 453194. tstellar added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 Files: clang/CMakeLists.txt compiler-rt/CMakeLists.txt lld/CMakeLists

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang marked an inline comment as done. tingwang added a comment. In D131953#3727900 , @ChuanqiXu wrote: > LGTM with comment addressed. Thanks! Thank you! I'm looking forward to comments from ppc. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang updated this revision to Diff 453193. tingwang added a comment. For default implementation of `supportsTailCallFor`, return `supportsTailCalls()` as suggested in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131953/new/ https://

[PATCH] D131940: [clang-format] Handle comments between access specifier and colon

This revision was automatically updated to reflect the committed changes. Closed by commit rG2185f64771f0: [clang-format] Handle comments between access specifier and colon (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131940/n

[clang] 2185f64 - [clang-format] Handle comments between access specifier and colon

Author: owenca Date: 2022-08-16T20:18:21-07:00 New Revision: 2185f64771f039774d54a0be654cce39931580bf URL: https://github.com/llvm/llvm-project/commit/2185f64771f039774d54a0be654cce39931580bf DIFF: https://github.com/llvm/llvm-project/commit/2185f64771f039774d54a0be654cce39931580bf.diff LOG: [

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with comment addressed. Thanks! Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:346 + bool supportsTailCallFor(const CallBase *CB) const { retu

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang updated this revision to Diff 453188. tingwang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131953/new/ https://reviews.

[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

ChuanqiXu added a comment. In D129833#3717291 , @jyknight wrote: > Note that this change caused LLVM to no longer be aware that a TLS variable > cannot be NULL. Thus, code like: > > __thread int x; > int main() { > int* y = &x; > return *y; >

[PATCH] D131928: [libcxx][spaceship][doc] Repair links and clean up spaceship progress doc

mumbleskates added a comment. Sorry! Something has gone horribly wrong with my usage of arcanist and it diffed against a very old version of `main`. i will try to repair the reviewers list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131928/new/

[PATCH] D131928: [libcxx][spaceship][doc] Repair links and clean up spaceship progress doc

mumbleskates updated this revision to Diff 453186. mumbleskates added a comment. - Merge branch 'main' into doc2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131928/new/ https://reviews.llvm.org/D131928 Files: libcxx/docs/Status/SpaceshipProjec

[PATCH] D131928: [libcxx][spaceship][doc] Repair links and clean up spaceship progress doc

mumbleskates updated this revision to Diff 453184. mumbleskates added a comment. Herald added subscribers: Michael137, yota9, ayermolo, StephenFan, sstefan1, JDevlieghere, kbarton. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jdoerfert. Herald added a reviewer: aaron.ballman. He

[PATCH] D131928: [libcxx][spaceship][doc] Repair links and clean up spaceship progress doc

mumbleskates updated this revision to Diff 453183. mumbleskates added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, openmp-commits, lldb-commits, Sanitizers, anlunx, mtrofin, Enna1, bzcheeseman, kosarev, pmatos, asb, pcwang-thead, arjunp, sdasgup3, luke957, carlosg

[clang] da6187f - [Clang] followup D128745, add a missing ClangABICompat check

Author: Yuanfang Chen Date: 2022-08-16T18:40:00-07:00 New Revision: da6187f566b7881cb8350621aea9bd582de569b9 URL: https://github.com/llvm/llvm-project/commit/da6187f566b7881cb8350621aea9bd582de569b9 DIFF: https://github.com/llvm/llvm-project/commit/da6187f566b7881cb8350621aea9bd582de569b9.diff

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

smeenai added a comment. I confirmed that this fixes all remaining issues on our end. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

tlively added a comment. It would be good to add tests for more error conditions like in the externref patch and also additional errors like trying to apply __funcref to types that aren't function pointers. Comment at: clang/include/clang/Basic/Attr.td:4053 + let Spellings =

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3727770 , @abrachet wrote: > In D128745#3727715 , @ychen wrote: > >> In D128745#3727697 , @abrachet >> wrote: >> >>> This is breaking us

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

abrachet added a comment. In D128745#3727715 , @ychen wrote: > In D128745#3727697 , @abrachet > wrote: > >> This is breaking us. >> >> template struct S; // #1 >> >> template struct S {}; // #2 >> >> The

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

tlively added a comment. Very nice! This LGTM with all these small comments addressed. Sorry for the long delay in reviewing. Comment at: clang/include/clang/AST/ASTContext.h:1149 #include "clang/Basic/RISCVVTypes.def" +#define WASM_TYPE(Name, Id, SingletonId) CanQualType Sin

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3727715 , @ychen wrote: > In D128745#3727697 , @abrachet > wrote: > >> This is breaking us. >> >> template struct S; // #1 >> >> template struct S {}; // #2 >> >> The fo

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3727697 , @abrachet wrote: > This is breaking us. > > template struct S; // #1 > > template struct S {}; // #2 > > The following compiled before but is now broken, (we use > `-fclang-abi-compat=13.0`). We get a

[PATCH] D131933: DebugInfo: Remove auto return type representation support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06c70e9b998c: DebugInfo: Remove auto return type representation support (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 06c70e9 - DebugInfo: Remove auto return type representation support

Author: David Blaikie Date: 2022-08-17T00:35:05Z New Revision: 06c70e9b998ca289630ee1629ec09b6dd51b29b9 URL: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9 DIFF: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9.diff LOG:

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

abrachet added subscribers: mcgrathr, abrachet. abrachet added a comment. This is breaking us. template struct S; // #1 template struct S {}; // #2 The following compiled before but is now broken, (we use `-fclang-abi-compat=13.0`). We get a warning from `-Winvalid-partial-specializat

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

dblaikie added a comment. (still a fair few unhandled comments from the last round - guess work to address those is still ongoing) Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static Compr

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

ddcc created this revision. ddcc added reviewers: tmatheson, javed.absar, SjoerdMeijer. Herald added a subscriber: kristof.beyls. Herald added a project: All. ddcc requested review of this revision. Herald added a project: clang. These warnings were identified while debugging modules with Wsystem-

[PATCH] D132001: [clang-format] Fix regressions in WhitespaceSensitiveMacros

owenpan created this revision. owenpan added reviewers: curdeius, krasimir, HazardyKnusperkeks, MyDeveloperDay, ksyx. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky marked 3 inline comments as done. oleg.smolsky added a comment. In D131985#3727568 , @Eugene.Zelenko wrote: > In D131985#3727544 , @oleg.smolsky > wrote: > >> In D131985#3727436

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. In D131985#3727544 , @oleg.smolsky wrote: > In D131985#3727436 , @njames93 > wrote: > >> The idea of this check is good, but restricting it to only return statements >> seems baf

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky marked 3 inline comments as done. oleg.smolsky added a comment. Thanks for the quick review, Eugene! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:110 + + Checks for `return` statements with redundant parenthesis. + Eugene.Zelenko wrote: > P

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453157. oleg.smolsky added a comment. Improve mark up in the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky added a comment. In D131985#3727436 , @njames93 wrote: > The idea of this check is good, but restricting it to only return statements > seems baffling. A general check that could remove useless parens would have a > lot more value. Of cour

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:110 + + Checks for `return` statements with redundant parenthesis. + Please use double back-ticks for language constructs. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453155. oleg.smolsky added a comment. Add a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tid

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. Entry in Release Notes is still missing. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/return-with-redundant-parens.rst:4 +readability-return-with-redundant-parens += + Please make same

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453151. oleg.smolsky added a comment. Add docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy/readabil

[PATCH] D131598: [Clang][BPF]: Force sign/zero extension for return values in caller

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9198f64d9be: [Clang][BPF]: Force sign/zero extension for return values in caller (authored by yonghong-song). Repository: rG LLVM Github Monorepo

[clang] d9198f6 - [Clang][BPF]: Force sign/zero extension for return values in caller

Author: Yonghong Song Date: 2022-08-16T16:08:01-07:00 New Revision: d9198f64d9be149acdad109cd053b6acdd9635d2 URL: https://github.com/llvm/llvm-project/commit/d9198f64d9be149acdad109cd053b6acdd9635d2 DIFF: https://github.com/llvm/llvm-project/commit/d9198f64d9be149acdad109cd053b6acdd9635d2.diff

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 updated this revision to Diff 453144. ziqingluo-90 added a comment. Addressing @NoQ 's comment. Let the symbolic execution simulator put a block object in an `UnknownSpaceRegion` from the start if ARC is enabled. Because in such cases whether the block is on stack or in heap depen

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

smeenai added a comment. In D131528#3723231 , @ayermolo wrote: > In D131528#3722395 , @shafik wrote: > >> In D131528#3719430 , @ayermolo >> wrote: >> >>> Was this and pre

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

njames93 added a comment. The idea of this check is good, but restricting it to only return statements seems baffling. A general check that could remove useless parens would have a lot more value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1319

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

tlively added a comment. For reference, the existing error from the backend is something like this: test.cpp:9:5: error: WebAssembly 'tail-call' feature not enabled int foo(int x) { ^ Note that it points to the beginning of the callee rather than the specific line containing the tail

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 ___ cfe-commits

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453143. ckissane added a comment. - remove extra includes of ADT/Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/Ser

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

tlively added a comment. Oops, sorry about that. Will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:313-315 + // Under ARC, blocks are retained and released automatically: + if (isArcManagedBlock(Referred, Ctx)) +return false; ziqingluo-90 wrote

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/cxx.bnf:39 namespace-name := IDENTIFIER -namespace-name := namespace-alias -namespace-alias := IDENTIFIER class-name := IDENTIFIER class-name := simple-template-id hokein wrote: > th

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; dblaikie wrote: > Generally we

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, though i think we should eliminate class-name altogether. This gives most of the perf, which is nice! The reduction in ambiguous nodes is less impressive than before :-( As discusse

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453140. ckissane added a comment. - compression: remove some usage sugar from Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48-50 + const int BestSpeedLevel; + const int DefaultLevel; + const int BestSizeLevel; dblaikie wrote: > These could/should probably

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453139. ckissane added a comment. - move compression level members from spec to impl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clang

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453136. ckissane added a comment. - remove Supported member of CompressionSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/inde

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/lib/Object/Decompressor.cpp:50 +return createError( +"Decompressor provided nullptr (None) CompressionScheme*"); + if (!CompressionScheme->Implementation) dblaikie wrote: > This probably isn't a useful

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

dblaikie added a comment. Probably easier to review if it's framed somewhat more like @MaskRay and my examples - backwards compatible, without fixing all the API users as we can discuss those separately. Though it is useful to have one or two example uses - but having all the API uses being up

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Hi, checking in on this again, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 __

[PATCH] D131872: [Intrinsics] Add initial support for NonNull attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. alexander-shaposhnikov marked an inline comment as done. Closed by commit rGd68ba43ad247: [Intrinsics] Add initial support for NonNull attribute (authored by alexander-

[clang] d68ba43 - [Intrinsics] Add initial support for NonNull attribute

Author: Alexander Shaposhnikov Date: 2022-08-16T21:28:23Z New Revision: d68ba43ad24791181280fdb0f34b6be380db7a32 URL: https://github.com/llvm/llvm-project/commit/d68ba43ad24791181280fdb0f34b6be380db7a32 DIFF: https://github.com/llvm/llvm-project/commit/d68ba43ad24791181280fdb0f34b6be380db7a32.d

[clang] 585f62b - CodeGen: correct handling of debug info generation for aliases

Author: Saleem Abdulrasool Date: 2022-08-16T21:27:05Z New Revision: 585f62be1a438ca132aa443e556d102bc908a072 URL: https://github.com/llvm/llvm-project/commit/585f62be1a438ca132aa443e556d102bc908a072 DIFF: https://github.com/llvm/llvm-project/commit/585f62be1a438ca132aa443e556d102bc908a072.diff

[PATCH] D131934: [clang][deps] Compute command-lines for dependencies immediately

This revision was automatically updated to reflect the committed changes. Closed by commit rG5482432bf6cc: [clang][deps] Compute command-lines for dependencies immediately (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13193

[clang] 5482432 - [clang][deps] Compute command-lines for dependencies immediately

Author: Ben Langmuir Date: 2022-08-16T14:25:27-07:00 New Revision: 5482432bf6cc7e334894734ebbdac0a97ee98b19 URL: https://github.com/llvm/llvm-project/commit/5482432bf6cc7e334894734ebbdac0a97ee98b19 DIFF: https://github.com/llvm/llvm-project/commit/5482432bf6cc7e334894734ebbdac0a97ee98b19.diff

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:75 +emitFilename(FE->getName(), Loc.getManager()); +// FIXME: No current way to add file-only location to SARIF object + } abrahamcd wrote: > @vaibhav.y ,

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453126. abrahamcd added a comment. Fixed FileCheck test case and added multiple source range error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/i

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane created this revision. ckissane added reviewers: dblaikie, MaskRay. Herald added subscribers: StephenFan, wenlei, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. H

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. In D131978#3727110 , @HazardyKnusperkeks wrote: > It's late (where I am). I thought we had something like > `ClosesRequiresClause` for concepts too. > But on the other hand, this should affect requires clauses, right? So a test

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); ychen wrote:

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D131978#3727084 , @rymiel wrote: > Added negation unary operator check to TokenAnnotatorTest > > Is this what you meant? Alt

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 453110. Codesbyusman edited the summary of this revision. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/i

[PATCH] D130510: Missing tautological compare warnings due to unary operators

rtrieu added a comment. This patch has been moving back and forth between `IsIntegerLiteralConstantExpr` and `getIntegerLiteralSubexpressionValue`. The first function is preexisting and the second one is a new function. The final patch seems to settle on using just `getIntegerLiteralSubexpres

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); efriedma wrote:

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel updated this revision to Diff 453107. rymiel added a comment. Added negation unary operator check to TokenAnnotatorTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 Files: clang/lib/Format/Unw

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/buffer-array-operator.hlsl:3 + +const RWBuffer In; +RWBuffer Out; python3kgae wrote: > beanz wrote: > > python3kgae wrote: > > > Why add const instead of using Buffer directly? > > > > > Making this

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 453105. pscoro added a comment. Re added chain fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); ychen wrote:

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

tlively created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a reviewer: aaron.ballman. Herald added a project: All. tlively requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald adde

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Nice patch. Could you please also extend the test in `TokenAnnotatorTests.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks correct to me! Any further concerns @erichkeane or @rtrieu? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ h

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

hokein added a comment. New data on the patch: | file | ambiguous nodes | forest size | glrParse performance | | SemaCodeComplete.cpp | 11k -> 5.7K | 10.4MB -> 7.9MB | 7.1MB/s -> 9.98MB/s | | AST.cpp | 1.3k -> 0.73K | 0.99MB -> 0.77MB | 6.7MB/s -> 8.4M

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

hokein updated this revision to Diff 453098. hokein added a comment. update based on the offline discussion -- we'd like to keep all categories of IDENTIFIER (type-name, namespace-name, template-name, template-name) as they are useful in disambiguation, but we eliminate the ambiguities per each ca

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

This revision was automatically updated to reflect the committed changes. Closed by commit rG68786f063275: [Sema] Fix friend destructor declarations after D130936 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ h

[clang] 68786f0 - [Sema] Fix friend destructor declarations after D130936

Author: Roy Jacobson Date: 2022-08-16T22:28:19+03:00 New Revision: 68786f06327519b30ab3ee2ba27451ec051bbb6f URL: https://github.com/llvm/llvm-project/commit/68786f06327519b30ab3ee2ba27451ec051bbb6f DIFF: https://github.com/llvm/llvm-project/commit/68786f06327519b30ab3ee2ba27451ec051bbb6f.diff

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen updated this revision to Diff 453095. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen updated this revision to Diff 453094. ychen added a comment. - use correct lexing order for non-deferred constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDe

[PATCH] D131986: [inlining] Add a clang option to control inlining of functions based on stack size

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. perhaps a test that "inline-max-stacksze" doesn't appear if the flag isn't specified? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131986/new/ https://reviews.llvm.org/D131986

[clang] 7d8ae9f - [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c

Author: Lei Huang Date: 2022-08-16T13:56:33-05:00 New Revision: 7d8ae9f755d7ae65ab116220d6d42108ee10f815 URL: https://github.com/llvm/llvm-project/commit/7d8ae9f755d7ae65ab116220d6d42108ee10f815 DIFF: https://github.com/llvm/llvm-project/commit/7d8ae9f755d7ae65ab116220d6d42108ee10f815.diff LOG

[PATCH] D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8ae9f755d7: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131622/

[PATCH] D131934: [clang][deps] Compute command-lines for dependencies immediately

benlangmuir marked 2 inline comments as done. benlangmuir added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:403 + +static std::string getModuleCachePath(ArrayRef Args) { + for (StringRef Arg : llvm::reverse(Args)) { jansvoboda11 wr

[PATCH] D131934: [clang][deps] Compute command-lines for dependencies immediately

benlangmuir updated this revision to Diff 453085. benlangmuir edited the summary of this revision. benlangmuir added a comment. Per review - Add typedef for callback type - Add comment about mapping paths to "-" - Update commit message for module cache path computation change CHANGES SINCE LAST

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453084. oleg.smolsky added a comment. Drop the trailing \n from the main C++ file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D131986: [inlining] Add a clang option to control inlining of functions based on stack size

wolfgangp created this revision. wolfgangp added reviewers: mtrofin, aeubanks. Herald added a project: All. wolfgangp requested review of this revision. Herald added a subscriber: MaskRay. Adding -finline-max-stacksize= to clang. This generates the function attribute` inline-max-stacksize` (intro

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); efriedma wrote:

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky created this revision. oleg.smolsky added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. oleg.smolsky requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - this

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. In D131464#3716905 , @MaskRay wrote: > Sorry, my previous main comment had been written before I introduced > `LIT_CLANG_STD_GROUP` in `llvm/utils/lit/lit/llvm/config.py`. The multiple > `%clang_cc1` approach actually look

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

chrish_ericsson_atx added a comment. Sounds fair. I had taken your acceptance of the change as a green light. :) TBH, the acceptance came much faster than I'd expected-- even though this is a trivial and low-risk change, I expected it to sit for at least several days. I'll plan to wait a fe

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

efriedma added a comment. If you're specifically concerned about sibcall (call->jmp) optimization in the backend, it might be better to adjust the backend to avoid sibcalls at -O1, as opposed to messing with optimization passes. (i.e. make -fno-optimize-sibling-calls the default at -O1.) "tai

  1   2   >