ckissane added inline comments.
================ Comment at: llvm/lib/Object/Decompressor.cpp:50 + return createError( + "Decompressor provided nullptr (None) CompressionScheme*"); + if (!CompressionScheme->Implementation) ---------------- dblaikie wrote: > This probably isn't a useful error message for a user. And this code is > unreachable/untestable, right? The above code would've already errored out on > "unsupported compression type"? true, it is essentially a repeat of the above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
