sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
LG, though i think we should eliminate class-name altogether. This gives most of the perf, which is nice! The reduction in ambiguous nodes is less impressive than before :-( As discussed offline, i think the remaining ambiguous nodes serve a purpose as they will assist in correlated disambiguation & keep the representation of important concepts uniform. I may be wrong about that, in which case we can still drop them later. The forest size reduction is nice to have, but least critical imo. ================ Comment at: clang-tools-extra/pseudo/lib/cxx/cxx.bnf:37 # gram.key -typedef-name := IDENTIFIER -typedef-name := simple-template-id +#! No namespace-alis rules, as they're less interesting and marginal useful. namespace-name := IDENTIFIER ---------------- Maybe "we don't distinguish between namespaces and namespace aliases, as it's hard and uninteresting"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130747/new/ https://reviews.llvm.org/D130747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
