[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440874. awarzynski added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 Files: clang/lib/Driver/ToolChains/Linux.cpp flang/test/Dri

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

ChuanqiXu added a comment. In D128487#3617422 , @vsapsai wrote: > Thanks for the review! > > In D128487#3614251 , @ChuanqiXu > wrote: > >> Is it possible to combine the several `DiagNote` into `DiagError`? So tha

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

mboehme added a comment. In D128706#3615623 , @aaron.ballman wrote: > The changes here LGTM and I think this is the correct way to go. However, > since you discovered that it was perhaps intentional that we did some style > checking on tests, do you th

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3614297 , @MaskRay wrote: > Oh, I did not see this when pushing a test > efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 > . > Consider adding additional t

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

kevcadieux created this revision. Herald added a project: All. kevcadieux requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a clang-format unit test failure introduced by D124748 . The `cou

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu updated this revision to Diff 440872. ChuanqiXu added a reviewer: MaskRay. ChuanqiXu added a comment. Herald added a subscriber: StephenFan. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 Files: clang/include/clang/Basic

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129 +auto *Lattice = +llvm::any_cast(&State.Lattice.Value); +PostVisitStmt(Stmt, DataflowAnalysisState{ +

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:401 + const TypeErasedDataflowAnalysisState &State) { +PostVisitStmt(Stmt.getStmt(), State); + }

[PATCH] D128783: Check for more -fsanitize=array-bounds regressions

sberg created this revision. sberg added a reviewer: MaskRay. sberg added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. sberg requested review of this revision. ...that had been introduced with (since reverted) https://github.com/llvm/llvm-project/commit/88

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3615807 , @erichkeane wrote: > All tests pass now, I was able to get the template-template checks working > correctly, and it passes all the tests I have available. @ChuanqiXu if you > could review/run what tests

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new field called EmittedDeferredDecls in CodeGenModule that keeps

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail updated this revision to Diff 440860. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 Files: clang/include/clang/Basic/LangOptions.def clang/include/clan

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added a comment. In D105584#3617456 , @abidmalikwaterloo wrote: > // CHECK-LABEL: omp_DistributeOp > func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, > %data_var : memref, %chunk_var : i32) -> () { > // CHECK: omp

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440859. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/typeinfo clang/test/SemaCXX/warn-infinite-recur

[PATCH] D128709: [clang-format] Handle Verilog attributes

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1466-1471 + } else if (FormatTok->is(tok::l_paren)) { +const FormatToken *Next = Tokens->peekNextToken(); +if (Next && Next->is(tok::star)) + parseParens(); +

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440856. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recursion.cpp Index: clang/test/S

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @rsmith @iains gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:624 bool isModulePrivate() const { return getModuleOwnershipKind() == ModuleOwnershipKind::ModulePrivate; } According to the opinion from @rsmith, the discarded declaration

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a comment. @jyknight ping! Or someone else is willing to review this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder added a comment. If you apply e.g. @@ -10739,6 +10779,7 @@ bool ArrayExprEvaluator::VisitInitListExpr(const InitListExpr *E, << NumEltsToInit << ".\n"); Result = APValue(APValue::UninitArray(), NumEltsToInit, NumElts); + llvm::errs() << "Result "

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c04851cf580: [C++20] [Module] Support reachable definition initially/partially (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHAN

[clang] 9c04851 - [C++20] [Module] Support reachable definition initially/partially

Author: Chuanqi Xu Date: 2022-06-29T12:48:48+08:00 New Revision: 9c04851cf5809c80862183481f8ced0b3e9ee301 URL: https://github.com/llvm/llvm-project/commit/9c04851cf5809c80862183481f8ced0b3e9ee301 DIFF: https://github.com/llvm/llvm-project/commit/9c04851cf5809c80862183481f8ced0b3e9ee301.diff LO

[clang] 7a54140 - Revert "[C++20] [Modules] Implement Reachable initiallly"

Author: Chuanqi Xu Date: 2022-06-29T12:43:26+08:00 New Revision: 7a541406b5a23a811a4f37432292a6de3307b0f1 URL: https://github.com/llvm/llvm-project/commit/7a541406b5a23a811a4f37432292a6de3307b0f1 DIFF: https://github.com/llvm/llvm-project/commit/7a541406b5a23a811a4f37432292a6de3307b0f1.diff LO

[clang] a223ba0 - [C++20] [Modules] Implement Reachable initiallly

Author: Chuanqi Xu Date: 2022-06-29T12:32:31+08:00 New Revision: a223ba0a697c1598b434cf2495c9cd9ec5640fc7 URL: https://github.com/llvm/llvm-project/commit/a223ba0a697c1598b434cf2495c9cd9ec5640fc7 DIFF: https://github.com/llvm/llvm-project/commit/a223ba0a697c1598b434cf2495c9cd9ec5640fc7.diff LO

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:178 +using UniquePtrOperandBFS = std::unique_ptr; +using ArrayRefOperandBFS = ArrayRef; + Please remove these. They don't improve readability. Repository: rG LLVM Gith

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 440848. srishti-pm marked 2 inline comments as done. srishti-pm added a comment. Fixed memory leak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: mlir/i

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. In D113545#3616814 , @rsmith wrote: > A few comments, but they're all minor things or FIXMEs. I'm happy for this to > land once they're addressed. Thanks for reviewing! Comment at: clang/lib/Sema/SemaLookup

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 440847. ChuanqiXu marked 15 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/inclu

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 added inline comments. Comment at: clang/test/SemaCXX/warn-infinite-recursion.cpp:3 +#include "typeinfo" + `#include ` resulted in 'typeinfo' file not found with include; use "quotes" instead Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440845. appmonster007 added a comment. #include "typeinfo" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp clang/test/Sema

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/test/Driver/ppc-unsupported.c:12 +// RUN: -c %s 2>&1 | FileCheck %s +// RUN: not %clang -target powerpc64le-unknown-linux -maix64-quadword-atomics \ +// RUN: -c %s 2>&1 | FileCheck %s amyk wrote: > amyk wrote: >

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440835. appmonster007 added a comment. included typeinfo file, in clang/test/SemaCXX directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/li

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440831. jhuber6 added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/capturing_i

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

amyk added inline comments. Comment at: clang/test/Driver/ppc-unsupported.c:12 +// RUN: -c %s 2>&1 | FileCheck %s +// RUN: not %clang -target powerpc64le-unknown-linux -maix64-quadword-atomics \ +// RUN: -c %s 2>&1 | FileCheck %s amyk wrote: > Should we have

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

amyk added a comment. This patch makes sense. I had some questions regarding it. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:242 +return error( +"Compressed string table, but compression::serialize is unavailable"); leonardchan wrote: > n

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/unittests/Support/CompressionTest.cpp:68 - 0x414FA339U, - zlib::crc32(StringRef("The quick brown fox jumps over the lazy dog"))); -} leonardchan wrote: > Should

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. // CHECK-LABEL: omp_DistributeOp func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref, %chunk_var : i32) -> () { // CHECK: omp.wsloop collapse(2) "omp.DistributeOp" (%lb, %ub, %step) ({ ^bb0(%iv: index):

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

vsapsai added a comment. Thanks for the review! In D128487#3614251 , @ChuanqiXu wrote: > Is it possible to combine the several `DiagNote` into `DiagError`? So that > the code would be further reduced. I am OK to do this kind of change in other > revisi

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440822. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Fix tests, lots of lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/l

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This has been deprecated for a while, remove it in favor of using cmake's find_package(

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440819. appmonster007 added a comment. fixed warning comments for test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/lib/Analysis/CFG.cpp

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:403-405 +Note, these mailing lists are moderated and it is not unusual for a large +commit to require a moderator to approve the email, so do not be concerned if a +commit does not immediately

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). + Using `git diff` like this, there are risks that `m

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

jacobsa created this revision. jacobsa added a reviewer: klimek. Herald added a project: All. jacobsa requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It took me multiple hours of debugging plus asking an expert for help to figure out why th

[PATCH] D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise a header may be erroneously marked as having a header macro guard and won't get re-included. Repository: rG L

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/branch-clone-unknown-expr.cpp:1 +// RUN: %check_clang_tidy -fix-errors %s bugprone-branch-clone %t + is -fix-errors necessary here, given we aren't verifying any fixi

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added a comment. > Feedback needed on: > this namespace approach will result in tooling compression methods being set > at compile time, however we may want to aim for a runtime configurable > approach in the future, likely a new revision of the compressed data formats > that llvm i

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440804. cor3ntin added a comment. - Undo the change of diagnostic message formatting as they break libc++ tests so we will keep printing instead Changing the format should be done -if at all- in a separate change. Repository: rG LLVM Github Monorepo

[clang] 57fa688 - [Driver][ARM][AArch64] Use err_drv_unsupported_option_argument for -march=/-mcpu=/-mtune= diagnostics

Author: Fangrui Song Date: 2022-06-28T16:01:30-07:00 New Revision: 57fa68897bb76e1fe5442784bca4e0629033c384 URL: https://github.com/llvm/llvm-project/commit/57fa68897bb76e1fe5442784bca4e0629033c384 DIFF: https://github.com/llvm/llvm-project/commit/57fa68897bb76e1fe5442784bca4e0629033c384.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:483 + !Type.getNonReferenceType().isConstQualified() && + !isExpandedParameterPack(Param); } sammccall wrote: > why is this check needed if we already decline

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I'm going to take the liberty of approving this, as it seems straightforward and unlikely to be contentious in any way. Please let me know if you need me to commit it. Repository:

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Yes the use case is coming up in D126097 ; it's not used yet because `hasDescendant(StringLiteral)` is used to skip it but this matchert would be a more precise solution (yes there's an actual `StringLiteral` inside `ObjCStringLiteral`).

[PATCH] D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG178674e23a71: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 440789. ychen added a comment. - add release notes - update www-status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D128766: Update references to Discourse instead of the mailing lists.

tonic created this revision. Herald added a project: All. tonic requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Update the references to the old Mailman mailing lists to point to Discourse forum

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added a comment. In D108469#3616983 , @leonardchan wrote: > I think this might be the cause of the many libc++ static_assert failures > we're seeing on our builders: > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linu

[clang] a774ba7 - Revert "Improve handling of static assert messages."

Author: Corentin Jabot Date: 2022-06-29T00:03:23+02:00 New Revision: a774ba7f60d1fef403b5507b1b1a7475d3684d71 URL: https://github.com/llvm/llvm-project/commit/a774ba7f60d1fef403b5507b1b1a7475d3684d71 DIFF: https://github.com/llvm/llvm-project/commit/a774ba7f60d1fef403b5507b1b1a7475d3684d71.diff

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "Ascii" StringLiteral instances are actually narrow strings that are UTF-8 encoded

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 440778. beanz added a comment. Updating based on PR feedback and removing the new builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui", "i", HLSL_

[PATCH] D108469: Improve handling of static assert messages.

leonardchan added a comment. I think this might be the cause of the many libc++ static_assert failures we're seeing on our builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8810079977358640657/overview Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

tra added a comment. In D128752#3616837 , @jhuber6 wrote: > In D128752#3616831 , @tra wrote: > >> Do we have tests that verify `-target-feature` arguments? It may be worth >> adding a test case there checking for

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

ychen abandoned this revision. ychen added a comment. Herald added a project: All. D115844 and D116130 supersede this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114728/new/

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added inline comments. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:33 +// CHECK-MASS-AFN: __xl_sin +// CHECK-NO-MASS-FAST-NOT: __xl_sin{{_finite}} +// CHECK-NO-MASS-AFN-NOT: __xl_sin{{_finite}} I don't think this works the way you expect it:

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

shafik added a comment. Thank for looking at this bug, just a small comment on the test. Comment at: clang/test/SemaCXX/warn-infinite-recursion.cpp:178 +struct Q { + virtual ~Q(){}; +}; Looks like your missing `// expected-warning{{call itself}}` Repository

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: flang/test/Driver/no-pie.f90:3 + +!- +! RUN COMMANDS awarzynski wrote: > MaskRay wrote: > > The `! RUN COMMANDS` and `EXPECTED

[PATCH] D124624: [OpenMP] Add variant extension that applies to declarations

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. one nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4312 declarations with the same name. The template parameters for the base functions -are used to instan

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + beanz wrote: > python3kgae wrote: > > Anastasia wrote: > > > python3kgae wrote: > > > > Anastasia wrote: > >

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:115 // Parameters for the GLR parsing. +// FIXME: refine it with the ParseLang struct. struct ParseParams { sammccall wrote: > You're already touching the callsites of

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440766. t-rasmud added a comment. Removes manually added documentation and adds it in the header file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/include/clang/ASTMatchers/ASTMatchers.

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein updated this revision to Diff 440765. hokein marked an inline comment as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128679/new/ https://reviews.llvm.org/D128679 Files: clang-tools-extra/ps

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Does anybody on this thread have land permissions? If not, would anyone know who to tag? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cf

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616831 , @tra wrote: > Do we have tests that verify `-target-feature` arguments? It may be worth > adding a test case there checking for redundant features. Yeah, we have some existing tests that check for including

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Do we have tests that verify `-target-feature` arguments? It may be worth adding a test case there checking for redundant features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. A few comments, but they're all minor things or FIXMEs. I'm happy for this to land once they're addressed. Comment at: clang/include/clang/AST/DeclBase.h:229 +/// This d

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

shafik added a comment. I think I need to do another sweep of this PR but mostly minor comments. You should add tests for structured bindings binding to array and tuple-like types b/c the AST under the `BindingDecl` will be different for each of those cases and it would be worth verifying it wo

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

MaskRay added a comment. I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming. The option may be better added in a netbsd specific file. Repository: rG

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:67 +std::move(StmtDiagnostics.begin(), StmtDiagnostics.end(), + std::back_inserter(Diagnostics

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:78 +public: + UncheckedOptionalAccessDiagnosis( + ASTContext &AstContext, UncheckedOptionalAccessModelOptions O

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440747. ckissane edited the summary of this revision. ckissane added a comment. make it the second stage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D108469: Improve handling of static assert messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG870b6d218397: Improve handling of static assert messages. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 870b6d2 - Improve handling of static assert messages.

Author: Corentin Jabot Date: 2022-06-28T22:26:00+02:00 New Revision: 870b6d21839707a3e4c40a29b526995f065a220f URL: https://github.com/llvm/llvm-project/commit/870b6d21839707a3e4c40a29b526995f065a220f DIFF: https://github.com/llvm/llvm-project/commit/870b6d21839707a3e4c40a29b526995f065a220f.diff

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd planned changes to this revision. abrahamcd added a comment. Stuck on determining unused return value, uploaded current state for @denik and @cjdb to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus created this revision. fcambus added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440742. abrahamcd added a comment. Progress Update Hit a roadblock with determining unused return value, uploading current state for further work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ ht

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616675 , @tra wrote: > We already heard complaints that searching for CUDA installation in multiple > places does add a measurable delay when the search hits NFS-mounted > directories. > > Replacing uses of `CudaInst

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

tra added a comment. In D128752#3616579 , @jhuber6 wrote: > In D128752#3616553 , @tra wrote: > >>> we no longer will have a cached CUDA installation so we will usually create >>> it twice. >> >> Does that result

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3616471 , @ychen wrote: > In D128750#3616449 , @erichkeane > wrote: > >> Is there any chance you can validate this against >> https://reviews.llvm.org/D126907 as well? We touch

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2819 "'per-pass-run': one report for each pass invocation">; def ftime_trace : Flag<["-"], "ftime-trace">, Group, HelpText<"Turn on time profiler. Generates JSON file based on output

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 440736. ckissane added a comment. up release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/unittests/Serializat

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane created this revision. ckissane added a reviewer: MaskRay. ckissane added a project: LLVM. Herald added subscribers: StephenFan, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprec

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss added a comment. In D127812#3602688 , @aaron.ballman wrote: > In D127812#3602645 , @erichkeane > wrote: > >> In D127812#3601476 , @danielkiss >> wrote: >> >>

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616553 , @tra wrote: >> we no longer will have a cached CUDA installation so we will usually create >> it twice. > > Does that result in extra output in case we find an unexpected CUDA version, > or when compiler is

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM again, this time for real. Comment at: clang/include/clang/Basic/TargetInfo.h:225-226 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFP

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

tra added a comment. > we no longer will have a cached CUDA installation so we will usually create > it twice. Does that result in extra output in case we find an unexpected CUDA version, or when compiler is run with `-v` ? We may want to wrap installation detector creation into some sort of s

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. GCC and Clang don't have the same behavior wrt. macros-as-abound and standard-layout-requirement, see https://godbolt.org/z/3vc4TcTYz I'm fine with keeping the CLang behavior, but do we want to keep it only for level=0, and drop it for higher level (this would

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3614298 , @ruiu wrote: > In D125624#3552770 , @tstellar > wrote: > >> In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We currently call t

  1   2   3   >