tra added a comment. In D128752#3616837 <https://reviews.llvm.org/D128752#3616837>, @jhuber6 wrote:
> In D128752#3616831 <https://reviews.llvm.org/D128752#3616831>, @tra wrote: > >> Do we have tests that verify `-target-feature` arguments? It may be worth >> adding a test case there checking for redundant features. > > Yeah, we have some existing tests that check for including the target > features at least once. I felt like there was no need to include a test for > what was more or less an oversight The test helps a lot to illustrate what the patch does. There are enough moving parts in the driver that, while I do believe that what the patch description says is intended to be true, I would like to see specific evidence that it's indeed the case. Think of it as a test case that should've been added when we've started passing the feature flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128752/new/ https://reviews.llvm.org/D128752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
