shafik added a comment. I think I need to do another sweep of this PR but mostly minor comments.
You should add tests for structured bindings binding to array and tuple-like types b/c the AST under the `BindingDecl` will be different for each of those cases and it would be worth verifying it works for all the cases. Although I don't see anything that looks like it would not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
