MaskRay added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:2819
"'per-pass-run': one report for each pass invocation">;
def ftime_trace : Flag<["-"], "ftime-trace">, Group<f_Group>,
HelpText<"Turn on time profiler. Generates JSON file based on output
filename.">,
----------------
dongjunduo wrote:
> @MaskRay @jamieschmeiser May I change the option "-ftime-trace" from a "Flag"
> type to a "Joined" type?
>
> I have noticed that lld's option "[[
> https://reviews.llvm.org/rG661c089a402e0d41a28c94fab35d85c8ef90747e |
> -ftime-trace-file ]]" is used to specify the output file name. It must be
> specified simultaneously with "-ftime-trace".
lld has removed --time-trace-file=. --time-trace= is the "Joined" option to
specify the filename. `clang -ftime-trace=` LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128048/new/
https://reviews.llvm.org/D128048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
