[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347142 , @tstellar wrote: > In D120305#3347139 , @MaskRay wrote: > >> In D120305#3347109 , @tstellar >> wrote: >> >>> [...] >>> The i

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347139 , @MaskRay wrote: > In D120305#3347109 , @tstellar > wrote: > >> [...] >> The issue here has nothing to do with the technical merits of the patch or >> what the root

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347109 , @tstellar wrote: > [...] > The issue here has nothing to do with the technical merits of the patch or > what the root cause of the problem is. The policy for this project is that > if you commit a patch tha

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> error: Segmentation fault (core dumped) This happens quite often on these ppc bots - they are known for unstability and slow cycles. >> Open https://lab.llvm.org/buildbot/#/builders/57 , click "Success Rate" tab, >> the rate is lower compared to other bots recently

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347108 , @MaskRay wrote: > In D120305#3347103 , @tstellar > wrote: > >> In D120305#3347058 , @nemanjai >> wrote: >> >>> In D120305#

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347103 , @tstellar wrote: > In D120305#3347058 , @nemanjai > wrote: > >> In D120305#3346880 , @MaskRay >> wrote: >> >>> While I feel

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347058 , @nemanjai wrote: > In D120305#3346880 , @MaskRay wrote: > >> While I feel sorry for leaving clang-ppc64le-rhel red for some time and am >> willing to fix issues if I

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347058 , @nemanjai wrote: > > Statements like this seem to be at odds with this community's culture (or at > least the way I understand it). > As long as I have been a member of this community, the guidance for pa

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

ztong0001 updated this revision to Diff 411577. ztong0001 added a comment. reformat code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120596/new/ https://reviews.llvm.org/D120596 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/X86/x86_

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411576. keith added a comment. Update test with new specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/C

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411575. keith marked 3 inline comments as done. keith added a comment. Add more test path changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/Cod

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 411573. keith added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Move config to llvm lit config, add docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ h

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nemanjai added a comment. In D120305#3346880 , @MaskRay wrote: > While I feel sorry for leaving clang-ppc64le-rhel red for some time and am > willing to fix issues if I have access to a ppc64 machine (especially > compiler-rt ones that I care about), >

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray created this revision. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given a dependent `T` (maybe an undeduced `auto`), Before: new T(z) --> new T((z)) # changes meaning with more args new T{z} --> new T{z}

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411571. lichray added a comment. Re-run build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnos

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3346947 , @tstellar wrote: > In D120305#3346880 , @MaskRay wrote: > >> In D120305#3346787 , @nemanjai >> wrote: >> >>> In D120305#3346

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added a comment. In D119609#3331257 , @junaire wrote: > gentle ping~ Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 __

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3346880 , @MaskRay wrote: > In D120305#3346787 , @nemanjai > wrote: > >> In D120305#3346144 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120577: [14.x] [clang] [test] Skip hip-fpie-option.hip if default-pie

MaskRay closed this revision. MaskRay added a comment. mgorny pushed this to release/14.x CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120577/new/ https://reviews.llvm.org/D120577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D113718: Don't append the working directory to absolute paths

thakis added a comment. In D113718#3208927 , @dblaikie wrote: > @thakis - I think you folks over in Chrome land implemented/use > `-fdebug-prefix-map` (or do you use `-fdebug-compilation-dir`?) so might be > interested in this change. We're using fdebu

[PATCH] D119309: [Driver][test] Clean up some AIX tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1654ee4bee: [Driver][test] Clean up some AIX tests (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D119309?vs=407038&id

[clang] cb1654e - [Driver][test] Clean up some AIX tests

Author: Fangrui Song Date: 2022-02-26T01:06:24Z New Revision: cb1654ee4beedc875c25a95e7b98f1aaed0b9e35 URL: https://github.com/llvm/llvm-project/commit/cb1654ee4beedc875c25a95e7b98f1aaed0b9e35 DIFF: https://github.com/llvm/llvm-project/commit/cb1654ee4beedc875c25a95e7b98f1aaed0b9e35.diff LOG:

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

denzor200 updated this revision to Diff 411556. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116577/new/ https://reviews.llvm.org/D116577 Files: clang-tools-extra/clang-tidy/boost/BoostTidyModule.cpp clang-tools-extra/clang-tidy/boost/CMakeLists.txt clang-tools-extra/clang-tidy/bo

[clang] bc7aeea - Revert "Don't append the working directory to absolute paths"

Author: Adrian Prantl Date: 2022-02-25T17:00:10-08:00 New Revision: bc7aeea8542d48111f8cc923451b7c53347c75b5 URL: https://github.com/llvm/llvm-project/commit/bc7aeea8542d48111f8cc923451b7c53347c75b5 DIFF: https://github.com/llvm/llvm-project/commit/bc7aeea8542d48111f8cc923451b7c53347c75b5.diff

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay added a comment. In D119309#3346892 , @jsji wrote: > LGTM. Thanks for cleaning up. > BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc > might get attention from wider group. Thank

[PATCH] D119309: [Driver][test] Clean up some AIX tests

jsji added subscribers: Xiangling_L, jasonliu, jsji. jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning up. BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119309/new/ https://reviews.llvm.org/D119309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 411555. LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added a comment. - Add intention revealing functions for details of pragma once parsing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3346787 , @nemanjai wrote: > In D120305#3346144 , @MaskRay wrote: > >> In D120305#3345978 , @MaskRay >> wrote: >> >>> In D120305#33458

[PATCH] D113718: Don't append the working directory to absolute paths

thakis added a comment. Breaks tests on Linux and Mac, e.g. http://45.33.8.238/linux/69643/step_7.txt and http://45.33.8.238/win/53984/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 5 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:382 + + if (std::strncmp("pragma", Text, 6) != 0) +return; carlosgalvezp wrote: > Maybe wrap

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

denzor200 added a comment. My apologize for the delay! Diff was updated, implemented detection of known failure cases in the matcher and not issue a fixit, just only diagnostic. Comment at: clang-tools-extra/clang-tidy/boost/UseRangeBasedForLoopCheck.cpp:68 +

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nemanjai added a comment. In D120305#3346144 , @MaskRay wrote: > In D120305#3345978 , @MaskRay wrote: > >> In D120305#3345810 , @RKSimon >> wrote: >> >>> @MaskRay The ppc

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

denzor200 updated this revision to Diff 411548. denzor200 marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116577/new/ https://reviews.llvm.org/D116577 Files: clang-tools-extra/clang-tidy/boost/BoostTidyModule.cpp clang-tools-extra/clang-tidy/boost/CMak

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

iains updated this revision to Diff 411547. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599 Files: clang/lib/Sema/SemaLookup.cpp clang/test/Modules/cxx20-10-1-ex2.cpp

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 411546. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/lib/Sema/SemaModule.cpp Ind

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

iains updated this revision to Diff 411545. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp Index:

[PATCH] D113718: Don't append the working directory to absolute paths

abrachet added a comment. We're seeing test failures in https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8821217427732511185/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113718/new/ https://reviews.llvm.org/D11

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 411544. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaMo

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

ztong0001 updated this revision to Diff 411542. ztong0001 added a comment. reformat test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120596/new/ https://reviews.llvm.org/D120596 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/X86

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

ztong0001 created this revision. Herald added a subscriber: pengfei. ztong0001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang is crashing on the following statement char var[9]; __asm__ ("" : "=r" (var) : "0" (var)); This is si

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

rjmccall added a comment. In D120566#3346533 , @arsenm wrote: > In D120566#3346506 , @rjmccall > wrote: > >> Is there something which stops you from taking the address of a kernel and >> then calling it? If not

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added a comment. Any intrinsic that takes an immediate that needs to be in certain range, needs to have code added to SemaChecking.cpp to validate the range. Look for the other places we call SemaBuiltinConstantArgRange in Sema::CheckRISCVBuiltinFunctionCall Com

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added a comment. In D119816#3346575 , @kees wrote: > FWIW, related problems with `pskb_expand_head` were seen again here: > https://github.com/ClangBuiltLinux/linux/issues/1599 > > I have trouble reproducing it, but I think the kernel patch ther

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

scanon added a comment. There's a lot of churn around proposed "solutions" on this and related PR, but not a very clear analysis of what the problem we're trying to solve is. Concretely, what are the semantics that we want for the BF16 types and intrinsics? Unlike the other floating-point types

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay added a comment. In D113372#3316751 , @mgorny wrote: > When enabled, this seems to break a fair number of tests: > > Clang :: CodeGen/mips-vector-return.c > Clang :: Driver/hexagon-toolchain-elf.c > Clang :: Driver/hip-fpie-option.hip > Cl

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

kees added a comment. FWIW, related problems with `pskb_expand_head` were seen again here: https://github.com/ClangBuiltLinux/linux/issues/1599 I have trouble reproducing it, but I think the kernel patch there solves the problem created by `__alloc_size` vs `ksize()`. Repository: rG LLVM Git

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein updated this revision to Diff 411521. ibookstein added a comment. Add tests for specific>usage>dispatch and dispatch>usage>specific orderings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120266/new/ https://reviews.llvm.org/D120266 Fi

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

arsenm added a comment. In D120566#3346506 , @rjmccall wrote: > Is there something which stops you from taking the address of a kernel and > then calling it? If not, are there actually any uses of kernels in the > module that shouldn't be rewritten as

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

rjmccall added a comment. Is there something which stops you from taking the address of a kernel and then calling it? If not, are there actually any uses of kernels in the module that shouldn't be rewritten as uses of the clone? I feel like this would be a lot easier to just fix in your LLVM p

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411511. lichray added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/Sem

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411510. lichray edited the summary of this revision. lichray added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNote

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray added a comment. In D113393#3345275 , @aaron.ballman wrote: >> Also implemented decltype(auto)(x) (https://wg21.link/p0849r2) as a Clang >> extension. > > I'd like to better understand the use cases for this. WG21 considered this as > part of t

[PATCH] D120411: [X86] Replace __m[128|256|512]bh with __m[128|256|512]i and mark the former deprecated

andrew.w.kaylor requested changes to this revision. andrew.w.kaylor added a comment. This revision now requires changes to proceed. Replacing `__m128bh` with `__m128i` does not prevent arithmetic operations on the type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D113718: Don't append the working directory to absolute paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd9a86da54f: Don't append the working directory to absolute paths (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Githu

[clang] 2cd9a86 - Don't append the working directory to absolute paths

Author: Adrian Prantl Date: 2022-02-25T13:03:59-08:00 New Revision: 2cd9a86da54f8be4eb2aff3e766b125cbdeb023f URL: https://github.com/llvm/llvm-project/commit/2cd9a86da54f8be4eb2aff3e766b125cbdeb023f DIFF: https://github.com/llvm/llvm-project/commit/2cd9a86da54f8be4eb2aff3e766b125cbdeb023f.diff

[PATCH] D120511: [clang-format] Allow to set token types final

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:382 + } + bool typeIsFinalized() const { return TypeIsFinalized; } I thought you didn't like using the same [[ https://reviews.llvm.org/D116316#inline-1112220 | name ]] for both a vari

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added inline comments. Comment at: clang/lib/Headers/avx512bf16intrin.h:37 ///and fraction field is extended to 23 bits. -static __inline__ float __DEFAULT_FN_ATTRS _mm_cvtsbh_ss(__bfloat16 __A) { +static __inline__ float __DEFAULT_FN_ATTRS _mm_cvtsbh_ss(unsi

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray created this revision. Herald added a subscriber: JDevlieghere. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a Clang extension. See also https://wg21.link/p0849r2 The implementation takes a shortcut by forming CXXFunc

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3340878 , @aaron.ballman wrote: > Are there changes needed for the AST printer for this new form of cast > notation? Fixed one pre-existing issue, and now emit legal C++ code, except in one corner case. But `CXXUnre

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao abandoned this revision. shangwuyao added a comment. Closing this since the fix landed with https://reviews.llvm.org/D120563. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org/D120529 ___

[PATCH] D120503: [clang-format] Handle trailing comment for InsertBraces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc05da55bdf54: [clang-format] Handle trailing comment for InsertBraces (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] c05da55 - [clang-format] Handle trailing comment for InsertBraces

Author: owenca Date: 2022-02-25T12:29:47-08:00 New Revision: c05da55bdf54e530a888acf8d2282964e25d2507 URL: https://github.com/llvm/llvm-project/commit/c05da55bdf54e530a888acf8d2282964e25d2507 DIFF: https://github.com/llvm/llvm-project/commit/c05da55bdf54e530a888acf8d2282964e25d2507.diff LOG: [

[PATCH] D120563: [HIP] Fix test hip-link-bundled-archive.hip

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf0c98364322: [HIP] Fix test hip-link-bundled-archive.hip (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] df0c983 - [HIP] Fix test hip-link-bundled-archive.hip

Author: Yaxun (Sam) Liu Date: 2022-02-25T15:27:57-05:00 New Revision: df0c983643222b8b2085fb4d8a833cb64274caf1 URL: https://github.com/llvm/llvm-project/commit/df0c983643222b8b2085fb4d8a833cb64274caf1 DIFF: https://github.com/llvm/llvm-project/commit/df0c983643222b8b2085fb4d8a833cb64274caf1.dif

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757 SanOpts.set(SanitizerKind::HWAddress, false); + if (mask & SanitizerKind::LocalBounds) +Fn->addFnAttr(llvm::Attribute::NoSanitizeBounds); melver wrote: >

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411495. xbolva00 added a comment. Small doc update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411493. lichray added a comment. - Remove decltype(auto) from the patch - Parenthesize deduced casts in AST print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 File

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757 SanOpts.set(SanitizerKind::HWAddress, false); + if (mask & SanitizerKind::LocalBounds) +Fn->addFnAttr(llvm::Attribute::NoSanitizeBounds); ztong0001 wrote: >

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

kda added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1872 // Ignore trivial destructors. + if (BaseClassDecl->hasTrivialDestructor()) { Maybe not "Ignore"? Comment at: clang/lib/CodeGen/CGClass.cpp:1907 // I

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. I think I will update release notes later, after always_inline variant of this patch. So looks like we are almost done here? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411489. xbolva00 added a comment. Addressed review comments. Feel free to suggest better wording :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

aaron.ballman added a comment. It looks like precommit CI is failing: Failed Tests (1): Clang Tools :: clang-tidy/checkers/performance-unnecessary-value-param.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

MaskRay added a comment. In D120301#3346236 , @vtjnash wrote: > Seems extra complexity, and less desirable to lose test coverage, when it > seems the option may already be unreliable and soon to be deprecated by > https://reviews.llvm.org/D119383. @Mask

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119600/new/ https://reviews.llvm.org/D119600 ___ cfe-c

[libunwind] 84647ff - [libunwind][test] remember_state_leak.pass.sh.s: link with -no-pie

Author: Fangrui Song Date: 2022-02-25T19:55:56Z New Revision: 84647ff38ca76136e3c4be80cf6785a78188d33a URL: https://github.com/llvm/llvm-project/commit/84647ff38ca76136e3c4be80cf6785a78188d33a DIFF: https://github.com/llvm/llvm-project/commit/84647ff38ca76136e3c4be80cf6785a78188d33a.diff LOG:

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

vtjnash added a subscriber: MaskRay. vtjnash added a comment. Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate? Repository: rG LLVM Git

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

HassanElDesouky added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} njames93 wrote: > SimplyDanny wrote: >

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3345978 , @MaskRay wrote: > In D120305#3345810 , @RKSimon wrote: > >> @MaskRay The ppc buildbots have been red since these patches - please can >> you take a look? https://lab.

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3344890 , @pengfei wrote: > Disscussed with GCC folks. We think it's better to use the same way as > D120411 that replacing it with short int. Which GCC folks did you discuss

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:23 + + [[gnu::noinline]] bar(); // expected-warning {{'noinline' attribute is ignored in statements as it only applies to functions}} +} aaron.ballman wrote: > xbolva00 wrote: > > aar

[PATCH] D120577: [14.x] [clang] [test] Skip hip-fpie-option.hip if default-pie

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems fine to push to `release/14.x`. Several Linux distros will use CLANG_DEFAULT_PIE_ON_LINUX=on and they might wonder why the test fails. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D120577: [14.x] [clang] [test] Skip hip-fpie-option.hip if default-pie

mgorny created this revision. mgorny added a reviewer: MaskRay. Herald added a subscriber: yaxunl. mgorny requested review of this revision. Skip the hip-fpie-option.hip Driver test if default-pie-on-linux is used. This test currently relies on default-no-pie, and it has been changed to require d

[PATCH] D119061: [Clang] noinline call site attribute

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:23 + + [[gnu::noinline]] bar(); // expected-warning {{'noinline' attribute is ignored in statements as it only applies to functions}} +} xbolva00 wrote: > aaron.ballman wrote: >

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 updated this revision to Diff 411457. ztong0001 added a comment. - update commit description - In: CodeGenFunction::StartFunction(), merge two checks(SanitizerKind::LocalBounds, SanitizerKind::ArrayBounds) into one(SanitizerKind::Bounds) - update test: clang/test/CodeGen/bounds-checkin

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:23 + + [[gnu::noinline]] bar(); // expected-warning {{'noinline' attribute is ignored in statements as it only applies to functions}} +} aaron.ballman wrote: > It might be nice to cla

[PATCH] D119061: [Clang] noinline call site attribute

aaron.ballman added a comment. Also, it looks like there are some clang-format nits that can be addressed. Comment at: clang/include/clang/Basic/AttrDocs.td:525 + +``noinline`` attribute can also be used as a Clang-specific statement attribute. +If a statement is marked ``noin

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757 SanOpts.set(SanitizerKind::HWAddress, false); + if (mask & SanitizerKind::LocalBounds) +Fn->addFnAttr(llvm::Attribute::NoSanitizeBounds); ztong0001 wrote:

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis created this revision. Herald added subscribers: arphaman, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM G

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444b

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3345810 , @RKSimon wrote: > @MaskRay The ppc buildbots have been red since these patches - please can you > take a look? https://lab.llvm.org/buildbot/#/builders/57/builds/15454 Seems that ppc64 doesn't support lsan -

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757 SanOpts.set(SanitizerKind::HWAddress, false); + if (mask & SanitizerKind::LocalBounds) +Fn->addFnAttr(llvm::Attribute::NoSanitizeBounds); melver wrote: >

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer updated this revision to Diff 411448. fmayer added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120437/new/ https://reviews.llvm.org/D120437 Files:

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added a comment. In D119816#3345302 , @melver wrote: > Looks good. Few minor changes. > > I did some more digging, and it's only fsanitize=local-bounds, so please > verify this and also update the commit description. In fact, the Linux kernel

[PATCH] D120563: [HIP] Fix test hip-link-bundled-archive.hip

shangwuyao accepted this revision. shangwuyao added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120563/new/ https://reviews.llvm.org/D120563 ___ cfe-c

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411447. phyBrackets added a comment. update the documentation for the uninitialized read checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/do

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @erichkeane Thanks for suggestion. I will add as an independent type then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 ___ cf

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

erichkeane added a comment. In D120296#3345831 , @yonghong-song wrote: > @aaron.ballman Thanks for suggestion. Agree that Having a new Type is a > better idea. I guess, I will add BTFTagAttributeType which extends > AttributeType to see whether it work

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @aaron.ballman Thanks for suggestion. Agree that Having a new Type is a better idea. I guess, I will add BTFTagAttributeType which extends AttributeType to see whether it works or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

schweitz added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:43 using namespace Fortran::frontend; +using namespace llvm; You'll want to keep in mind that some class names are overloaded between llvm and Fortran::xyz namespaces and even

  1   2   >