MaskRay added a comment. In D120305#3347142 <https://reviews.llvm.org/D120305#3347142>, @tstellar wrote:
> In D120305#3347139 <https://reviews.llvm.org/D120305#3347139>, @MaskRay wrote: > >> In D120305#3347109 <https://reviews.llvm.org/D120305#3347109>, @tstellar >> wrote: >> >>> [...] >>> The issue here has nothing to do with the technical merits of the patch or >>> what the root cause of the problem is. The policy for this project is that >>> if you commit a patch that breaks someone's configuration (especially a >>> buildbot), then it needs to be fixed quickly or reverted. I get that this >>> policy can be frustrating as a committer when you feel your patch is >>> correct, and the real problem is elsewhere, but this is still the policy >>> and it should be followed. >> >> 7 hours ago my >> https://github.com/llvm/llvm-zorg/commit/b6ddf02ce3a54da2df29e7e599b1838167e0e3ad >> was sufficient to fix the issue and was the suggested fix in my opinion. >> Unfortunately nobody on the PowerPC side made the change effective in the >> build bot. Rather, I received such a heated message >> (https://reviews.llvm.org/D120305#3347058). >> It was another way to fix the redness (revert) but IMO not justified. > > I feel like we are talking past each other at this point, but in general > changing the buildbot configuration is not an acceptable solution to a broken > bot. Did the bot owner approve that change? Unsure why it isn't acceptable. There is fairly strong evidence that that specific ppc64le buildbot has a stability issue and `-DCLANG_DEFAULT_PIE_ON_LINUX=OFF` keeps it as if before this CMake patch. We can always discuss this with @nemanjai in another place, e.g. in IRC if we want to stop bothering others subscribing to this thread. (The trunk is clean and churn-less (there is no revert so downstream users will not get changed behaviors back and forth)). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
