[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki added a comment. Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the LLVM 14 release branch too, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 ___

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. This seems OK. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118257/new/ https://reviews.llvm.org/D118257 __

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

craig.topper added a comment. In D110869#3295906 , @void wrote: > In D110869#3295578 , > @nickdesaulniers wrote: > >> In D110869#3295559 , @void wrote: >> >>> Weird. We g

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

curdeius added a comment. Well, I thought about this approach but actually a macro line should never be merged together with a preceding line, so I went for a generic approach. That's because one never knows what's in a macro, it can well be a function brace after all depending on what goes befo

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295578 , @nickdesaulniers wrote: > In D110869#3295559 , @void wrote: > >> Weird. We generate similar code to GCC: >> >> Clang: >> _paravirt_ident_64: # @_

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. In D118104#3294883 , @LegalizeAdulthood wrote: > What is the feasibility of Python unit tests Instead of a heavy-weight `lit` > oriented test? I don't know the code-base well enough to answer that. Is python used for testing pu

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Bhramar.vatsa added a comment. @dblaikie The condition "FieldClass->isPOD()" returns false for the following case (when considering field 'struct foo t' of 'struct foo1') : class foo { foo() = default; int _a; }; struct foo1 { struct foo t; } t1; The same code though

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `l_brace` token in a macro definition s

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

kkwli0 created this revision. kkwli0 added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. kkwli0 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add the search path for llvm-strip instead of solely relyi

[PATCH] D118964: Fix broken 2-stage build when -tblgen tools may depend on runpath that is not yet built

arcivanov created this revision. arcivanov added reviewers: LLVM, clang. arcivanov added projects: clang, LLVM. Herald added a subscriber: mgorny. arcivanov requested review of this revision. Herald added a subscriber: cfe-commits. In my case `-tblgen` tools in the **second stage** end up being bu

[PATCH] D118949: [HIP] Support code object v5

yaxunl marked 2 inline comments as done. yaxunl added a comment. Will revise as recommended when committing. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118949/new/ https://reviews.llvm.org/D118949 ___ cfe-commits mailing list cfe-c

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405842. hctim added a comment. (forgot to add REQUIRES: aarch64 to the lld test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Diag

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3295321 , @MaskRay wrote: > I haven't investigated the use case yet, just commented a few things. Please > split the patch into 3: > > - BinaryFormat/ELF.h (see an inline comment) > - lld/ELF > - clang Can you clarify w

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. In D110869#3295559 , @void wrote: > Weird. We generate similar code to GCC: > > Clang: > _paravirt_ident_64: # @_paravirt_ident_64 > movq%rdi, %rax > xorq%rdi, %rdi >

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405839. hctim marked an inline comment as done. hctim added a comment. Address Ray's comments, and made it so that stack MTE doesn't imply heap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://r

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 9 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536 +enum { + NT_TYPE_IDENT = 1, + NT_TYPE_KUSER = 3, MaskRay wrote: > If Android wants to define notes, can it use a namespace `NT_ANDROID_*`

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc4ca95b02b: [OpenMP] Add Cuda path to linker wrapper tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8cc4ca9 - [OpenMP] Add Cuda path to linker wrapper tool

Author: Joseph Huber Date: 2022-02-03T20:39:18-05:00 New Revision: 8cc4ca95b02bc5b5b668b3d537b45a6585575cba URL: https://github.com/llvm/llvm-project/commit/8cc4ca95b02bc5b5b668b3d537b45a6585575cba DIFF: https://github.com/llvm/llvm-project/commit/8cc4ca95b02bc5b5b668b3d537b45a6585575cba.diff

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295477 , @nathanchance wrote: > It looks like `_paravirt_ident_64()` is the problematic function. This diff > on top of v5.17-rc2 allows me to boot: > > diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravi

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405837. tianshilei1992 added a comment. add final test and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/Diag

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. It looks like `_paravirt_ident_64()` is the problematic function. This diff on top of v5.17-rc2 allows me to boot: diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 4420499f7bb4..c1b68504136c 100644 --- a/arch/x86/kernel/paravirt.c +

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11206 +if (!E->isInstantiationDependent()) { + auto Type = E->getType(); + if (!Type->isScalarType()) { ABataev wrote: >

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405827. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files:

[PATCH] D118890: [clang][deps] Disable global module index

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. I agree that testing this isn't really necessary given the difficulty of even constructing one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm.org/D118915 _

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 3 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:421-424 + // Parse variadic identifier arg. This can either consume identifiers or + // expressions. + // FIXME: Variadic identifier args

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 405820. steffenlarsen added a comment. Adjusted for comments and introduced common handling for creating attributes with delayed arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: c

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 _

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added inline comments. Comment at: lld/ELF/SyntheticSections.cpp:3871 + return sizeof(llvm::ELF::Elf64_Nhdr) + + /* namesz */ sizeof(kMemtagAndroidNoteName) + + /* descsz */ sizeof(uint32_t); `/*namesz=*/` Comment at: l

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added a comment. I haven't investigated the use case yet, just commented a few things. Please split the patch into 3: - BinaryFormat/ELF.h (see an inline comment) - lld/ELF - clang Comment at: lld/ELF/SyntheticSections.cpp:3842 +static constexpr char kMemtagAndroidN

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG65aa47301372: [clang][utils] Remove StringRef lldb summary provider (authored by kastiglione). Repository: rG LLVM Gith

[clang] 65aa473 - [clang][utils] Remove StringRef lldb summary provider

Author: Dave Lee Date: 2022-02-03T15:16:31-08:00 New Revision: 65aa47301372b0f46d69977eb87aec60976e8246 URL: https://github.com/llvm/llvm-project/commit/65aa47301372b0f46d69977eb87aec60976e8246 DIFF: https://github.com/llvm/llvm-project/commit/65aa47301372b0f46d69977eb87aec60976e8246.diff LOG:

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione added a comment. The StringRef provider was improved in D117779 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116987/new/ https://reviews.llvm.org/D116987 ___

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405814. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test clan

[PATCH] D118949: [HIP] Support code object v5

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few nits, LGTM in general. Comment at: clang/lib/Driver/ToolChains/ROCm.h:27 +struct DeviceLibABIVersion { + unsigned Value = 0; + DeviceLibABIVersion(unsigned V) : Value(V) {} -

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Can you do me a favor and run the command

[clang] da20df2 - Revert "[OpenMP] Don't use bound architecture when checking cache on the host"

Author: Joseph Huber Date: 2022-02-03T17:43:10-05:00 New Revision: da20df21157f316648447b21f2ce6cf79a5ef57c URL: https://github.com/llvm/llvm-project/commit/da20df21157f316648447b21f2ce6cf79a5ef57c DIFF: https://github.com/llvm/llvm-project/commit/da20df21157f316648447b21f2ce6cf79a5ef57c.diff

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This fixed it on the mac I got to test it

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm

[PATCH] D118949: [HIP] Support code object v5

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: dang, kerbowa, jvesely. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. New device library supporting v4 and v5 has abi_version_400.bc a

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405799. jhuber6 added a comment. Use long version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295147 , @nathanchance wrote: > > I tested this patch but it did not change the hang. Okay. We need to determine which function is failing. Could you do something like this: #define zcur __attribute__((zero_call

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, dang, arichardson, emaste. Herald added a reviewer: MaskRay. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Current

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:937 case llvm::ARM::ArchKind::ARMV9_2A: getTargetDefinesARMV83A(Opts, Builder); break; SjoerdMeijer wrote: > Perhaps unrelated to thi

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai added a comment. `libomptarget :: x86_64-pc-linux-gnu :: mapping/delete_inf_refcount.c` has failed due to > /usr/bin/ld: final link failed: bad value As far as I can tell, it's not related to my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. In D110869#3295012 , @void wrote: > In D110869#3294696 , @nathanchance > wrote: > >> This diff allows me to boot on bare metal as of v5.17-rc2: >> >> diff --git a/arch/x86/kernel/M

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/arm64-arguments.c:203 + __builtin_va_start(ap, i); + // TODO: Add proper checks here. + _Bool b = __builtin_va_arg(ap, _Bool);

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8163 +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); + break; Would be better to keep aligned with `clang

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 updated this revision to Diff 405786. tyb0807 edited the summary of this revision. tyb0807 added a comment. Add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Driver/Tool

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9138d96f8b01: [OpenMP] Don't use bound architecture when checking cache on the host (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[clang] 9138d96 - [OpenMP] Don't use bound architecture when checking cache on the host

Author: Joseph Huber Date: 2022-02-03T17:17:38-05:00 New Revision: 9138d96f8b01605b213e8c4d587853a46cca3f44 URL: https://github.com/llvm/llvm-project/commit/9138d96f8b01605b213e8c4d587853a46cca3f44 DIFF: https://github.com/llvm/llvm-project/commit/9138d96f8b01605b213e8c4d587853a46cca3f44.diff

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405785. jhuber6 added a comment. Decided to add break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/cl

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405783. jhuber6 added a comment. Address style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-lin

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8161-8162 + if (CudaInstallation.isValid()) +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); +} Meinersbur wr

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. In D114732#3294794 , @devin.jeanpierre wrote: > Oops, sorry about that. What is the correct way to test/reproduce the change? > Do I / can I submit builds to the buildbot manually for testing? > > Also, should I be rolling back th

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

Meinersbur added a comment. Thanks for the fix Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8151-8152 const char *LinkingOutput) const { + const auto &D = getToolChain().getDriver(); + const auto TheTriple = getToolChain().getTriple(); +

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG3d0b61926139: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnus

[clang] 3d0b619 - [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

Author: Björn Schäpers Date: 2022-02-03T22:55:27+01:00 New Revision: 3d0b619261392f5f24a7b9961b24cdd621829c13 URL: https://github.com/llvm/llvm-project/commit/3d0b619261392f5f24a7b9961b24cdd621829c13 DIFF: https://github.com/llvm/llvm-project/commit/3d0b619261392f5f24a7b9961b24cdd621829c13.diff

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3294696 , @nathanchance wrote: > This diff allows me to boot on bare metal as of v5.17-rc2: > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index 6aef9ee28a39..8ee176dac669 100644 > --- a/arch

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88e4e6be16ea: [clang-format] Use wider comment prefix space rule (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 88e4e6b - [clang-format] Use wider comment prefix space rule

Author: ksyx Date: 2022-02-03T21:49:10Z New Revision: 88e4e6be16ea400948c06f972f1b5f19478528df URL: https://github.com/llvm/llvm-project/commit/88e4e6be16ea400948c06f972f1b5f19478528df DIFF: https://github.com/llvm/llvm-project/commit/88e4e6be16ea400948c06f972f1b5f19478528df.diff LOG: [clang-f

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 405775. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, Meinersbur. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The linker wrapper tool uses the 'nv

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Thank you @gribozavr2 ! I'll hopefully have a roll-forward ready for you either today or tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 __

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

gribozavr2 added a comment. I rolled it back while @devin.jeanpierre investigates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 ___ cfe-commits mailing list

[clang] 852afed - Revert "[clang] Mark `trivial_abi` types as "trivially relocatable"."

Author: Dmitri Gribenko Date: 2022-02-03T22:31:44+01:00 New Revision: 852afed5e0200b70047c28ccf4424a17089d17b0 URL: https://github.com/llvm/llvm-project/commit/852afed5e0200b70047c28ccf4424a17089d17b0 DIFF: https://github.com/llvm/llvm-project/commit/852afed5e0200b70047c28ccf4424a17089d17b0.dif

[PATCH] D118428: [clang-cl] Support the /JMC flag

rnk added a comment. In D118428#3294935 , @ychen wrote: > The instrumentation is per-function, ideally for each function that has > debuginfo and ends up in the executable. So I want it to happen the last in > the IR codegen pipeline (target could arran

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3294880 , @rnk wrote: > In D118428#3294411 , @ychen wrote: > >> The passes in `lib/Transforms/Instrumentation` runs with >> `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pas

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 405765. dgoldman added a comment. mergingEdit --> manual file checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refactor/tweak

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3292862 , @JesApp wrote: > In general though, I think the script is complex enough to warrant some > testing. What is the feasibility of Python unit tests Instead of a heavy-weight `lit` oriented test? CH

[PATCH] D118428: [clang-cl] Support the /JMC flag

rnk added a comment. In D118428#3294411 , @ychen wrote: > The passes in `lib/Transforms/Instrumentation` runs with > `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pass runs with > `EmitAssemblyHelper::RunCodegenPipeline`. Sure, but that's a choice

[PATCH] D118942: [Driver][Android] Removed obsoleted --warn-shared-textrel

MaskRay created this revision. MaskRay added reviewers: danalbert, srhines. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. --warn-shared-textrel is ignored in ld.lld and obsoleted in GNU ld (h

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f14d6f2ee: [VFS] Add a "redirecting-with" field to overlays (authored by bnbarham, committed by keith). Changed prior to commit: https://review

[clang] 502f14d - [VFS] Add a "redirecting-with" field to overlays

Author: Ben Barham Date: 2022-02-03T13:10:23-08:00 New Revision: 502f14d6f2eee10d2993ed22d820f12cf52462d6 URL: https://github.com/llvm/llvm-project/commit/502f14d6f2eee10d2993ed22d820f12cf52462d6 DIFF: https://github.com/llvm/llvm-project/commit/502f14d6f2eee10d2993ed22d820f12cf52462d6.diff LO

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95d609b549bb: [HWASan] Add __hwasan_init to .preinit_array. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 95d609b - [HWASan] Add __hwasan_init to .preinit_array.

Author: Matt Morehouse Date: 2022-02-03T13:07:58-08:00 New Revision: 95d609b549bbdc3c1b7368eac427b9e6628f4ace URL: https://github.com/llvm/llvm-project/commit/95d609b549bbdc3c1b7368eac427b9e6628f4ace DIFF: https://github.com/llvm/llvm-project/commit/95d609b549bbdc3c1b7368eac427b9e6628f4ace.diff

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118171/new/ https://reviews.llvm.org/D118171 ___ cfe-c

[PATCH] D118934: [OpenMP] Completely remove old device runtime

jdoerfert added a comment. Don't backport. Deprecate the flag and that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118934/new/ https://reviews.llvm.org/D118934 ___ cfe-commits mailing list cfe-

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm.org/D118858 ___

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118781/new/ https://reviews.llvm.org/D118781

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Oops, sorry about that. What is the correct way to test/reproduce the change? Do I / can I submit builds to the buildbot manually for testing? Also, should I be rolling back this change, or no? Not sure of the protocol here, this is my first change to Clang. P

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:208-209 Text.append({EnumD->getName(), "::"}); Text.append({EnumConstant.second.getEnumConstant()->getName(), ":"}); +Text += "break;"; }

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

dblaikie added a comment. after: 10978519 before: 11245451 Doesn't appear to be a /huge/ win to me... but I don't mind too much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118781/new/ https://reviews.llvm.org/D118781 __

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. This diff allows me to boot on bare metal as of v5.17-rc2: diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 6aef9ee28a39..8ee176dac669 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -125,6 +125,7 @@ obj-$(CONFI

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

DmitryPolukhin added a comment. @ivanmurashko Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes). `struct Include` is a light weight structure so having a copy seems to be the simplest solution. Rep

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. Hi, your change is causing a test failure in the test attr-trivial-abi.cpp that you modified on the PS4 Windows box: https://lab.llvm.org/staging/#/builders/204/builds/758/steps/7/logs/FAIL__Clang__attr-trivial-abi_cpp TEST 'Clang :: SemaCXX/attr-tr

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a)

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added a comment. If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius planned changes to this revision. curdeius added a comment. I'll test it tomorrow but probably a define with a hash as the last character may do the job and show the faulty behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/ne

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { HazardyKnusperkeks wrote: > I really don't like bitwise operations on bool. Hit some nasty bugs at

[PATCH] D118792: [lld][clang][cmake] Clean up a few things

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0eeae9a4470: [lld][clang][cmake] Clean up a few things (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e0eeae9 - [lld][clang][cmake] Clean up a few things

Author: John Ericson Date: 2022-02-03T20:01:28Z New Revision: e0eeae9a447004cc346d9bf36c0d02f45e276a7c URL: https://github.com/llvm/llvm-project/commit/e0eeae9a447004cc346d9bf36c0d02f45e276a7c DIFF: https://github.com/llvm/llvm-project/commit/e0eeae9a447004cc346d9bf36c0d02f45e276a7c.diff LOG:

[PATCH] D118934: [OpenMP] Completely remove old device runtime

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118934: [OpenMP] Completely remove old device runtime

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -O1 doesn't seem necessary here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118936 Files: clang/test/CodeGen/sanitize-addres

[PATCH] D118934: [OpenMP] Completely remove old device runtime

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I've read this closely and can't think of anywhere else that needs to be patched. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue, -

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon created this revision. Fznamznon added a reviewer: bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { I really don't like bitwise operations on bool. Hit some nasty bugs at my job. ===

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

jdoerfert added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a); tianshilei1992 wrote: > I cannot fi

  1   2   3   >