tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Few nits, LGTM in general.
================
Comment at: clang/lib/Driver/ToolChains/ROCm.h:27
+struct DeviceLibABIVersion {
+ unsigned Value = 0;
+ DeviceLibABIVersion(unsigned V) : Value(V) {}
----------------
`ABIVersion`?
================
Comment at: clang/lib/Driver/ToolChains/ROCm.h:29
+ DeviceLibABIVersion(unsigned V) : Value(V) {}
+ static DeviceLibABIVersion fromCodeObjectVersion(unsigned V) {
+ if (V < 4)
----------------
CodeObjectVersion
================
Comment at: clang/lib/Driver/ToolChains/ROCm.h:34-39
+ /// Whether ABI version bc file is requested.
+ bool requiresLibrary() { return Value >= 500; }
+ std::string toString() {
+ assert(Value % 100 == 0 && "Not supported");
+ return Twine(Value / 100).str();
+ }
----------------
This could use a comment on how code object version relates to the ABI version
and what makes ABI version 500 special.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118949/new/
https://reviews.llvm.org/D118949
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
