tyb0807 marked 2 inline comments as done.
tyb0807 added inline comments.
================
Comment at: clang/lib/Basic/Targets/ARM.cpp:937
case llvm::ARM::ArchKind::ARMV9_2A:
getTargetDefinesARMV83A(Opts, Builder);
break;
----------------
SjoerdMeijer wrote:
> Perhaps unrelated to this patch, but I am surprised to see that from v 8.3
> and up we only include `getTargetDefinesARMV83A`, so no other target defines
> were introduced or are necessary? This is not rhetorical question....I
> haven't paid attention to this since v8.4.
It seems that most of the time, `getTargetDefinesARMV8(x)A` only includes
`getTargetDefinesARMV8(x-1)A` (see `AArch64TargetInfo::getTargetDefines`). What
we have here is a equivalent way to do that, with less boilerplate code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116153/new/
https://reviews.llvm.org/D116153
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
