[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I'm not a fan of this approach of adding a "C" language, mainly because of the `.h` problem so ultimately it doesn't solve your problem. I think this is overkill for

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for contributing! Let's wait a day or two before landing to let other reviewers chime in. Do you need help landing? If so please provide your name and email address that you'd

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

Sockke accepted this revision. Sockke added a comment. This revision is now accepted and ready to land. I think it looks great and safe enough. It would be better to turn `!(*ptr).empty()` into `!ptr->empty()`, but I have no particular opinions at this point. Let's see if @aaron.ballman has an

[PATCH] D117493: [clang][dataflow] Replace initValueInStorageLocation with createValue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG782eced56149: [clang][dataflow] Replace initValueInStorageLocation with createValue (authored by sgatev). Herald added a subscriber: steakhal. Repos

[clang] 782eced - [clang][dataflow] Replace initValueInStorageLocation with createValue

Author: Stanislav Gatev Date: 2022-01-18T07:09:35Z New Revision: 782eced561492c74f7b4409d6ee7eee84a1647c7 URL: https://github.com/llvm/llvm-project/commit/782eced561492c74f7b4409d6ee7eee84a1647c7 DIFF: https://github.com/llvm/llvm-project/commit/782eced561492c74f7b4409d6ee7eee84a1647c7.diff LO

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 400733. achieveartificialintelligence added a comment. Herald added subscribers: alextsao1999, eopXD. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.o

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The address-of part looks good to me. However, just realized that I'm not convinced whether the dereference operator, or references, in general, are correctly handled. ===

[libunwind] f16a4a0 - [libcxx][libcxxabi][libunwind][cmake] Use `GNUInstallDirs` to support custom installation dirs

Author: John Ericson Date: 2022-01-18T06:44:57Z New Revision: f16a4a034a279f52c33f41cafb7d9751ee8a01dd URL: https://github.com/llvm/llvm-project/commit/f16a4a034a279f52c33f41cafb7d9751ee8a01dd DIFF: https://github.com/llvm/llvm-project/commit/f16a4a034a279f52c33f41cafb7d9751ee8a01dd.diff LOG:

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) Ericson2314 wrote: > sebastian-ne wrote: > > Hi, addin

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Based on discussion, I'm going to move this as a private matcher in the check where I intend to use it. Therefore, I'm abandoning this review. I look forward to seeing Yitzhak's generalized matcher `:)` CHANGES SINCE

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

xazax.hun added a comment. Hi! Overall the check looks good to me, I have only one problem. We usually try to emit fixes if some parts of the replaced text is a macro, e.g.: #define MYMACRO(X) count(X) if (myCont.MYMACRO(X)) ... In the above code snippet, we want to avoid modifying t

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. These are just initial changes, there is still a lot of work and test cases to write. I figured I would put this out there to see if this is the direction we were thinking. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2504 nextToken();

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400718. psigillito added a comment. - annoying arc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint clang/include/clang/Format/Format.h

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400717. psigillito added a comment. - undo delete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint clang/include/clang/Format/Format.h clang/l

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400715. psigillito added a comment. Include multiple commits in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint clang/include/clang/Form

[PATCH] D117536: Handle C variables with name that matches c++ access specifier

psigillito created this revision. psigillito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. revert old changes, breakout c into own language initial changes revert arclint changes revert bad arclint change Repository: rG LLVM Github

[PATCH] D117535: [clang-tidy] Force LF newlines when writing files

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: alexfh, Quuxplusone, aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. LegalizeAdulthood requested review of this revision. The recommendation on Windo

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:339 +if (ISAInfo.hasExtension("d")) + return "ilp32d"; return "ilp32"; khchen wrote: > why do we need to change the order? IMO, when `e` is combined with `d`, `e` shou

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/IncludeInserter.h:20 namespace tidy { -namespace utils { njames93 wrote: > LegalizeAdulthood wrote: > > njames93 wrote: > > > LegalizeAdulthood wrote: > > > > What's the guidance

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400708. psigillito added a comment. Hopefully this revision works Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint clang/include/clang/Format/Fo

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400706. psigillito added a comment. revert changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint Index: .arclint

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 400704. psigillito added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Removed old approach and started initial changes to add C language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:182 + MD->getMacroInfo()->isUsedForHeaderGuard() || + MD->getMacroInfo()->isBuiltinMacro() || ConditionScope > 0) +return; LegalizeAdult

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 400700. LegalizeAdulthood added a comment. Addresses most of the review comments, still need to: - Verify that include guards don't interfere with analysis of headers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://revie

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:192-194 + if (LastFile != CurrentFile) { +LastFile = CurrentFile; +newEnum(); LegalizeAdulthood wrote: > njames93 wrote: > > This seems a str

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

pjessesco updated this revision to Diff 400697. pjessesco marked 2 inline comments as done. pjessesco added a comment. Fix to accept feedbacks. 1. `Forth` -> `Fourth` 2. Add unit test `verifyFormat("< <>");` 3. Fix to avoid undefined behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 13 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:134 + +bool MacroToEnumCallbacks::isConsecutiveMacro(const MacroDirective *MD) const { + if (LastMacroLocation.is

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

khchen added a comment. 1. please add a check here and a clang cc1 test for it. 2. Have you try to run llvm-test-suite with rv32e config on qemu? Commen

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo updated this revision to Diff 400696. glotchimo marked an inline comment as done. glotchimo added a comment. Simplify by removing look-ahead (unnecessary b/c of difference between ident and tokens). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. Herald added subscribers: alextsao1999, eopXD. Gentle ping. We are testing this patch and I'd like to get some nice advice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 ___

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto &NextLine = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (NextLine.Type == LT_Invalid || NextLine.First->MustBreakBefore) --

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto &NextLine = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (NextLine.Type == LT_Invalid || NextLine.First->MustBreakBefore) --

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-macro-to-enum.rst:45 + enum { + RED = 0xFF, + GREEN = 0x00FF00, Eugene.Zelenko wrote: > It'll be reasonable to support indentation. Option could be used to spec

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Build a fast factory

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.h:19 + +/// FIXME: Write a short description. +/// njames93 wrote: > FIXME Please do this :-) Comment at: clang-tools-extra/clang-tidy/mod

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/IncludeInserter.h:20 namespace tidy { -namespace utils { LegalizeAdulthood wrote: > njames93 wrote: > > LegalizeAdulthood wrote: > > > What's th

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

njames93 added a comment. How does this handle cases where a macro is Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:106 + +bool hasBlankLines(const std::string &Text) { + enum class WhiteSpaceState { Comment at: cl

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 400680. fwolff added a comment. Fixed the nits. Thanks for the review @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCh

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 400677. fwolff added a comment. Rebased and ping @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff added a comment. @aaron.ballman Ping? I think I've responded to all comments so far; let me know if you still have concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 ___ cfe-commits ma

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff marked an inline comment as done. fwolff added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp:291-293 +struct super_throws { + super_throws() noexcept(false) { throw 42; } +}; aaron.ballman wrote: >

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff updated this revision to Diff 400668. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113507/new/ https://reviews.llvm.org/D113507 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp Index: cl

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 400667. ksyx added a comment. Apply clangfmt's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp clang/unittests/Format/DefinitionBlockSepara

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. RFC: Should we create a cppcoreguidelines alias since this implements "Enum.1: Prefer enumerations over macros "? This check tries to be very conservative so as to not generate false posi

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: alexfh, njames93, aaron.ballman, JonasToth. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. LegalizeAdulthood requested review of this revision. This check

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx created this revision. ksyx added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes https://github.com/llvm/llvm-project/issues/53227 that wrongly indents multiline c

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

ksyx added a comment. In D92257#3004563 , @HazardyKnusperkeks wrote: > In D92257#3003281 , @byronhe wrote: > >> Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding >> such as utf8 ， >> I am

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:735-742 +if (C.Tok->Previous && C.Tok->Previous->is(tok::kw_operator)) { + FormatToken *Next = C.Tok->Next; + while (Next && Next->NewlinesBefore == 0) { +if

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. Friendly ping. Would be good to get these performance improvements into trunk soon, so that we're not prolonging the time that people are putting up with the current slow implementation. Also, I believe that LLVM 14.0.0 will be up for a release candidate soon,

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1696 + } + EXPECT_EQ(Found, true); +} It would also be poss

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff updated this revision to Diff 400634. fwolff added a comment. I've added the `static_cast` and an entry in the release notes. I'm not sure how to handle `[[no_unique_address]]`, so I'd rather leave this to future work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/new/ ht

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 400631. arnamoy10 added a comment. Updating as per reviewers comments. Adding a test case in `OpenMPIRBuilderTest.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/ https://reviews.llvm.org/D114379 Files: clang/lib/CodeGen/CGStmtOp

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

fwolff updated this revision to Diff 400625. fwolff added a comment. In D115124#3209199 , @Sockke wrote: > Could you please add a test case where the smart pointer object is > dereferenced before calling `size()`? E.g. `return (*ptr).size() == 0;`. I >

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo updated this revision to Diff 400623. glotchimo marked 4 inline comments as done. glotchimo added a comment. Use `getPreviousNonComment` to account for inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://rev

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

LegalizeAdulthood added a comment. LGTM, but there are still some outstanding review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117306/new/ https://reviews.llvm.org/D117306 ___ cfe-commits m

[clang-tools-extra] 2cd2acc - [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

Author: Fabian Wolff Date: 2022-01-17T21:16:17+01:00 New Revision: 2cd2accc61ea0900bde66c79d1d04b29bb9e3ed7 URL: https://github.com/llvm/llvm-project/commit/2cd2accc61ea0900bde66c79d1d04b29bb9e3ed7 DIFF: https://github.com/llvm/llvm-project/commit/2cd2accc61ea0900bde66c79d1d04b29bb9e3ed7.diff

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd2accc61ea: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional… (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D114197?vs=391850&id=400618#toc Re

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:220-238 +llvm::Optional +ClangTidyCheck::createMainFileIncludeInsertion(StringRef Include) { + if (!Context->hasIncludeInserter()) { +// Only crash on debug builds +asser

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) sebastian-ne wrote: > Hi, adding this module path overwrites the `llvm_check_linker_flag` from > `l

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

curdeius added a comment. In D117421#3249126 , @glotchimo wrote: > I was tinkering with the use of `getPreviousNonComment` last night before > signing off and the problem that I noticed was that, though it stops the > `operator=` from being split and al

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto &NextLine = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (Ne

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. In D117421#3249196 , @glotchimo wrote: > In D117421#3247632 , @curdeius > wrote: > >> Could you check if your patch fixes >> https://github.com/llvm/llvm-project/issues/33044

[clang-tools-extra] 42bc327 - [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

Author: Fabian Wolff Date: 2022-01-17T20:50:32+01:00 New Revision: 42bc3275d3687524ddc0d20c72722b9324f87be4 URL: https://github.com/llvm/llvm-project/commit/42bc3275d3687524ddc0d20c72722b9324f87be4 DIFF: https://github.com/llvm/llvm-project/commit/42bc3275d3687524ddc0d20c72722b9324f87be4.diff

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG42bc3275d368: [clang-tidy] Fix `readability-redundant-declaration` false positive for… (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117321: [clang] Remap file path in __PRETTY_FUNCTION__

dblaikie added a comment. This seems like patching a hole, but maybe something more fundamental should be done if this remapping is meant to apply to all path rendering? (presumably there could be other bugs where these callbacks aren't applied - so is there somewhere lower level that this issu

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo added a comment. In D117421#3247632 , @curdeius wrote: > Could you check if your patch fixes > https://github.com/llvm/llvm-project/issues/33044 as well? > If so, please add tests. As of right now, it doesn't fix 33044. Should I investigate an

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

egorzhdan accepted this revision. egorzhdan added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo added a comment. I was tinkering with the use of `getPreviousNonComment` last night before signing off and the problem that I noticed was that, though it stops the `operator=` from being split and aligned with previous lines, it adds a single space: /* long long padding */ int() =

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

glotchimo updated this revision to Diff 400606. glotchimo marked an inline comment as done. glotchimo added a comment. Add overload declaration look-ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421

[PATCH] D112408: [RISCV][MC] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v_max_eew_fp", Twine(MaxEewFp));

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:432 + auto Forth = (Tokens.end() - 4)[0]; bool FourthTokenIsLess = false; MyDeveloperDay wrote: > isn't this going to crash if Tokens.size() is 3? It probably will. Anyway, it

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:432 + auto Forth = (Tokens.end() - 4)[0]; bool FourthTokenIsLess = false; isn't this going to crash if Tokens.size() is 3? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This needs a full context diff and ideally some unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114837/new/ h

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn updated this revision to Diff 400583. fhahn added a subscriber: Meinersbur. fhahn added a comment. Herald added a reviewer: bollu. Fix failing polly tests. @Meinersbur looks like some Polly tests were relying on the IRBuilder folding `and i1 %X, true`. This patch moves the logic to a dedic

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 added a comment. + @rsmith from CODE_OWNERS.txt: Hi Richard, could you please suggest a reviewer for this change? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114837/new/ https://reviews.llvm.org/D114837

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. @aaron.ballman @xazax.hun Could I ask one of you to finish the review here? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 __

[PATCH] D115456: [MS] Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 added a comment. In D115456#3248313 , @hans wrote: > Looks great, thanks! Maurice, do you want to add a note about this to > docs/ReleaseNotes.rst? Good point. I created a new change: https://reviews.llvm.org/D117500 Repository: rG LLVM Git

[PATCH] D117500: [clang] Mention MS on-demand TLS initialization in release notes

momo5502 created this revision. momo5502 added reviewers: majnemer, hans. momo5502 added a project: clang. momo5502 requested review of this revision. Herald added a subscriber: cfe-commits. In change https://reviews.llvm.org/D115456 on-demand TLS initialization for Microsoft CXX ABI was added.

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:65 +// Zbt extension +TARGET_BUILTIN(__builtin_riscv_cmov, "LiLiLiLi", "nc", "experimental-zbt") +TARGET_BUILTIN(__builtin_riscv_cmix, "LiLiLiLi", "nc", "experimental-zbt") ---

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 400572. mubashar_ marked 8 inline comments as done. mubashar_ added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/SourceCodeBuildersTest.cpp:373 +TEST(SourceCodeBuildersTest, BuildAccessSmartPointer) { + testBuilder(buildAccess, "Smart x; x;", "x->"); +} ymandel wrote: > gribozavr2 wrote: > > This is a ca

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. Do you need help landing the change? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one suggestion. Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:123 + 'lines.' +

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f0977519d12: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 6f09775 - [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString

Author: Jake Egan Date: 2022-01-17T11:24:16-05:00 New Revision: 6f0977519d12fc337e8bacd31dbaf84923e49b57 URL: https://github.com/llvm/llvm-project/commit/6f0977519d12fc337e8bacd31dbaf84923e49b57 DIFF: https://github.com/llvm/llvm-project/commit/6f0977519d12fc337e8bacd31dbaf84923e49b57.diff LOG

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e512f022ad5: [clang-format] Treat ForEachMacros as loops (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e512f0 - [clang-format] Treat ForEachMacros as loops

Author: Marek Kurdej Date: 2022-01-17T17:11:06+01:00 New Revision: 1e512f022ad5c23dc4ef4e663f51d5d0bcbc7c69 URL: https://github.com/llvm/llvm-project/commit/1e512f022ad5c23dc4ef4e663f51d5d0bcbc7c69 DIFF: https://github.com/llvm/llvm-project/commit/1e512f022ad5c23dc4ef4e663f51d5d0bcbc7c69.diff

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

saschanaz added a comment. https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your behalf. When doing so, please > provide the name and email address you would like

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

svenvh added a comment. @airlied are you still planning to land this? I started looking at the corresponding .td changes when I realized we don't use `__opencl_c_read_write_images` in `opencl-c.h` either yet. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

njames93 added a comment. In D117460#3248613 , @alexfh wrote: > I wonder what motivated the patch. Is this a performance optimization? If so, > do you have any measurements? I was doing some work on IncludeInserter and just thought, this seems unnecess

[PATCH] D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG875117ae7a21: [clang][dataflow] Remove TestingSupport's dependency on gtest (authored by ymandel). Changed prior to commit: https://reviews.llvm.o

[clang] 875117a - [clang][dataflow] Remove TestingSupport's dependency on gtest

Author: Yitzhak Mandelbaum Date: 2022-01-17T15:33:23Z New Revision: 875117ae7a21f0282e09a72addaf41dfd033cc55 URL: https://github.com/llvm/llvm-project/commit/875117ae7a21f0282e09a72addaf41dfd033cc55 DIFF: https://github.com/llvm/llvm-project/commit/875117ae7a21f0282e09a72addaf41dfd033cc55.diff

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

alexfh added a comment. I wonder what motivated the patch. Is this a performance optimization? If so, do you have any measurements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460 ___

[PATCH] D117493: [clang][dataflow] Replace initValueInStorageLocation with createValue

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. Since Environment's setValue method already does part of the work that initValueInStorageLocation does

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Tooling/SourceCodeBuildersTest.cpp:373 +TEST(SourceCodeBuildersTest, BuildAccessSmartPointer) { + testBuilder(buildAccess, "Smart x; x;", "x->"); +} gribozavr2 w

[PATCH] D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest

ymandel updated this revision to Diff 400543. ymandel added a comment. remove redundant assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117304/new/ https://reviews.llvm.org/D117304 Files: clang/unittests/Analysis/FlowSensitive/MultiVarCons

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

saschanaz added a comment. > Do you have commit access, or would you like me to commit it for you? I don't have the access, please do it for me 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117407/new/ https://reviews.llvm.org/D117407 _

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks! Do you have commit access, or would you like me to commit it for you? In D117407#3246794 , @saschanaz wrote: > That same check decorate_pro

[PATCH] D117491: [clangd] Remove redundant check for renamed symbol origin

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a follow-up on D116643

  1   2   >