alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
Looks good with one suggestion. ================ Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:123 + 'lines.' + '\nclang-tidy arguments should be passed after a \'--\' .') parser.add_argument('-clang-tidy-binary', metavar='PATH', ---------------- I'd say "can" instead of "should" (all defaults may be just fine depending on the setup) and maybe also add an example. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits