Ericson2314 added inline comments.
================
Comment at: llvm/CMakeLists.txt:209
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
+ "${LLVM_COMMON_CMAKE_UTILS}/Modules"
)
----------------
sebastian-ne wrote:
> Hi, adding this module path overwrites the `llvm_check_linker_flag` from
> `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` with the one defined in
> `cmake/Modules/CheckLinkerFlag.cmake`, which does not check the linker but
> the compiler.
> This breaks our gcc+ld build because ld does not support
> `--color-diagnostics`.
>
> Our downstream issue is here:
> https://github.com/GPUOpen-Drivers/llpc/issues/1645
Thanks for letting me know. Let's just rename the `/cmake` one then; nothing
there is installed, on purpose, so we can change it freely without worrying
breaking an interface used downstream.
I will make a patch for that in the next 2 days if no one beats me to it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116521/new/
https://reviews.llvm.org/D116521
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
