[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders added a comment. Yeah, I‘d need someone to commit this for me. About the std::map thing: let’s proceed as suggested and have @sammccall take look at it himself after :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well.

dblaikie added a comment. Would at. least need a test case, but otherwise sounds OK to make things a bit better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109411/new/ https://reviews.llvm.org/D109411 __

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Ping? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

rjmccall added a comment. I agree with Reid. IRGen should never be holding naked references (across different invocations as an `ASTConsumer`) to a replaceable entity. There are some entities that are known not to be replaceable, but in general the associated data of a global constructor does

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

NoQ accepted this revision. NoQ added a comment. This looks good! I guess one way to make this //even more// conservative would be to match the variable inside the delete-expression to the one we expect to get deallocated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108753/new/ http

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2292 + (op2_type op2_reg_class:$rs2), + (mask_type V0), GPR:$vl, sew, (XLenVT GPR:$policy))>; + Does timm:$policy work down here to

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem updated this revision to Diff 371245. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108881/new/ https://reviews.llvm.org/D108881 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Frontend/CompilerInvoc

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem added inline comments. Comment at: clang/lib/Driver/Driver.cpp:596-598 - (!Args.hasFlag(options::OPT_flto_EQ_auto, options::OPT_fno_lto, false) && -!Args.hasFlag(options::OPT_flto_EQ_jobserver, options::OPT_fno_lto, - false

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem updated this revision to Diff 371241. mnadeem added a comment. - - Make flto an alias of flto=full. - - Make foffload-lto an alias of foffload-lto=full. - - Make flto_EQ_jobserver, flto_EQ_auto aliases of flto=full, since they are being treated as full lto right now. - - Clean up the cod

[clang] b0d4d96 - [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series

Author: Justin Latimer Date: 2021-09-08T02:35:26Z New Revision: b0d4d969e22efd282047e51b7927c1ab53eccf32 URL: https://github.com/llvm/llvm-project/commit/b0d4d969e22efd282047e51b7927c1ab53eccf32 DIFF: https://github.com/llvm/llvm-project/commit/b0d4d969e22efd282047e51b7927c1ab53eccf32.diff LOG

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d4d969e22e: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series (authored by justinlatimer, committed by benshi001). Changed prior to

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well.

Quuxplusone created this revision. Quuxplusone added reviewers: ldionne, doug.gregor, rsmith, dblaikie, courbet, saar.raz. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. This comes from lengthy discussion between @Quuxplu

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and consiste

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. We should proceed after D108697 accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. FWIW, I dislike that we don't indent stuff at all inside namespaces -- often I find it useful to indent things inside short-lived namespaces. But let's go for simplicity and consistency. Di

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

Quuxplusone added inline comments. Comment at: libcxxabi/src/cxa_exception_storage.cpp:102 } } +} // namespace __cxxabiv1 LGTM, FWIW. It's surprising that clang-format adds `} // namespace foo` closing comments, but doesn't add `} // extern "C"` closing comme

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

rnk added a comment. This seems like a good use for a ValueHandle, even if it is slightly more code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109386/new/ https://reviews.llvm.org/D109386 ___ cfe-com

[PATCH] D109406: [clang] fix transformation of template arguments of 'auto' type constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68b9d8ed7abe: [clang] fix transformation of template arguments of 'auto' type constraints (authored by mizvekov). Repository: rG LLVM Github Monor

[clang] 68b9d8e - [clang] fix transformation of template arguments of 'auto' type constraints

Author: Matheus Izvekov Date: 2021-09-08T03:22:34+02:00 New Revision: 68b9d8ed7abe4046992ae1557990edfbb3a772bc URL: https://github.com/llvm/llvm-project/commit/68b9d8ed7abe4046992ae1557990edfbb3a772bc DIFF: https://github.com/llvm/llvm-project/commit/68b9d8ed7abe4046992ae1557990edfbb3a772bc.dif

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou created this revision. zhouyizhou added a reviewer: libcxx-commits. zhouyizhou requested review of this revision. Herald added projects: clang, libc++abi. Herald added a subscriber: cfe-commits. Herald added a reviewer: libc++abi. Some functions in cxa_exception_storage.cpp have incorre

[PATCH] D109406: [clang] fix transformation of template arguments of 'auto' type constraints

mizvekov created this revision. mizvekov published this revision for review. mizvekov added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR48617. When assigning the new template arguments to the new TypeLoc, we were looping on the argument count o

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added inline comments. Comment at: clang/test/Sema/i-c-e.c:77-78 + // expected-warning {{expression result unused}} +int comma3[(1, 2)]; // expected-warning {{variable length array folded to constant array as an extension}} \ + /

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 371221. ychen added a comment. Herald added a subscriber: jdoerfert. - Use more specific diagnoses "left operand of comma operator has no effect" when left operand of comma operator has no effect instead of "expression result is unused". Repository: rG LL

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG61d1cce2f835: PR45881: Properly use CXXThisOverride for templated lambda (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ http

[clang] 61d1cce - PR45881: Properly use CXXThisOverride for templated lambda

Author: Yuanfang Chen Date: 2021-09-07T17:02:24-07:00 New Revision: 61d1cce2f83571c00f76144d42a2dea2cb3ab1ca URL: https://github.com/llvm/llvm-project/commit/61d1cce2f83571c00f76144d42a2dea2cb3ab1ca DIFF: https://github.com/llvm/llvm-project/commit/61d1cce2f83571c00f76144d42a2dea2cb3ab1ca.diff

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

arphaman created this revision. arphaman added reviewers: tmatheson, ravikandhadai. Herald added a subscriber: ributzka. arphaman requested review of this revision. This change fixes a crash where a NULL fd was used to emit a diagnostic. Instead of crashing, just avoid printing the declaration nam

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcde8fdeeb3e: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile… (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D108808?vs=369040&id=371202#toc Reposi

[clang-tools-extra] dcde8fd - [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

Author: Artem Dergachev Date: 2021-09-07T15:10:46-07:00 New Revision: dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088 URL: https://github.com/llvm/llvm-project/commit/dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088 DIFF: https://github.com/llvm/llvm-project/commit/dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088.dif

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2988026 , @tejohnson wrote: > In D108881#2988016 , @steven_wu > wrote: > >> In D108881#2987990 , @mnadeem >> wrote: >> >>> In D1088

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

tejohnson added a comment. In D108881#2988016 , @steven_wu wrote: > In D108881#2987990 , @mnadeem wrote: > >> In D108881#2973735 , @steven_wu >> wrote: >> >>> In D108881#

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. If you didn't quite get what I mean, I am suggesting to cleanup all the reference to the old flag. Since `-flto` is rewrite by the driver to `-flto=full`, clang should not query `OPT_flto` anymore. All references to the old flag needs to be audited and removed while p

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

NoQ added a comment. It looks like this commit causes unexpected changes in non-C++ code. Eg., in this tiny reproducer (that uses the non-standard "blocks" feature but is otherwise plain C): typedef struct { int x; } S; void foo() { ^{ S s; return s; }; } I'm

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2987990 , @mnadeem wrote: > In D108881#2973735 , @steven_wu > wrote: > >> In D108881#2973719 , @mnadeem >> wrote: >> >>> In D108881

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem added a comment. In D108881#2973735 , @steven_wu wrote: > In D108881#2973719 , @mnadeem wrote: > >> In D108881#2973516 , @steven_wu >> wrote: >> >>> I will do a c

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `ninja clang` on Windows works. `check-llvm-tools` has a few `REQUIRES: system-windows` tests and I am running them. Test invocation is bit slow. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, sc

[PATCH] D109387: [NFC][AIX] Check for typedef properly when getting preferred type align

rjmccall added a comment. Oh, no, I don't think this is NFC. It seems very likely that there's some case where the behavior is distinguishable. Maybe a typedef of a record with an alignment attribute? __attribute__((aligned(2), packed)) struct float4 { float x, y, z, w; }; typedef struct

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987780 , @rjmccall wrote: > LGTM, except it's missing tests. Thanks. This is an NFC patch, the tests added in https://reviews.llvm.org/D107598 should still suffice IMHO. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. For the commit message, my name is Justin Latimer and my email is justinlati...@gmail.com. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 _

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer updated this revision to Diff 371176. justinlatimer added a comment. Update target-invalid-cpu-note.c test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 Files: clang/lib/Basic/Targets/A

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

jhuber6 added a comment. In D109321#2986678 , @peixin wrote: > $ clang++ -fopenmp simd.cpp -O1 -Xclang -disable-llvm-passes && ./a.out > 0 1 2 3 4 5 6 7 8 9 > $ clang++ -fopenmp simd.cpp -O2 && ./a.out > 0 1 2 3 4 5 6 7 8 9 > $ c

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

jdoerfert requested changes to this revision. jdoerfert added a comment. As noted before, this is not the right fix. Not inlining should not cause a semantic difference here, the problem is something else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, except it's missing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 ___

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir marked an inline comment as done. saghir added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE -

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371165. Jake-Egan added a comment. Fixed ExtDebugInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 Files: clang/test/CodeGenObjC/lit.local.cfg clang/test

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 371164. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan updated this revision to Diff 371163. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jhuber6 updated this revision to Diff 371162. jhuber6 added a comment. Fixing end assumes using wrong syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 Files: clang/lib/Headers/__clang_cuda_libdev

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos accepted this revision. grokos added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Ideally, we probably need something like isValidOffloadArch(Triple, OffloadArch) or getTargetTriple(OffloadArch). However, I think the current patch is good enough for its own purpose. Repos

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 _

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current check for typedef is naive and doesn't deal with any convoluted cases. This patch makes use of the new 'AlignRequirement' enum field from

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei created this revision. Herald added subscribers: hoy, wenlei, lxfind. wlei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109386 Files: clang/lib/CodeGen/CodeGenModul

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jhuber6 updated this revision to Diff 371153. jhuber6 added a comment. Adding `no_openmp` assumption as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 Files: clang/lib/Headers/__clang_cuda_libdev

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. This seems like the right direction to me! Especially like the look-through-the-ErrorInfo change for `FileError` -- I hit this before and found it annoying. IMO, it'd be valuable to split out the consequential functional changes: - Improvements/changes you made to F

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371137. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Added lit.local.cfg and unsupported z/OS as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.ll

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam updated this revision to Diff 371133. saiislam marked 2 inline comments as done. saiislam added a comment. 1. Added tests for empty and incompatible archives. 2. Improved identification of GPUArch in Bundle Entry ID using CudaArch. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1793-1795 +// This is not marked as a TargetSpecificAttr because that would trigger +// an 'attribute ignored' warning, but we want to check it explicitly and +// trigger an error.

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. In D109372#2987405 , @MaskRay wrote: > The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and > overlayfs, I am thinking whether this has anything to do with `OVERLAY` > description in a linker script: > http

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. > I'll commit this by the end of the day if @rsmith wasn't able to take a look. Sounds good, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 _

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

MaskRay added a comment. The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and overlayfs, I am thinking whether this has anything to do with `OVERLAY` description in a linker script: https://sourceware.org/binutils/docs/ld/Overlay-Description.html#Overlay-Description > whi

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. I don't see anything giving an error if you try and use the new badly-named option for an architecture other than RISC-V (beyond the usual unused argument warning that's only an error with -Werror)? Comment at: clang/include/clang/Basic/Attr.td:348 +//

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. In D102531#2987367 , @gulfem wrote: > Any update on this review? Our builds are still broken. I'll commit this by the end of the day if @rsmith wasn't able to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. Any update on this review? Our builds are still broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones created this revision. Herald added subscribers: vkmr, frasercrmck, dexonsmith, dang, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, simoncook, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits ma

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

Kai accepted this revision. Kai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the documentation update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 371106. anirudhp added a comment. - Condensed the lit test a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files: clang/lib/Basic/Targets/SystemZ.h clang/

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2986297 , @thopre wrote: > Is there no way to split this patch further? It's going to be hard finding > someone who can review something so big. If there's no way to split it in > incremental changes, you could perha

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:188 if (const TypedefNameDecl *TND = dyn_cast(D)) { + if (shouldSkipTypedef(TND)) +return; kadircet wrote: > why do we

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 371103. dgoldman added a comment. Update comment + remove un-needed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added a comment. The driver part looks good to me. I will let Oli do the approval as he also looked at the codegen (and I didn't). Comment at: clang/include/clang/Driver/Options.td:3274 + Group, + HelpText<"Work around VLLDM erratum CVE-2021-35465 (Arm only)">;

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

jdoerfert added a comment. In D109175#2986782 , @yaxunl wrote: > I agree with Johannes and Alexey that deferred diags are only needed when > LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only > needed in device compilation. > >

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `.rgba` vector extension setting in C++ for OpenCL 2021 is now performe

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a226529e2cf: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields (authored by NeHuang). Repository: rG LLVM Github Monorepo

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL 2021 version macros

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Version macro definitions are tested for C++ for OpenCL 2021. Reposit

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 371083. labrinea added a comment. Changes in this revision: - renamed fix_cve_2021_35465 to Fix_CVE_2021_35465 - added more Driver tests to cover the use of -mfix-cmse-cve-2021-35465 with -mno-fix-cmse-cve-2021-35465 - fixed code indentation CHANGES SINCE

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 371078. daltenty added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error( +"picking up libstdc++ headers is unimplemented on AIX"); ZarkoCA wrote: > nit: it would be my prefere

[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e71839f7793: [MC] Add MCSubtargetInfo to MCAlignFragment (authored by psmith). Herald added a project: clang. Herald added a subscriber: cfe-commits

[clang] 5e71839 - [MC] Add MCSubtargetInfo to MCAlignFragment

Author: Peter Smith Date: 2021-09-07T15:46:19+01:00 New Revision: 5e71839f7793b3ab94e928654a493cb3d7216176 URL: https://github.com/llvm/llvm-project/commit/5e71839f7793b3ab94e928654a493cb3d7216176 DIFF: https://github.com/llvm/llvm-project/commit/5e71839f7793b3ab94e928654a493cb3d7216176.diff L

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:82 + +// CHECK-MESSAGES: Suppressed 12 warnings (12 NOLINT) I'd like to see some additional test coverage that shows improper use and what happe

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

aaron.ballman added a comment. Some minor drive-by nits, but this looks sensible to me. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimens

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. SystemZ specific parts LGTM, but it would be good to have someone else review the common code / IR changes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 _

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

yaxunl added a comment. I agree with Johannes and Alexey that deferred diags are only needed when LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only needed in device compilation. For other offloading languages like CUDA/HIP it is needed in both device and host compila

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

nemanjai added a comment. It is not clear what this patch will do with `vector [[un]signed] long`. This is currently deprecated but still works - and we don't want it to work with no VSX. Comment at: clang/lib/Headers/altivec.h:8881 } #endif This file is

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:148 +// Check if the last option before any colon is a triple field or a GPU name +if (TripleOrGPU.second.startswith("gfx") || +TripleOrGPU.second.startswith("sm_"

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp created this revision. Herald added subscribers: dexonsmith, jdoerfert, hiraditya. anirudhp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - This patch adds in the GOFF mangling support to the LLVM data layout st

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4747-4748 +The ``suppress`` attribute can be applied to variable declarations and statements +to suppess warnings from the Clang Static Analyzer. The analyzer will not report +any issues on t

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 ___

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4 +// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \ +// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s +// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

kadircet added a comment. FYI, I've also requested cherry-pick into 13 release in https://bugs.llvm.org/show_bug.cgi?id=51779. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109361/new/ https://reviews.llvm.org/D109361

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

hans added a comment. Thanks! I tried this locally and it fixes the issue I mentioned on D109361 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109361/new/ https://reviews.llvm.org/D109361 ___

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73c00d40bd49: [clang][Driver] Pick the last --driver-mode in case

[clang] 73c00d4 - [clang][Driver] Pick the last --driver-mode in case of multiple ones

Author: Kadir Cetinkaya Date: 2021-09-07T15:33:45+02:00 New Revision: 73c00d40bd49ae022f6fbba7200f05facb533e3b URL: https://github.com/llvm/llvm-project/commit/73c00d40bd49ae022f6fbba7200f05facb533e3b DIFF: https://github.com/llvm/llvm-project/commit/73c00d40bd49ae022f6fbba7200f05facb533e3b.dif

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. $ clang++ -fopenmp simd.cpp -O1 -Xclang -disable-llvm-passes && ./a.out 0 1 2 3 4 5 6 7 8 9 $ clang++ -fopenmp simd.cpp -O2 && ./a.out 0 1 2 3 4 5 6 7 8 9 $ clang++ -fopenmp simd.cpp -O3 && ./a.out 0 1 2 3 4 5 6 7 8 9 This bug is not in

  1   2   >