rjmccall added a comment.

I agree with Reid.  IRGen should never be holding naked references (across 
different invocations as an `ASTConsumer`) to a replaceable entity.  There are 
some entities that are known not to be replaceable, but in general the 
associated data of a global constructor doesn't seem like one of them.  We 
should be using a value handle for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109386/new/

https://reviews.llvm.org/D109386

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to