leonardchan added inline comments.
================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123
set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "")
+ set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "")
+ set(RUNTIMES_${target}_COMPILER_RT_CAN_EXECUTE_TESTS ON CACHE BOOL "")
----------------
phosek wrote:
> leonardchan wrote:
> > phosek wrote:
> > > This shouldn't be needed.
> > So while we do build builtins, this is actually needed to run builtins
> > tests:
> > https://github.com/llvm/llvm-project/blob/ad7e12226f6b1ebf91511899016cdfb29aa8919e/compiler-rt/test/CMakeLists.txt#L59
> We are already build builtins in a separate build so I think we should be
> running the tests there rather than building the twice.
Ah, I didn't know that. Removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109199/new/
https://reviews.llvm.org/D109199
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
