Quuxplusone added inline comments.

================
Comment at: libcxxabi/src/cxa_exception_storage.cpp:102
 }
 }
+} // namespace __cxxabiv1
----------------
LGTM, FWIW.

It's surprising that clang-format adds `} // namespace foo` closing comments, 
but doesn't add `} // extern "C"` closing comments: this lonely brace is a bit 
confusing and I think it //would// benefit from an `// extern "C"` comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109408/new/

https://reviews.llvm.org/D109408

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to