[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 367407. TaoPan added a comment. Fix Windows gnu section name and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/clang/Driver/Options.td

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Thanks -- this patch is looking great so far! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:314 // (these tend to be vague, like Type or Unknown) +// - Resolved tokens (i.e. without the "dependent-name" modifier) with kind +// "Unkno

[clang] f5d5f17 - Revert "[HIP] Allow target addr space in target builtins"

Author: Anshil Gandhi Date: 2021-08-18T21:38:42-06:00 New Revision: f5d5f17d3ad455de2fbb9448acea66cbc09561c5 URL: https://github.com/llvm/llvm-project/commit/f5d5f17d3ad455de2fbb9448acea66cbc09561c5 DIFF: https://github.com/llvm/llvm-project/commit/f5d5f17d3ad455de2fbb9448acea66cbc09561c5.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1920 + setOperationAction(ISD::STRICT_FTRUNC, VT, Legal); + setOperationAction(ISD::FRINT, VT, Legal); + setOperationAction(ISD::STRICT_FRINT, VT, Legal); -

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 added a comment. Sure, please do that. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6012 +auto *CD = dyn_cast(MD); +if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) { + S.InstantiateDefaultCtorDefaultArgs(CD); rnk

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fdaaf7fd8f3: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader (authored by xur). Herald added a project: clang. Herald added a subscrib

[clang] 5fdaaf7 - [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

Author: Rong Xu Date: 2021-08-18T18:37:35-07:00 New Revision: 5fdaaf7fd8f35ac9c9de50a45b09e29c7b0d48c4 URL: https://github.com/llvm/llvm-project/commit/5fdaaf7fd8f35ac9c9de50a45b09e29c7b0d48c4 DIFF: https://github.com/llvm/llvm-project/commit/5fdaaf7fd8f35ac9c9de50a45b09e29c7b0d48c4.diff LOG:

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd7bad9ad9b: [openmp] Annotate tmp variables with omp_thread_mem_alloc (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGE

[clang] dbd7bad - [openmp] Annotate tmp variables with omp_thread_mem_alloc

Author: Jon Chesterfield Date: 2021-08-19T02:22:11+01:00 New Revision: dbd7bad9ad9bc32538e324417c23387bf4ac7747 URL: https://github.com/llvm/llvm-project/commit/dbd7bad9ad9bc32538e324417c23387bf4ac7747 DIFF: https://github.com/llvm/llvm-project/commit/dbd7bad9ad9bc32538e324417c23387bf4ac7747.di

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield updated this revision to Diff 367374. JonChesterfield added a comment. - add minimal omp.h to clang test inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107971/new/ https://reviews.llvm.org/D107971 Files: clang/lib/Headers/_

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:307 + if (StringRef(D.Dir).startswith(SysRoot)) { addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); MaskRay wrote: > Is `D

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. In D108286#2952511 , @MaskRay wrote: > Please provide more information: the platform name and the output of `g++ > empty.cc '-###' |& sed -E 's/ "?-[LiIr]/\n&/g'` > > Note that there is a FIXME. It's unclear why your platform need

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. Raised https://lists.llvm.org/pipermail/llvm-dev/2021-August/152210.html ("Top-level .clang-tidy options and VariableName suggestion on CodingStandards") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://re

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. intended content for the new omp.h is #ifndef __OMP_H #define __OMP_H #if _OPENMP // Follows the pattern in interface.h // Clang sema checks this type carefully, needs to closely match that from omp.h typedef enum omp_allocator_handle_t { omp_n

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

dblaikie added a comment. The current state of the root `.clang-tidy` accurately reflects the LLVM Coding Conventions as documented, which applies to LLVM and its subprojects (some subprojects have diverged from this standard). The place for a discussion to change the naming convention is not h

[PATCH] D108339: [openmp][nfc] Replace OMPGridValues array with struct

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, dpalermo, gregrodgers, ronlieb, tianshilei1992, grokos. Herald added subscribers: kerbowa, guansong, tpr, yaxunl, nhaehnle, jvesely, jholewinski. JonChesterfield requested review of this revision. Herald added subs

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

owenpan added a comment. In D108094#2951973 , @MyDeveloperDay wrote: > @owenpan Can we push all these commits to 13 RC2 via > https://bugs.llvm.org/show_bug.cgi?id=51470 > > We need to mark the commits we want to cherry pick I think. Thanks! Updated 5

[PATCH] D108323: [asan] Added -inline-small-callbacks LLVM flag, which would force inline code for 8 and 16 byte data types when otherwise a callback would have been used.

kcc added a comment. What's the code size implications? Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:15 -int deref(int *p) { +long deref(long *p) { return *p; As we introduce a difference in behavior for small and large accesses, I would extend t

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

This revision was automatically updated to reflect the committed changes. Closed by commit rG643f2be7b6af: [clang-format] Improve detection of parameter declarations in K&R C (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108094

[clang] 643f2be - [clang-format] Improve detection of parameter declarations in K&R C

Author: owenca Date: 2021-08-18T15:21:48-07:00 New Revision: 643f2be7b6afd91d9f0d6df89cd3391835763112 URL: https://github.com/llvm/llvm-project/commit/643f2be7b6afd91d9f0d6df89cd3391835763112 DIFF: https://github.com/llvm/llvm-project/commit/643f2be7b6afd91d9f0d6df89cd3391835763112.diff LOG: [

[PATCH] D107323: [clang-tidy] Add skip-headers; use skipLocation and setTraversalScope

chh updated this revision to Diff 367331. chh added a comment. fix windows test failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107323/new/ https://reviews.llvm.org/D107323 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.h clang

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. In D108265#2953305 , @dblaikie wrote: > In D108265#2952555 , @MaskRay wrote: > >> The number of top-level projects using `VariableName` is smaller than the >> number of projects not using

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocationFilter

chh updated this revision to Diff 367330. chh added a comment. fix windows test failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-t

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin added a comment. @aaron.ballman Let me know what you think. The PR does not contain new behavior, only renames and refactor the function lexing identifiers. I ran the build a few times and did not measure performance differences on my system. The code should behave exactly the same exce

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

dblaikie added a comment. In D108265#2952555 , @MaskRay wrote: > The number of top-level projects using `VariableName` is smaller than the > number of projects not using the style. > The top-level variable style just provoked projects to either override

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367326. cor3ntin added a comment. Remove file committed accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clang-include-fixer/I

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367325. cor3ntin added a comment. Looks better in lower case after all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clang-include-fixer

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + Okay, so first off, the comment and variable names here make this s

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106721/new/ https://reviews.llvm.org/D106721 ___ cfe-c

[PATCH] D108021: [dllexport] Instantiate default ctor default args

rnk added a comment. Thanks for the patch and test. Can I commit this for you? Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6012 +auto *CD = dyn_cast(MD); +if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) { + S.InstantiateDefaultCtorDefaultA

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 367322. cor3ntin added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Spell ASCII in upper case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://revie

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e77cd095a6: gn build: Build libclang.so and libLTO.so on ELF platforms. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D108223?vs=366966&id=367318#toc Repository: rG LLVM Gith

Maintenance works at llvm lab today

Hello everyone, LLVM lab and buildmaster will be unavailable for about an hour starting 5 PM PST today for maintenance works. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367312. stevewan added a comment. Fields marked attribute "aligned" and "packed" don't need to go through alignment upgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D

[PATCH] D108317: [libomptarget][devicertl] Replace lanemask with uint64 at interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21d91a8ef319: [libomptarget][devicertl] Replace lanemask with uint64 at interface (authored by JonChesterfield). Repository: rG LLVM Github Monore

[clang] 21d91a8 - [libomptarget][devicertl] Replace lanemask with uint64 at interface

Author: Jon Chesterfield Date: 2021-08-18T20:47:33+01:00 New Revision: 21d91a8ef319eec9c2c272e19beee726429524aa URL: https://github.com/llvm/llvm-project/commit/21d91a8ef319eec9c2c272e19beee726429524aa DIFF: https://github.com/llvm/llvm-project/commit/21d91a8ef319eec9c2c272e19beee726429524aa.di

[PATCH] D108317: [libomptarget][devicertl] Replace lanemask with uint64 at interface

JonChesterfield added a comment. Yep, and optionally in the old one as well. The 32/64 conversion all shakes out OK in the end. Restricting the patch to the interface and immediate consequences makes it easier to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D108323: [asan] Added -inline-small-callbacks LLVM flag, which would force inline code for 8 and 16 byte data types when otherwise a callback would have been used.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added a subscriber: hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The reason to inline the 8 and 16 byte access chec

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ abandoned this revision. NoQ added a comment. Abandon in favor of splitting up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mailing list c

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ reopened this revision. NoQ added a comment. Herald added a subscriber: manas. This patch hasn't landed yet (reverted every time due to circular dependencies(?)). I plan to split it up into smaller patches as I rebase because rebase is already very painful. Repository: rG LLVM Github Mon

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. See https://github.com/clangd/clangd/issues/839 Repository:

[PATCH] D108317: [libomptarget][devicertl] Replace lanemask with uint64 at interface

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. We could replace `LaneMaskTy` in the new dev rtl but that is not necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108317/new/

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 marked an inline comment as done. gandhi21299 added a comment. Thanks for the review, I will merge this in as soon as the CI passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 ___

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 367273. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - code refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 Files: clang/

[PATCH] D108317: [libomptarget][devicertl] Replace lanemask with uint64 at interface

JonChesterfield updated this revision to Diff 367295. JonChesterfield added a comment. - void Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108317/new/ https://reviews.llvm.org/D108317 Files: clang/test/OpenMP/nvptx_parallel_codegen.cpp llvm/i

[PATCH] D108317: [libomptarget][devicertl] Replace lanemask with uint64 at interface

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, dpalermo, grokos, tianshilei1992. Herald added subscribers: hiraditya, tpr. JonChesterfield requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald add

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

tra added a comment. In D108235#2952714 , @Hahnfeld wrote: > (might be good to have an entry in the release notes?) I've updated release notes in D108248 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra updated this revision to Diff 367282. tra added a comment. Updated release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Cuda.

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

tra added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:48-49 PTXVersion = llvm::StringSwitch(Feature) + .Case("+ptx72", 74) + .Case("+ptx71", 73) .Case("+ptx72", 72) Hahnfeld wro

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

tra updated this revision to Diff 367267. tra added a comment. Fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108239/new/ https://reviews.llvm.org/D108239 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/

[PATCH] D105007: [NewPM] Make some sanitizer passes parameterized in the PassRegistry

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105007/new/ https://reviews.llvm.org/D105007 ___

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG2afb9394a745: [hwasan] Flag stack safety check as requiring aarch64 (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/ https:

[clang] 2afb939 - [hwasan] Flag stack safety check as requiring aarch64

Author: Christopher Tetreault Date: 2021-08-18T11:14:01-07:00 New Revision: 2afb9394a745733739f217d53cd9cf4ae03a3157 URL: https://github.com/llvm/llvm-project/commit/2afb9394a745733739f217d53cd9cf4ae03a3157 DIFF: https://github.com/llvm/llvm-project/commit/2afb9394a745733739f217d53cd9cf4ae03a31

[PATCH] D105007: [NewPM] Update some sanitizer pass names in the PassRegistry

bjope updated this revision to Diff 367263. bjope added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Updated to use _PASS_WITH_PARAMS and option parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10500

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 +std::string VersionString = CudaVersionToString(Version); +if (!VersionString.empty()) + VersionString += " "; +D.Diag(diag::warn_drv_new_cuda_version) Hahnfeld

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367261. tra added a comment. Prepend space to the version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files: clang/include/clang/Basic/Cuda.h clang/includ

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra updated this revision to Diff 367260. tra added a comment. Undo unintentional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248 Files: clang/include/clang/Basic/Cuda.h Index: clang/include/c

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra updated this revision to Diff 367259. tra edited the summary of this revision. tra added a comment. Prepend space to version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248 Files: clang/incl

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

samitolvanen added a comment. FYI, this breaks the Linux kernel when built with ThinLTO: https://github.com/ClangBuiltLinux/linux/issues/1440 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 _

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

Hahnfeld added a comment. I didn't follow the recent CUDA support in Clang very closely, but this makes sense to me. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:48-49 PTXVersion = llvm::StringSwitch(Feature) + .Case("+ptx72", 74) +

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

Hahnfeld added a comment. (might be good to have an entry in the release notes?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/ https://reviews.llvm.org/D108235 ___ cfe-commits mailing list cf

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 +std::string VersionString = CudaVersionToString(Version); +if (!VersionString.empty()) +

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12194 - return (fpModeMatchesGlobalFPAtomicMode(RMW) || - RMW->getFunction() - ->getFnAttribute("amdgpu-unsafe-fp-atomics") - .getVa

[PATCH] D108308: Cleanup identifier parsing.

cor3ntin created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a reviewer: aaron.ballman. cor3ntin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. - Rename methods to clea

[Job Ad] Intel is hiring Frontend Compiler Engineers

Intel is looking for Frontend Compiler Engineers to be a part of the Intel compiler engineering organization on the frontend team. Join our growing team, helping to develop new features and maintain existing functionality in Clang. We are currently hiring folks for entry-level and experienced posit

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. I know it seems redundant to pass the constants with every function call, but otherwise the code generation code will have to take dependency on AddressSanitizerCommon.h, which I am not sure is ideal. I spent some time looking into it and becomes quite messy. For exa

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:75 -// UNKNOWN_VERSION_V: unknown CUDA version: version.txt:{{.*}}; assuming the latest supported version -// UNKNOWN_VERSION_H: unknown CUDA version: cuda.h: CUDA_VERSION={{.*}}; assuming the late

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367246. tra edited the summary of this revision. tra added a comment. Do not report the version if we don't know it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files

Phabricator Creator Pulling the Plug

All I'm a massive fan of Phabricator, and I know there is often lots of contentious discussion about its relative merits vs github, But unless I missed this, was there any discussion regarding the recent "Winding Down" announcement of Phabricator? and what it might mean for us in LLVM See: https

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur added a comment. Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157 + + Value *EntryBBTI = EntryBB->getTerminator(); + EXPECT_EQ(EntryBBTI, nullptr); +

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. The number of top-level projects using `VariableName` is smaller than the number of projects not using the style. The top-level variable style just provoked projects to either override the options (flang/, lld/, mlir/) or disable the check. `VariableName` is not even a s

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1920 + setOperationAction(ISD::STRICT_FTRUNC, VT, Legal); + setOperationAction(ISD::FRINT, VT, Legal); + setOperationAction(ISD::STRICT_FRINT, VT, Legal)

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

fmayer accepted this revision. fmayer added a comment. This revision is now accepted and ready to land. Thanks LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/ https://reviews.llvm.org/D108241

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:307 + if (StringRef(D.Dir).startswith(SysRoot)) { addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); Is `D.Dir + "/../lib"

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 367232. frasercrmck added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. update usage in vein of AArch64: - use vscale_range attribute to determine RVV vector bits min/max values - if no attribute is present, u

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay added a comment. Please provide more information: the platform name and the output of `g++ empty.cc '-###' |& sed -E 's/ "?-[LiIr]/\n&/g'` Note that there is a FIXME. It's unclear why your platform needs the specific rule. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ffbe8c04ff2: [clang-offload-wrapper] Disabled ELF offload notes embedding by default. (authored by vzakhari). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 1ffbe8c - [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

Author: Vyacheslav Zakharin Date: 2021-08-18T08:18:03-07:00 New Revision: 1ffbe8c04ff269ca9847c37036fbad943820d6ae URL: https://github.com/llvm/llvm-project/commit/1ffbe8c04ff269ca9847c37036fbad943820d6ae DIFF: https://github.com/llvm/llvm-project/commit/1ffbe8c04ff269ca9847c37036fbad943820d6ae

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. In D108303#2952393 , @JonChesterfield wrote: > I like D108246 more. None of the > offloading tests updated in D108246 failed > with the above patch, perhaps

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. ping. @rsmith could you help take a look at the patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 ___ cfe-commits ma

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

JonChesterfield abandoned this revision. JonChesterfield added a comment. I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by `make check-openmp` Repos

[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

jdoerfert added inline comments. Comment at: llvm/lib/OffloadArch/OffloadArch.cpp:280 + return results; +} the _aot_ names are not great. Comment at: llvm/lib/OffloadArch/amdgpu/hsa-subset.h:40 +// DEALINGS WITH THE SOFTWARE. +// +

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

JonChesterfield added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:79 +static cl::opt AddOpenMPOffloadNotes( +"add-omp-offload-notes", I'd have probably gone with an explicit false here but it doesn't make much dif

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. Hi Jon, I am about to merge D108246 that disables the notes embedding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108303/new/ https://reviews.llvm.org/D108303 ___

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

JonChesterfield accepted this revision. JonChesterfield added a comment. Amusingly similar to D108303 . LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108246 ___ cfe

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. It's a hack, but D108303 will unblock nvptx offloading. Alternative to reverting. Suggest we go with that then revisit in a couple of weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2952336 , @JonChesterfield wrote: > Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools > does some overly aggressive input validation that we're running afoul of. > > There was a discussion about

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

JonChesterfield created this revision. JonChesterfield added reviewers: vzakhari, ABataev, grokos, sdmitriev, jdoerfert, ronlieb. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools does some overly aggressive input validation that we're running afoul of. There was a discussion about this on the call today - plan was to put it behind a disabled boolean argument while

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

yaxunl added a comment. The change about amdgpu LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

JonChesterfield added a comment. Discussed at the multicompany meeting today. Consensus reached is that the whole-archive/no-whole-archive distinction is unimportant - we can ship a toolchain that has whole-archive semantics and later change the default when doing more work in the linker. It's

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang created this revision. NeHuang added reviewers: stefanp, nemanjai, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds a fix to do early if conversion to select when conditional branch no

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. As discussed, LG, we will look into the NVIDIA GPU problem now to get rid of this again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl created this revision. jozefl added a reviewer: asl. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates MSP430 MCU data to the latest version distributed by TI, adding support for 451 additional MCUs. The hard

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl created this revision. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -mmcu= option accepts a generic MCU named "msp430", which sets the CPU to msp430 and disables hardware multiply support. The current purpose of accept

[PATCH] D108111: [CodeComplete] Only complete attributes that match the current LangOpts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108111/new/ https://reviews.llvm.org/D108111

[PATCH] D108109: [CodeCompletion] Provide placeholders for known attribute arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108109/new/ https://reviews.llvm.org/D108109

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added a comment. this is the working steps in the linking script. clang-offload-bundler (host,device) in: complex_reduction.cpp.o out: complex_reduction-494ba8.o, complex_reduction-5aba63.cubin nvlink (device) in: complex_reduction-5aba63.cubin out: complex_reduction-b1898c.

  1   2   >