[PATCH] D108021: [dllexport] Instantiate default ctor default args

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

Thanks for the patch and test. Can I commit this for you?



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6012
+        auto *CD = dyn_cast<CXXConstructorDecl>(MD);
+        if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) {
+          S.InstantiateDefaultCtorDefaultArgs(CD);
----------------
This should probably happen when explicit instantiation definitions are 
exported, so the `TSK_ExplicitInstantiationDefinition` case. However, I don't 
consider it a blocking issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108021/new/

https://reviews.llvm.org/D108021

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits