Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land.
Otherwise LGTM ================ Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 + std::string VersionString = CudaVersionToString(Version); + if (!VersionString.empty()) + VersionString += " "; + D.Diag(diag::warn_drv_new_cuda_version) ---------------- I think you have to prepend the space in order to match `CUDA version%0 is newer than`, or move the `%0`. But I didn't try locally, might be missing something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits