[PATCH] D102313: [docs] Fix documentation for bugprone-dangling-handle

malcolm.parsons created this revision. malcolm.parsons added a reviewer: aaron.ballman. malcolm.parsons requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. string_view isn't experimental anymore. This check has always handled both f

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfebbe4b5a0ab: [PowerPC] [Clang] Enable float128 feature on VSX targets (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D928

[clang] febbe4b - [PowerPC] [Clang] Enable float128 feature on VSX targets

Author: Qiu Chaofan Date: 2021-05-12T14:33:41+08:00 New Revision: febbe4b5a0ab0cb6f8ada6cd1ead4bb1f565bda8 URL: https://github.com/llvm/llvm-project/commit/febbe4b5a0ab0cb6f8ada6cd1ead4bb1f565bda8 DIFF: https://github.com/llvm/llvm-project/commit/febbe4b5a0ab0cb6f8ada6cd1ead4bb1f565bda8.diff L

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

xiangzhangllvm added inline comments. Comment at: compiler-rt/test/hwasan/TestCases/Linux/vfork.c:7 -// Aliasing mode does not support stack tagging. -// XFAIL: x86_64 What does here XFAIL mean, do not test in x86_64 ? Repository: rG LLVM Github Monorepo C

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344666. smeenai added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake clang/cm

[PATCH] D102306: Add gfx1034

aakanksha555 created this revision. aakanksha555 added reviewers: msearles, kzhuravl, rampitec. Herald added subscribers: dexonsmith, kerbowa, rupprecht, hiraditya, nhaehnle, jvesely, arsenm, jholewinski. Herald added a reviewer: jhenderson. aakanksha555 requested review of this revision. Herald a

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 344646. NoQ added a comment. Address comments. Yay, diff is no longer confused! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatcher

[PATCH] D102303: [ASTMatchers] Fix formatting around forFunction().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, xazax.hun, vsavchenko. Herald added subscribers: martong, rnkovacs. NoQ requested review of this revision. Isolated from D102213 . No functional change intended. Repository: rC

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. In D102213#2750050 , @steveire wrote: > I'm not certain what strong opinions I've voiced on the mailing list about > that. Was it just that I think `hasDescendant` can lead to unexpected matches > and a more-specific matcher should

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101968/new/ https://reviews.llvm.org/D101968 ___

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl updated this revision to Diff 344629. yaxunl edited the summary of this revision. yaxunl added a comment. fix lint warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102270/new/ https://reviews.llvm.org/D102270 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/AST

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rsmith reopened this revision. rsmith added a comment. (Reopening, earlier commit was accidental.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101968/new/ https://reviews.llvm.org/D101968 ___ cfe-commi

[clang] bb72638 - Revert "Fix bad mangling of for a closure in the initializer of a variable at global namespace scope."

Author: Richard Smith Date: 2021-05-11T17:46:18-07:00 New Revision: bb726383ac7554857c62edd2d19e83dc713165ee URL: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee DIFF: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee.diff

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ updated this revision to Diff 344616. NoQ added a comment. Fix typo in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102294/new/ https://reviews.llvm.org/D102294 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test/clang-tidy/checkers

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. I was originally skeptical of this change, because of some negative feedback about these flags in the past on the Fedora development list. However, the people I've talked to more recently seem to be in favor of this change, so no objection from me. Repository: rG

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, xazax.hun, vsavchenko. Herald added subscribers: martong, mgehre, rnkovacs. NoQ requested review of this revision. Herald added a project: clang-tools-extra. If the loop condition is a value of an instance variable,

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG697ac15a0fc7: Fix bad mangling of for a closu

[clang] 3978333 - Add test for PR50039.

Author: Richard Smith Date: 2021-05-11T17:35:34-07:00 New Revision: 3978333b71bff3516ad69aac484b808617976c7a URL: https://github.com/llvm/llvm-project/commit/3978333b71bff3516ad69aac484b808617976c7a DIFF: https://github.com/llvm/llvm-project/commit/3978333b71bff3516ad69aac484b808617976c7a.diff

[clang] 697ac15 - Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

Author: Richard Smith Date: 2021-05-11T17:35:33-07:00 New Revision: 697ac15a0fc71888c372667bdbc5583ab42d4695 URL: https://github.com/llvm/llvm-project/commit/697ac15a0fc71888c372667bdbc5583ab42d4695 DIFF: https://github.com/llvm/llvm-project/commit/697ac15a0fc71888c372667bdbc5583ab42d4695.diff

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen updated this revision to Diff 344609. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102147/new/ https://reviews.llvm.org/D102147 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/Bu

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2747142 , @ChuanqiXu wrote: >> which should be correct. It is implemented by >> CodeGenFunction::EmitBuiltinAlignTo. > > I agree it is correct. I just want to say we should comment it to avoid > confusing. Happy to do it

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl updated this revision to Diff 344605. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102270/new/ https://reviews.llvm.org/D102270 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/C

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

rsmith added a comment. (No blocking concerns here.) Comment at: clang/lib/AST/Stmt.cpp:1000-1003 + if (Optional Result = + const_cast(this)->getNondiscardedCase(Ctx)) +return *Result; + return None; Can this simply be ``` return const_cast(thi

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl added a comment. In D102270#2751852 , @tra wrote: > LGTM in general. > Perhaps it would make sense to combine this patch with D102237 > as both patches are changing the same code > for the same reason, just for

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 344602. ychen added a comment. - Rebase on updated D102145 (use `llvm.coro.raw.frame.ptr.addr` during allocation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc, diag::err_ref_bad_target) - << /*host*/ 2

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse created this revision. morehouse added reviewers: vitalybuka, eugenis. Herald added subscribers: dexonsmith, mgorny. morehouse requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. -fsanitize=lam is intended to be

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +.addImm(Options.StackProtectorGuardOffset >> 3); + else dmgreen wrote: > nickdesaulniers wrote: > > dmgreen wrote: > >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > aaron.ballman wrote: > > >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wrote: > > >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > dblaikie wrote: > > > > aaron.ballman wro

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

akyrtzi added a comment. To clarify, I was suggesting that //in addition// to removing the space from unhandled types, we also handle the member function pointer type and not leave it in this fallback case. Types should have unique USR characters so that overloaded functions (overloaded on the

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > aaron.ballman wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wro

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG5cb17728d194: [clang][Fuchsia] Introduce compat multilibs (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D102030?vs=343526&id=

[clang] 5cb1772 - [clang][Fuchsia] Introduce compat multilibs

Author: Leonard Chan Date: 2021-05-11T15:45:38-07:00 New Revision: 5cb17728d19408725d4ced928ff3276dd4ffd1c9 URL: https://github.com/llvm/llvm-project/commit/5cb17728d19408725d4ced928ff3276dd4ffd1c9 DIFF: https://github.com/llvm/llvm-project/commit/5cb17728d19408725d4ced928ff3276dd4ffd1c9.diff

[clang] 46475a7 - [AIX][TLS] Diagnose use of unimplemented TLS models

Author: Victor Huang Date: 2021-05-11T17:21:08-05:00 New Revision: 46475a79f85b230fde3e7de8966c96bef14f0d24 URL: https://github.com/llvm/llvm-project/commit/46475a79f85b230fde3e7de8966c96bef14f0d24 DIFF: https://github.com/llvm/llvm-project/commit/46475a79f85b230fde3e7de8966c96bef14f0d24.diff

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46475a79f85b: [AIX][TLS] Diagnose use of unimplemented TLS models (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

LLVM build master will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100919: [AArch64] Support customizing stack protector guard

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +.addImm(Options.StackProtectorGuardOffset >> 3); + else nickdesaulniers wrote: > dmgreen wrote: > > What is StackProtectorGuar

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

steakhal added a comment. In D99260#2704102 , @NoQ wrote: > In https://bugs.llvm.org/show_bug.cgi?id=45786 the godbolt link shows that > there are still problems with `addressof` (yes, their "trunk" clang is fresh > enough). They seem to have `__addresso

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102251/new/ https://reviews.llvm.org/D102251 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

steakhal added reviewers: NoQ, vsavchenko, steakhal. steakhal added a comment. I'm gonna have a look at this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 _

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + pzheng wrote: > MaskRay wrote: > > CC1 needs two options? > > >

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. In D100919#2750125 , @dmgreen wrote: > It's worth adding -verify-machineinstrs to the tests, to check the code > passes the internal checks. Done. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 344549. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder USE/DEF, add -verify-machineinstrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D102270: [CUDA][HIP] Fix device template variables

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Perhaps it would make sense to combine this patch with D102237 as both patches are changing the same code for the same reason, just for slightly d

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 344538. jhuber6 added a comment. Fixing tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 Files: clang/include/clang/Basic/LangOptions.def clang/include/

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751832 , @tschuett wrote: > The Ver in Ver2020 is redundant ::2020 would suffice. That is not valid syntax. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. The Ver in Ver2020 is redundant ::2020 would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. In D102261#2751819 , @tschuett wrote: > But there is no SYCLMinorVersion today. So enum class SYCLVersion would > suffice. I don't think the presence of the word 'Major' in Aaron's suggestion is the most offensive to me. Wh

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:407 - MOFI->initMCObjectFileInfo(Ctx, PIC); + // FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and + // MCObjectFileInfo needs a MCContext reference in order to initialize itse

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. But there is no SYCLMinorVersion today. So enum class SYCLVersion would suffice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added inline comments. Comment at: llvm/include/llvm/MC/MCObjectFileInfo.h:255 + virtual unsigned getTextSectionAlignment() const { return 4; } MCSection *getTextSection() const { return TextSection; } This should be moved to D102052 =

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2751782 , @tschuett wrote: > No worries. I just wondered why only ClangABI is scoped ^^ :-) FWIW, I think it's because `LangOptions::Ver1` would be hard to understand compared to `LangOptions::ClangABI::Ver1`,

[PATCH] D102261: Introduce SYCL 2020 mode

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, aaron.ballman wrote: > tschuett wrote: > > Do you want to change it to a scoped enum or will this cause major issues? > > Clan

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added a comment. No worries. I just wondered why only ClangABI is scoped ^^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a comment. I'll push this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently clang does not emit device template variables instantiated only in host functions, however, nvcc is able to do that: https://godbolt.org/z/fneEfferY This patch fixes this issue by refa

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

arsenm added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247 +and is an optimization hint. It is mandatory to use this attribute in some +situations. Because when the attribute is absent, the compiler assumes the +default maximum workgroup size of 2

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, tschuett wrote: > Do you want to change it to a scoped enum or will this cause major issues? > ClangABI is a scoped enum?!?

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

aaron.ballman added a comment. In D102134#2751184 , @pooja2299 wrote: > In D102134#2747649 , @aaron.ballman > wrote: > >> Minor wordsmithing on the documentation changes, but more importantly: why >> is the corr

[PATCH] D102261: Introduce SYCL 2020 mode

tschuett added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:130 enum SYCLMajorVersion { SYCL_None, Do you want to change it to a scoped enum or will this cause major issues? ClangABI is a scoped enum?!? CHANGES SINCE LAST ACT

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2075f2b296b0: [clang] Support -fpic -fno-semantic-interposition for RISCV (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 2075f2b - [clang] Support -fpic -fno-semantic-interposition for RISCV

Author: Fangrui Song Date: 2021-05-11T11:38:32-07:00 New Revision: 2075f2b296b0fa90cb7597f0f318232940d29e95 URL: https://github.com/llvm/llvm-project/commit/2075f2b296b0fa90cb7597f0f318232940d29e95 DIFF: https://github.com/llvm/llvm-project/commit/2075f2b296b0fa90cb7597f0f318232940d29e95.diff

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

ychen added inline comments. Comment at: clang/test/Misc/inline-asm-clobber-warning.c:26 +// CHECK-NEXT: nop +// CHECK-NEXT: ^ DavidSpickett wrote: > I think this `^` is wrong because we don't/can't account for the asm printer > tabbing in the instructio

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman updated this revision to Diff 344496. aaron.ballman added a comment. Remove some accidental additional changes for SYCL 2017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 Files: clang/include/clang/Basic/LangOptions.def cl

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:481 Builder.defineMacro("CL_SYCL_LANGUAGE_VERSION", "121"); + Builder.defineMacro("SYCL_LANGUAGE_VERSION", "201707"); +} else if (LangOpts.getSYCLVersion() == LangOptions::SYC

[PATCH] D102261: Introduce SYCL 2020 mode

erichkeane added a comment. LGTM, but want others to look first. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:481 Builder.defineMacro("CL_SYCL_LANGUAGE_VERSION", "121"); + Builder.defineMacro("SYCL_LANGUAGE_VERSION", "201707"); +} else if (LangOpts.getSYC

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman created this revision. aaron.ballman added reviewers: bader, erichkeane, jansvoboda11. Herald added subscribers: Naghasan, dexonsmith, dang, Anastasia, ebevhan, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, we have support for SYC

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); craig.topper wrote: > Did you intend to leave the old lines commented o

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex updated this revision to Diff 344486. SilensAngelusNex added a comment. `T->` => `Loc.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102185/new/ https://reviews.llvm.org/D102185 Files: clang/include/clang/Tooling/Transformer/Ra

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

craig.topper added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); Did you intend to leave the old lines commented out? Repository: rG LLVM Gith

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

tra accepted this revision. tra added a comment. LGTM for CUDA. This matches the intent of deferred diags -- we only emit them if we get to generate the code for the sources that triggered them, so they should not show up for the false constexpr branches. Repository: rG LLVM Github Monorepo

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few nits. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc, d

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https

[clang] 0fd0a01 - [git-clang-format] Do not apply clang-format to symlinks

Author: Pirama Arumuga Nainar Date: 2021-05-11T10:34:40-07:00 New Revision: 0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de URL: https://github.com/llvm/llvm-project/commit/0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de DIFF: https://github.com/llvm/llvm-project/commit/0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev added a comment. In D102251#2751226 , @erichkeane wrote: > In D102251#2751101 , @ABataev wrote: > >> LG > > Thanks! I'm going to give @yaxunl a day to take a look that this, > particularly since the onl

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added a comment. In D102251#2751101 , @ABataev wrote: > LG Thanks! I'm going to give @yaxunl a day to take a look that this, particularly since the only test I could come up with was CUDA based. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. xlc on z/OS will compile vector _Bool char bc; on any language level high enough to recognize _Bool as a valid keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 _

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751160 , @uweigand wrote: > In D102064#2751089 , @ZarkoCA wrote: > >> In D102064#2751001 , @uweigand >> wrote: >> >>> This means the

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 added a comment. In D102134#2747649 , @aaron.ballman wrote: > Minor wordsmithing on the documentation changes, but more importantly: why is > the correct fix to the documentation as opposed to changing the default max > working group size? H

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. In D102064#2751089 , @ZarkoCA wrote: > In D102064#2751001 , @uweigand > wrote: > >> This means the implementation now deviates from the documented vector >> extension syntax, right? I

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + aaron.ballman wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > dblaikie wrote: > > > > hoy wro

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102251/new/ https://reviews.llvm.org/D102251 ___

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2082-2083 /// Otherwise, or if the condition is value-dependent, returns None. Optional getNondiscardedCase(const ASTContext &Ctx) const; + Optional getNondiscardedCase(const ASTContext &Ctx); -

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

MaskRay added a comment. Agreed. This feels like a workaround. Can the offending projects be fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86881/new/ https://reviews.llvm.org/D86881 ___ cfe-commit

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2750930 , @Everybody0523 wrote: > Minor nitpick, but is there a term that encompasses both the Z Vector syntax > and altivec? Since the test checks both Z and PPC it's a little odd that the > test's filename only ref

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2082-2083 /// Otherwise, or if the condition is value-dependent, returns None. Optional getNondiscardedCase(const ASTContext &Ctx) const; + Optional getNondiscardedCase(const ASTContext &Ctx);

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751001 , @uweigand wrote: > This means the implementation now deviates from the documented vector > extension syntax, right? I guess it's strictly an extension of the > documented syntax, but that may still lead to

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 34. ASDenysPetrov added a comment. Minor performance improvement. Add more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added a comment. In D101191#2751002 , @sanwou01 wrote: > Hi, we've got a ~6% regression in SPEC INT 2006 462.libquantum on AArch64 > (both -flto and -Ofast) that comes back to this change. See here for a > reproducer https://godbolt.org/z/dq98Gqqx

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane created this revision. erichkeane added reviewers: yaxunl, bader, ABataev, aaron.ballman. erichkeane requested review of this revision. Herald added a project: clang. It doesn't really make sense to emit language specific diagnostics in a discarded statement, and suppressing these diagn

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

sanwou01 added subscribers: dmgreen, sanwou01. sanwou01 added a comment. Hi, we've got a ~6% regression in SPEC INT 2006 462.libquantum on AArch64 (both -flto and -Ofast) that comes back to this change. See here for a reproducer https://godbolt.org/z/dq98Gqqxn (-fno-vectorize is not strictly nec

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. This means the implementation now deviates from the documented vector extension syntax, right? I guess it's strictly an extension of the documented syntax, but that may still lead to incompatibilities with other compilers for the platform. If we want to make such a

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

steakhal added a comment. Dam, we will be always haunted by these. Looks good btw. The test looks somewhat artificial - like a raw `creduce` result. Do you think It worth the effort to make it look like it was written by a human? I also somewhy prefer function parameters to globals for this speci

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @njames93: Could you do me a favor? Because it is my first patch, something I'm not sure. I'm confused about can I land this patch now? I read the "LLVM Code-Review Policy and Practices" document, it said patches can be landed if received a LGTM, but seems you are s

  1   2   >