dexonsmith added inline comments.
================
Comment at: clang/include/clang/Basic/LangOptions.h:130
enum SYCLMajorVersion {
SYCL_None,
----------------
aaron.ballman wrote:
> tschuett wrote:
> > Do you want to change it to a scoped enum or will this cause major issues?
> > ClangABI is a scoped enum?!?
> Given that it's already scoped to `LangOptions`, I think a scoped enum adds
> more noise than anything. It'd make it awkward to name the actual enumerators
> due to using dates. I think we'd wind up needing to write
> `LangOptions::SYCLMajorVersion::Ver2017` (or something along those lines),
> which doesn't seem like a huge win to me. WDYT?
FWIW, I agree that a scoped enum wouldn't improve things here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102261/new/
https://reviews.llvm.org/D102261
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
