ychen added a comment. In D97915#2747142 <https://reviews.llvm.org/D97915#2747142>, @ChuanqiXu wrote:
>> which should be correct. It is implemented by >> CodeGenFunction::EmitBuiltinAlignTo. > > I agree it is correct. I just want to say we should comment it to avoid > confusing. Happy to do it in a separate patch since this patch does not change the implementation of `CodeGenFunction::EmitBuiltinAlignTo`. > Since the patch could handle the case if the frontend tries to search > `::operator new(size_t, align_val_t)`, this patch should be based on D102147 > <https://reviews.llvm.org/D102147>. This patch *could* handle both aligned and normal new/delete, so it doesn't need D102147 <https://reviews.llvm.org/D102147> to work correctly? D102147 <https://reviews.llvm.org/D102147> depends on this patch since it may find a non-aligned new/delete for overaligned frame. In such a case, this patch is required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
