[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 337640. pdhaliwal added a comment. Rebase and review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: clang/include/clang/Basic/DiagnosticDriverKinds

RE: [clang] 5ad15f4 - Require commas between double square bracket attributes.

Hi Aaron, Your change is causing the compiler to go into an infinite loop in one of our internal tests. I have put details up in PR49966, can you please take a look? Douglas Yung -Original Message- From: cfe-commits On Behalf Of Aaron Ballman via cfe-commits Sent: Tuesday, April 13, 2

[PATCH] D100368: [X86] Support some missing intrinsics

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9611 +/// starting at location \a base_addr at packed 32-bit integer indices stored in +/// the lower half of \a vindex scaled by \a scale into dst using writemask +/// \a mask (elements are copied from

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatability

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:683 +// Provided builtins with _mma_ prefix for compatability. +CUSTOM_BUILTIN(mma_lxvp, "W256SLLiW256C*", false) --

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. Ok I think this is ready to land. There are a few FIXME comments, I will follow up with some small changes to address them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 __

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337597. haberman added a comment. - Fixed typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/include/clang/A

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

xbolva00 added a comment. Thanks, cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added subscribers: mgrang, mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the matchers gathering API for types to record template parameter

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2688771 , @Anastasia wrote: > In D97669#2687419 , @benshi001 wrote: > >> In D97669#2685698 , @Anastasia >> wrote: >> >>> In D97669#26784

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337592. haberman added a comment. - Fixed several cases in CodeGen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 updated this revision to Diff 337591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/include/.keep

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337590. haberman added a comment. - Fixed release note escaping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2689156 , @morehouse wrote: > At this point I am not convinced this patch will provide benefit for the > default use case when `-entropic=1`. I am hesitant to add complexity to the > code for unsure benefit. > > If y

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337589. haberman added a comment. - Added release note for [[clang::musttail]]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/docs/ReleaseNotes.rst

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5077 + verifyFormat("asm volatile(\"string\", : : val);", Style); + verifyFormat("asm volatile(\"string\", : val1 : val2);", Style); + You should add a test case with lo

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

HazardyKnusperkeks added a comment. Look good in general, only the few comments. Comment at: clang/unittests/Format/FormatTest.cpp:8892 FormatStyle Style = getLLVMStyle(); + FormatStyle NoEmptyLines = getLLVMStyle(); + NoEmptyLines.MaxEmptyLinesToKeep = 0;

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1ab590a052: [Sema] Fold VLA types in compound literals to constant arrays. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES

[clang] dc1ab59 - [Sema] Fold VLA types in compound literals to constant arrays.

Author: Eli Friedman Date: 2021-04-14T17:09:59-07:00 New Revision: dc1ab590a0527533815aeed0100de54a5f4a4829 URL: https://github.com/llvm/llvm-project/commit/dc1ab590a0527533815aeed0100de54a5f4a4829 DIFF: https://github.com/llvm/llvm-project/commit/dc1ab590a0527533815aeed0100de54a5f4a4829.diff

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper added a comment. In D99741#2690124 , @thakis wrote: > One of the ten commits that landed here > (https://github.com/llvm/llvm-project/compare/a3bfddbb6a27...59d5b8c27b43), > this being one of them, slowed down check-clang by over 20%: > htt

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337581. haberman added a comment. - More diagnostic wordsmithing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/AST/IgnoreExpr.h clang

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup; def warn_arm_interrupt_calling_convention : Warning< Please don't add warnings directly to `-Wextra`; t

[clang] dd98555 - Reapply "[InferAttributes] Materialize all infered attributes for declaration"" and follow on patches.

Author: Philip Reames Date: 2021-04-14T16:38:07-07:00 New Revision: dd985551c247752ee2be71f04a141225a40641ef URL: https://github.com/llvm/llvm-project/commit/dd985551c247752ee2be71f04a141225a40641ef DIFF: https://github.com/llvm/llvm-project/commit/dd985551c247752ee2be71f04a141225a40641ef.diff

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. One of the ten commits that landed here (https://github.com/llvm/llvm-project/compare/a3bfddbb6a27...59d5b8c27b43), this being one of them, slowed down check-clang by over 20%: https://bugs.llvm.org/show_bug.cgi?id=49962 Since recovering test runtime regressions is very

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. One of the ten commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] 6890f30 - [AST][Introspection] Fix args not being set.

Author: Nathan James Date: 2021-04-15T00:19:40+01:00 New Revision: 6890f302f587ca4f6712be728bd9302da597fe0c URL: https://github.com/llvm/llvm-project/commit/6890f302f587ca4f6712be728bd9302da597fe0c DIFF: https://github.com/llvm/llvm-project/commit/6890f302f587ca4f6712be728bd9302da597fe0c.diff

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb6c2874be8: [AST][NFC] Remove temporary ASTTU file from Introspection generation. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[clang] bfb6c28 - [AST][NFC] Remove temporary ASTTU file from Introspection generation.

Author: Nathan James Date: 2021-04-15T00:14:55+01:00 New Revision: bfb6c2874be830cc6f7595652d23192598edecf0 URL: https://github.com/llvm/llvm-project/commit/bfb6c2874be830cc6f7595652d23192598edecf0 DIFF: https://github.com/llvm/llvm-project/commit/bfb6c2874be830cc6f7595652d23192598edecf0.diff

[clang] b23abbe - [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

Author: Nathan James Date: 2021-04-15T00:12:22+01:00 New Revision: b23abbeab1d76376b4b46142d04e6c105c1074f0 URL: https://github.com/llvm/llvm-project/commit/b23abbeab1d76376b4b46142d04e6c105c1074f0 DIFF: https://github.com/llvm/llvm-project/commit/b23abbeab1d76376b4b46142d04e6c105c1074f0.diff

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGb23abbeab1d7: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337576. haberman marked 6 inline comments as done. haberman added a comment. - Word-smithed diagnostics and addressed other review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://rev

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

steveire requested changes to this revision. steveire added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:26 +if (On->returnsPointer()) + OS << "->"; +else The reason for the `Loca

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. bool keepFramePointer(const MachineFunction &MF) const override; In D80344#2673335 , @lebedev.ri wrote: > In D80344#2673148 , @asmith wrote: > >> In D80344#2671157

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

rsmith added inline comments. Comment at: clang/include/clang/Basic/Thunk.h:157 + + /// Holds a pointer to the overridee(!) method this thunk is for, + /// if needed by the ABI to distinguish different thunks with equal Isn't this the same as `BaseMethod.getDec

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

steveire added a comment. Indeed, I just this evening discovered the need for this to be stable across runs for testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100378/new/ https://reviews.llvm.org/D100378 __

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ?

[clang] c960c38 - NFC: Remove condition to simplify code

Author: Stephen Kelly Date: 2021-04-14T23:38:04+01:00 New Revision: c960c3836c6a28ba8f8c0b21db0474bf7d674a18 URL: https://github.com/llvm/llvm-project/commit/c960c3836c6a28ba8f8c0b21db0474bf7d674a18 DIFF: https://github.com/llvm/llvm-project/commit/c960c3836c6a28ba8f8c0b21db0474bf7d674a18.diff

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repos

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

MaskRay added a comment. In D93185#2688003 , @dblaikie wrote: > @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch > is approved without any text. Please include some text when approving patches > to make sure there's a record on

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

sammccall added a comment. Herald added a project: clang-tools-extra. Thanks for working on this and sorry for the long delay! I also think it's really useful, I hope we can simplify the impl a little and land it. Comment at: clang-tools-extra/clangd/refactor/tweaks/Implement

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

aeubanks added a comment. I'm not sure that having a helper method with 4 lambdas is any cleaner. Normal control flow in a function is easier to read and understand, and not really that much more code. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:222 if (any_

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

aeubanks updated this revision to Diff 337572. aeubanks marked 2 inline comments as done. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri updated this revision to Diff 337567. lebedev.ri added a comment. @rsmith thank you for taking a look! This still feels pretty much like doing it while blindfolded. I've tried to store `GlobalDecl`, but i'm clearly missing something else, since there are still 23 test failures, and not

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc created this revision. mibintc added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. mibintc requested review of this revision. Herald added a project: clang. I got a bug report that https://reviews.llvm.org/D97764 which introduced this diagnostic, was causing problems in i

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2689839 , @lebedev.ri wrote: > Might you be interested in implementing [[ > https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a > follow-up? Thanks for bring it up, @lebedev.ri. Yes, I will lo

[PATCH] D100509: Support GCC's -fstack-usage flag

lebedev.ri added a comment. Might you be interested in implementing [[ https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D1005

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337556. ggeorgakoudis added a comment. Fix llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/tes

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. In D99949#2689583 , @gregrodgers wrote: > Dependence on hsa is not necessary. The amdgpu and nvidia drivers both use > PCI codes available in /sys . We should use architecture independent methods > as much as possible.

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng created this revision. pzheng added reviewers: apazos, efriedma, seaneveson, bruno, MatzeB, hfinkel. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-

[PATCH] D100507: [Clang][Docs] Claim the atomic compare

tianshilei1992 created this revision. Herald added a subscriber: jfb. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I'm working on the implementation of OpenMP 5.1 feature `atomi

[PATCH] D100402: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a18cc23efad: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u} (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D100402?vs=337213&id=337540#toc Repository: rG LLV

[clang] 6a18cc2 - [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

Author: Thomas Lively Date: 2021-04-14T13:43:09-07:00 New Revision: 6a18cc23efad410db48a3ccfc233d215de7d4cb9 URL: https://github.com/llvm/llvm-project/commit/6a18cc23efad410db48a3ccfc233d215de7d4cb9 DIFF: https://github.com/llvm/llvm-project/commit/6a18cc23efad410db48a3ccfc233d215de7d4cb9.diff

[PATCH] D99231: [AST] Add introspection support for more base nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGf347f0e0b869: [AST] Add introspection support for more base nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D99231?vs=336813&id=337537#toc Repository: rG LLVM Gith

[clang] f347f0e - [AST] Add introspection support for more base nodes

Author: Stephen Kelly Date: 2021-04-14T21:31:23+01:00 New Revision: f347f0e0b869be4f9b97f26663cf8e4eac2c4868 URL: https://github.com/llvm/llvm-project/commit/f347f0e0b869be4f9b97f26663cf8e4eac2c4868 DIFF: https://github.com/llvm/llvm-project/commit/f347f0e0b869be4f9b97f26663cf8e4eac2c4868.diff

[clang] d2bb3cb - Make test runnable on read-only file systems.

Author: Sterling Augustine Date: 2021-04-14T13:29:51-07:00 New Revision: d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f URL: https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f DIFF: https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f.

[clang] 6559ebd - [AST] Replace asserts with a condition

Author: Stephen Kelly Date: 2021-04-14T21:14:05+01:00 New Revision: 6559ebd91b70f8d2ed82e19539ee09c5220159c2 URL: https://github.com/llvm/llvm-project/commit/6559ebd91b70f8d2ed82e19539ee09c5220159c2 DIFF: https://github.com/llvm/llvm-project/commit/6559ebd91b70f8d2ed82e19539ee09c5220159c2.diff

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107 +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; aheejin wrote: > Not related to this CL, but we write encoding

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers added a comment. Dependence on hsa is not necessary. The amdgpu and nvidia drivers both use PCI codes available in /sys . We should use architecture independent methods as much as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D100502: Allow lib64 in driver test

troyj created this revision. troyj added a reviewer: clang. troyj added a project: clang. troyj requested review of this revision. Herald added a subscriber: cfe-commits. The test clang/test/Driver/rocm-detect.hip does not consider that "lib" may be "lib64" instead. Repository: rG LLVM Github

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Personally, I'm not a fan of boolean function parameters because of the inline comments necessary to make the call site understandable. But it appears to be consistent with LLVM Coding St

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added inline comments. Comment at: clang/lib/AST/VTableBuilder.cpp:1155-1157 + // Override it. Note that there may or may not be a thunk already. + VTableThunks.erase(Idx); + VTableThunks.insert({Idx, *TI}); rsmith wrote: > Can you modif

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

rsanthir.quic added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:36 + bool HasSHA3; + bool HasSM4; bool HasUnaligned; Would it make sense to further differentiate SM3 and SM4? I see that we differentiate between the two in arm_neon.td ("AR

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

rsmith added inline comments. Comment at: clang/include/clang/Basic/ABI.h:182 + /// an ABI-specific comparator. + const CXXMethodDecl *BaseMethod; + Instead of the changes you made to `GlobalDecl`, I think this should be a `GlobalDecl` itself. Different functi

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100468/new/ https://reviews.llvm.org/D100468 ___ cfe-c

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne added a comment. Oh, and can you make sure the Runtimes build passes CI before shipping this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-comm

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. As discussed offline, I think this is fine. This layout seems to be closest to what other compilers use. @phosek said he would send out an RFC to make the multiarch layout become the defaul

[PATCH] D100428: [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1554f32e3b3: [clang][FileManager] Support empty file name in getVirtualFileRef for… (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D100428?vs=337289&id=337507#toc Repository

[clang] c1554f3 - [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

Author: Alex Lorenz Date: 2021-04-14T11:29:25-07:00 New Revision: c1554f32e3b3fafab64698fdb5b806b1bda4aa8a URL: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a DIFF: https://github.com/llvm/llvm-project/commit/c1554f32e3b3fafab64698fdb5b806b1bda4aa8a.diff L

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > FYI, I pushed the fix for the aarch64-coff issue now (D99572 > , rGd5c5cf5ce8d921fc8c5e1b608c298a1ffa688d37 > ) and > pushed another commit to remove the code for disa

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

scw added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} ymandel wrote: > Hmm. Looks like we could use smart pointer support in tooling::buildAddress

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5717225e89: [libTooling] Add smart pointer support to the `access` Stencil (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100450/new/ ht

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7925b4dd65: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u} (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100425/new/ https

[clang] 1c57172 - [libTooling] Add smart pointer support to the `access` Stencil

Author: Shu-Chun Weng Date: 2021-04-14T10:45:59-07:00 New Revision: 1c5717225e89d4b266784f1a1fe482530bc4b6f2 URL: https://github.com/llvm/llvm-project/commit/1c5717225e89d4b266784f1a1fe482530bc4b6f2 DIFF: https://github.com/llvm/llvm-project/commit/1c5717225e89d4b266784f1a1fe482530bc4b6f2.diff

[clang] af7925b - [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s, u}

Author: Thomas Lively Date: 2021-04-14T10:42:45-07:00 New Revision: af7925b4dd6519ebf0126ac8a18d791eb26968c9 URL: https://github.com/llvm/llvm-project/commit/af7925b4dd6519ebf0126ac8a18d791eb26968c9 DIFF: https://github.com/llvm/llvm-project/commit/af7925b4dd6519ebf0126ac8a18d791eb26968c9.diff

[clang] 2fe4909 - clang-format: fix undefined behavior.

Author: Martin Probst Date: 2021-04-14T19:41:18+02:00 New Revision: 2fe4909748b5f14499e83b0647b7e9ddd0068a15 URL: https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15 DIFF: https://github.com/llvm/llvm-project/commit/2fe4909748b5f14499e83b0647b7e9ddd0068a15.diff

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne added a comment. Well, one way to see things is that this patch only makes yet another step in a direction that we're already rather far in (in terms of CMake complexity). And as I said, I think the separation of `__config_site` in its own platform-specific directory makes a lot of sens

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7ab81ce310: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100411/new/

[clang] af7ab81 - [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

Author: Thomas Lively Date: 2021-04-14T09:19:27-07:00 New Revision: af7ab81ce3104418b4971b2398c1e028238ed90f URL: https://github.com/llvm/llvm-project/commit/af7ab81ce3104418b4971b2398c1e028238ed90f DIFF: https://github.com/llvm/llvm-project/commit/af7ab81ce3104418b4971b2398c1e028238ed90f.diff

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Instead of using a MinVersion and MaxVersion field, encode the version of a b

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. At this point I am not convinced this patch will provide benefit for the default use case when `-entropic=1`. I am hesitant to add complexity to the code for unsure benefit. If you request a FuzzBench experiment

[PATCH] D100368: [X86] Support some missing intrinsics

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9593 +/// locations starting at location \a base_addr at packed 32-bit integer indices +/// stored in the lower half of \a vindex scaled by \a scale them in dst. +/// "scale them i

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

Jonathan.Crowther created this revision. Jonathan.Crowther added reviewers: abhina.sreeskantharajan, anirudhp, muiez, zibi, yusra.syeda, rnk, amccarth. Herald added subscribers: wenlei, hiraditya. Jonathan.Crowther requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D99501: ignore -flto= options recognized by GCC

tejohnson added a comment. Just approved the test case patch. Sorry I missed the lack of test on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-com

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100484/new/ https://reviews.llvm.org/D100484 ___ cfe-commits mailing list cfe-com

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. Hello. Due to the time zone difference, I think our communication is a bit inefficient. Can we arrange a convenient time for you to focus on the discussion? We use CST. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D100466: clang-format: [JS] merge import lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rGd45df0d29f70: clang-format: [JS] merge import lines. (authored by mprobst). Changed prior to commit: htt

[clang] 4d195f1 - review comments

Author: Martin Probst Date: 2021-04-14T17:20:08+02:00 New Revision: 4d195f1b4dd6e3978776d69f49840439933a2543 URL: https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543 DIFF: https://github.com/llvm/llvm-project/commit/4d195f1b4dd6e3978776d69f49840439933a2543.diff

[clang] d45df0d - clang-format: [JS] merge import lines.

Author: Martin Probst Date: 2021-04-14T17:20:07+02:00 New Revision: d45df0d29f7005d3c25357f3982002eaf339f875 URL: https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875 DIFF: https://github.com/llvm/llvm-project/commit/d45df0d29f7005d3c25357f3982002eaf339f875.diff

[PATCH] D100466: clang-format: [JS] merge import lines.

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100466/new/ https://reviews.llvm.org/D100466 ___ c

[clang] f29dcbd - Add flag for showing skipped headers in -H / --show-includes output

Author: Hans Wennborg Date: 2021-04-14T17:01:51+02:00 New Revision: f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e URL: https://github.com/llvm/llvm-project/commit/f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e DIFF: https://github.com/llvm/llvm-project/commit/f29dcbdde10c86cfd89196fc2aa0e7f6ca3c9c4e.diff

[PATCH] D100480: Add flag for showing skipped headers in -H / --show-includes output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf29dcbdde10c: Add flag for showing skipped headers in -H / --show-includes output (authored by hans). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100466: clang-format: [JS] merge import lines.

mprobst marked 3 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:92 + // reference needs re-formatting. + bool SymbolsMerged; // The source location just after { and just before } in the import.

[PATCH] D99501: ignore -flto= options recognized by GCC

doko added a comment. that's now https://reviews.llvm.org/D100484 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D100466: clang-format: [JS] merge import lines.

mprobst updated this revision to Diff 337456. mprobst added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100466/new/ https://reviews.llvm.org/D100466 Files: clang/lib/Format/SortJavaScriptImports.cpp clang/

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

olestrohm updated this revision to Diff 337450. olestrohm added a comment. Added more exhaustive tests, as well as fixed the diagnostic to allow reference types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/ https://reviews.llvm.org/D100471 Files: clang/lib/Sema/SemaDecl

[PATCH] D100480: Add flag for showing skipped headers in -H / --show-includes output

hans created this revision. hans added reviewers: thakis, rnk. Herald added subscribers: jansvoboda11, dang. hans requested review of this revision. Herald added a project: clang. Consider the following set of files: a.cc: #include "a.h" a.h: #ifndef A_H #define A_H #include "b.

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. In D99949#2688869 , @gregrodgers wrote: > 1. It does not provide the infrastructure to identify runtime capabilities to > satisfy requirements of a compiled image. I believe we only require a value for '-march=' to unbloc

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

aaron.ballman added a comment. In D97653#2681458 , @njames93 wrote: > Use implicit capture instead of default capture. > > @aaron.ballman, Unfortunately the AST dump tests don't work as implicit > captures don't appear to show up in the textual representa

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers requested changes to this revision. gregrodgers added a comment. This revision now requires changes to proceed. I have two serious concerns with this tool . 1. It does not provide the infrastructure to identify runtime capabilities to satisfy requirements of a compiled image. 2.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASString

  1   2   >