MaskRay added a comment. In D93185#2688003 <https://reviews.llvm.org/D93185#2688003>, @dblaikie wrote:
> @thakis - just FYI, Phab doesn't send mail to the mailing list when a patch > is approved without any text. Please include some text when approving patches > to make sure there's a record on the mailing list. (@maskray has a browser > script or the like to automate this - I forget if it's posted somewhere to > link to... maybe in the llvm phab docs) Only use in trivial approvals :) // ==UserScript== // @name reviews.llvm.org: add comment "LGTM" when accepting // @namespace http://tampermonkey.net/ // @version 0.1 // @description try to take over the world! // @author You // @match https://reviews.llvm.org/* // @grant none // ==/UserScript== (function() { 'use strict'; const select = document.querySelector('.aphront-form-input > select') if (select) select.onchange = function() { const accept = select.querySelector('option[value=accept]') if (accept && accept.disabled) { const comment = document.querySelector('.remarkup-assist-textarea') if (comment && comment.value.length == 0) { const words = ['LGTM.', 'Thanks!', 'Looks great!'] comment.value = words[~~(Math.random()*words.length)]+' ' comment.focus() } } } })(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93185/new/ https://reviews.llvm.org/D93185 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
