[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc updated this revision to Diff 322302. poelmanc added a comment. Capitalize `IsOrHasDescendant`, add `} namespace std` per HarborMaster feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714 File

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:193 CC1Args.push_back("-emit-llvm-bc"); + + std::string BitcodeSuffix = "amdgcn-" + GpuArch.str(); tianshilei1992 wrote: > JonChesterfield wrote: > > Need `if (Dri

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

pdhaliwal updated this revision to Diff 322298. pdhaliwal added a comment. - Added check for nogpulib - Fixed diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ https://reviews.llvm.org/D96248 Files: clang/include/clang/

[PATCH] D96268: [-Wcompletion-handler] Support checks with builtins

vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:343 +case Builtin::BI__builtin_expect_with_probability: { + assert(CE->getNumArgs() >= 2); + NoQ wrote: > Otherwise it's a compile error and analysis based warnings aren

[PATCH] D93003: [libunwind][ELF] Hide unw_getcontext with LIBUNWIND_HIDE_SYMBOLS

rprichard added inline comments. Comment at: libunwind/src/assembly.h:82 .globl SYMBOL_NAME(aliasname) SEPARATOR \ - WEAK_SYMBOL(aliasname) SEPARATOR \ + EXPORT_SYMBOL(SYMBOL_NAME(aliasname))

[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

pengfei added a comment. Hi @craig.topper, this patch is intent upon LLVM 12.0 release stablization, since the new AMX interface is on development and has some know issues. Do you think it is necessary and enough for the release? If it does, we can commit it to both trunk and 12.x branch. Rep

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. In D96082#2549943 , @steveire wrote: > In D96082#2545807 , @LukasHanel > wrote: > >> Hi, thanks for discussing my proposal! >> >> - Usefulness of the fix-it's > > I agree with @njames93

[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

LuoYuanke added inline comments. Comment at: clang/lib/Headers/amxintrin_experiment.h:12 + * This file is experiment interface for AMX new programming model. + */ + pengfei wrote: > It's better to add such macros: > ``` > #ifndef __AMXINTRIN_EXPERIMENT_H > #defin

[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

LuoYuanke updated this revision to Diff 322293. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96315/new/ https://reviews.llvm.org/D96315 Files: clang/lib/Headers/CMakeLists.txt clang/lib/H

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

vitalybuka created this revision. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Distributed ThinLTO has special case when backend fallback to regular non-ThinLTO versio

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11127 +def err_riscvv_builtin_not_useable : Error< + "builtin requires 'V' extension support to be enabled">; } // end of sema component. Add blank line. Is it "err_riscvv_

[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin_experiment.h:12 + * This file is experiment interface for AMX new programming model. + */ + It's better to add such macros: ``` #ifndef __AMXINTRIN_EXPERIMENT_H #define __AMXINTRIN_EXPERIMENT_

[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

LuoYuanke created this revision. Herald added subscribers: pengfei, mgorny. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since the new AMX interface is not mature right now, we assemble the new interface to an experiment file.

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc added a comment. In D68682#2547906 , @kadircet wrote: > It looks like premerge tests skipped your last diff with id 321451 > (https://reviews.llvm.org/harbormaster/?after=87950). You can re-trigger by > uploading a new diff, in the meantime i wo

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll:77 +; CHECK-NEXT:[[TILEDPBSSD_UNROLL_ROWS_IV:%.*]] = phi i16 [ 0, [[ENTRY:%.*]] ], [ [[TILEDPBSSD_UNROLL_ROWS_STEP:%.*]], [[TILEDPBSSD_UNROLL_ROWS_LATCH:%.*]] ] +; CHECK-NEXT:[[VEC

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

NoQ added a comment. In D96215#2548492 , @aaron.ballman wrote: > Should structured bindings be treated similarly as well (not necessarily as > part of this patch)? Umm, looks like we're both missing the elephant in the room: passing a variable into a f

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG98c21289f1d2: [CUDA][HIP] Add -fuse-cuid (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95007?vs=322020&

[clang] 98c2128 - [CUDA][HIP] Add -fuse-cuid

Author: Yaxun (Sam) Liu Date: 2021-02-08T22:26:12-05:00 New Revision: 98c21289f1d239f39fa549ae01b17efffce6a7c0 URL: https://github.com/llvm/llvm-project/commit/98c21289f1d239f39fa549ae01b17efffce6a7c0 DIFF: https://github.com/llvm/llvm-project/commit/98c21289f1d239f39fa549ae01b17efffce6a7c0.dif

[PATCH] D96268: [-Wcompletion-handler] Support checks with builtins

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, yup, makes sense! Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:343 +case Builtin::BI__builtin_expect_with_probability: { + assert(CE->getNumArgs() >= 2); +

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 322265. poelmanc added a comment. Call `llvm::Annoation` constructor rather than `operator=` to fix linux build issue, fix some issues identified by clang-format and clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-cuid.hip:98 + +// RUN: rm -rf %t.out + tra wrote: > Is it necessary? The next 'RUN' command would overwrite the temp file anyways. > Also, you don't have to c

[PATCH] D96196: [Sema][NFC] Create Sema::BuildImplicitCast

shafik added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1060 if (tcr != TC_Success && msg != 0) { if (SrcExpr.isInvalid()) // if conversion failed, don't report another error return; Can we ever have this case w/ the added `if (SrcEx

[clang] 21e8bb8 - PR48606: The lifetime of a constexpr heap allocation always started

Author: Richard Smith Date: 2021-02-08T17:58:05-08:00 New Revision: 21e8bb83253e1a2f4b6fad9b53cafe8c530a38e2 URL: https://github.com/llvm/llvm-project/commit/21e8bb83253e1a2f4b6fad9b53cafe8c530a38e2 DIFF: https://github.com/llvm/llvm-project/commit/21e8bb83253e1a2f4b6fad9b53cafe8c530a38e2.diff

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc updated this revision to Diff 322253. poelmanc added a comment. Thanks for your patience, this one should work, as I used my normal `git show HEAD -U99` workflow. (The requested change was just to add a period to a comment, so as a short-cut I tried "Raw Diff" -> copy -> "Update Di

[clang] c945dc4 - PR48587: is_constant_evaluated() should not evaluate to true during a

Author: Richard Smith Date: 2021-02-08T17:34:40-08:00 New Revision: c945dc4a5023d6a17d11fcda76509b94b36e34fc URL: https://github.com/llvm/llvm-project/commit/c945dc4a5023d6a17d11fcda76509b94b36e34fc DIFF: https://github.com/llvm/llvm-project/commit/c945dc4a5023d6a17d11fcda76509b94b36e34fc.diff

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 322240. tiagoma added a comment. Add support for do/while Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst clang/includ

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

steveire added a comment. In D69560#2536597 , @whisperity wrote: > In D69560#2536570 , @steveire wrote: > >> I haven't read through all the comments, but the word 'easily' implies >> 'desirable'. This check seems t

[clang] 52f312c - Fix failure in cuda-external-tools.cu

Author: Yaxun (Sam) Liu Date: 2021-02-08T19:27:43-05:00 New Revision: 52f312c69e1049e1f3034baf7cb9d88875f45c9a URL: https://github.com/llvm/llvm-project/commit/52f312c69e1049e1f3034baf7cb9d88875f45c9a DIFF: https://github.com/llvm/llvm-project/commit/52f312c69e1049e1f3034baf7cb9d88875f45c9a.dif

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

steveire added a comment. In D96082#2545807 , @LukasHanel wrote: > Hi, thanks for discussing my proposal! > Although I think it can stand as is, I was looking for feedback: > > - Is the name good? > - Is the `readability` group good? Or better in `misc`?

[PATCH] D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8cb39bab04c: Make sure a module file with errors produced via '-fallow-pcm-with-compiler… (authored by akyrtzi). Repository: rG LLVM Github Monor

[clang] a8cb39b - Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

Author: Argyrios Kyrtzidis Date: 2021-02-08T16:10:39-08:00 New Revision: a8cb39bab04c317c9886ec3a332f3b70ce27ae4f URL: https://github.com/llvm/llvm-project/commit/a8cb39bab04c317c9886ec3a332f3b70ce27ae4f DIFF: https://github.com/llvm/llvm-project/commit/a8cb39bab04c317c9886ec3a332f3b70ce27ae4f.

[PATCH] D96105: [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dab94f9ede5: [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 1dab94f - [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1

Author: Yaxun (Sam) Liu Date: 2021-02-08T19:08:20-05:00 New Revision: 1dab94f9ede5d506d6ff9c61448a8e20d43e05a7 URL: https://github.com/llvm/llvm-project/commit/1dab94f9ede5d506d6ff9c61448a8e20d43e05a7 DIFF: https://github.com/llvm/llvm-project/commit/1dab94f9ede5d506d6ff9c61448a8e20d43e05a7.dif

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

tianshilei1992 added a comment. Generally LGTM. In D96248#2549339 , @JonChesterfield wrote: > The existing search logic looks in clang's lib and LIBRARY_PATH, I think we > should probably look in the runtime directory as well for running from the > bui

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 38. cjdb marked 4 inline comments as done. cjdb added a comment. Herald added a subscriber: cfe-commits. addresses comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10267-10277 + if (const auto *Field = dyn_cast(D)) { S.Diag(UnaryExpr->getBeginLoc(), diag::warn_free_nonheap_object) << CalleeName << Field; +return; + } + + if (const auto *Func = dyn_c

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

aganea added a comment. In D95534#2534510 , @smeenai wrote: > Now if only Windows could case-correct their SDKs so we didn't need VFS > overlays and symlinks for the linker... I opened a ticket

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

arysef added a comment. Herald added a subscriber: nullptr.cpp. Here are also some bugs that seem like they could be closed once this is merged: https://bugs.llvm.org/show_bug.cgi?id=28480 https://bugs.llvm.org/show_bug.cgi?id=32239 Also about the current behavior, it seems like this behavior h

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few test nits. LGTM in principle. Comment at: clang/test/Driver/hip-cuid.hip:98 + +// RUN: rm -rf %t.out + Is it necessary? The next 'RUN' command would overwrite

[PATCH] D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96246/new/ https://reviews.llvm.org/D96246 _

[PATCH] D96105: [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hip-rdc-device-only.hip:50-61 // COMMON: [[CLANG:".*clang.*"]] "-cc1" "-mllvm" "--amdhsa-code-object-version={{[0-9]+}}" "-triple" "amdgcn-amd-a

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl updated this revision to Diff 322213. yaxunl retitled this revision from "[HIP] Simplify kernel launching" to "[HIP] Emit kernel symbol". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 87dbdd2 - [FileCheck] Default --allow-unused-prefixes to false

Author: Fangrui Song Date: 2021-02-08T13:37:04-08:00 New Revision: 87dbdd2e3bb63b681f8cc3179ef5c2d5929bbf61 URL: https://github.com/llvm/llvm-project/commit/87dbdd2e3bb63b681f8cc3179ef5c2d5929bbf61 DIFF: https://github.com/llvm/llvm-project/commit/87dbdd2e3bb63b681f8cc3179ef5c2d5929bbf61.diff

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87dbdd2e3bb6: [FileCheck] Default --allow-unused-prefixes to false (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

rnk added inline comments. Comment at: llvm/docs/LangRef.rst:1220 +``alignstack()`` +This indicates the alignment that should be considered by the backend when +assigning this parameter to a stack slot during calling convention chill wrote: > rnk wrote: >

[PATCH] D96049: [Timer] On macOS count number of executed instructions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Seems useful! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96049/new/ https://reviews.llvm.org/D96049 __

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:193 CC1Args.push_back("-emit-llvm-bc"); + + std::string BitcodeSuffix = "amdgcn-" + GpuArch.str(); Need `if (DriverArgs.hasArg(options::OPT_nogpulib)) return;` her

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. I do have a plan to modify the auto upgrader to use the bundles when it's possible to do so, but I'm currently not considering landing the changes I reverted since they were only needed to avoid duplicating constant strings. I don't think we can avoid duplicating the s

[PATCH] D96286: [clangd] Change TidyProvider cache to use a linked list approach

njames93 added a comment. A similar approach could be used for the config provider, however It may not make as much sense there. The directories are traversed in the opposite order and we will always attempt to read from each directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96286: [clangd] Change TidyProvider cache to use a linked list approach

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. I know linked lists are the work

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:177 + const std::size_t StartIndex) { + const std::size_t NumParams = FD->getNumParams(); + assert(StartIndex < NumPa

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

thakis added inline comments. Comment at: lld/tools/lld/lld.cpp:74 .CasesLower("ld64", "ld64.lld", "darwin", Darwin) - .CasesLower("darwinnew", "ld64.lld.darwinnew", DarwinNew) .Default(Invalid); very nit: You could keep darwinnew around for a

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers created this revision. nickdesaulniers added reviewers: DavidSpickett, ostannard. Herald added a subscriber: danielkiss. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similiar to D95872

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. In D92808#2545873 , @ahatanak wrote: > I ended up reverting the changes I made to `llvm/lib/IR/AutoUpgrade.cpp` as > the file was including `llvm/Analysis/ObjCARCUtil.h`, which was violating > layering. Are you planning to la

[PATCH] D18961: Add a readability-deleted-default clang-tidy check.

aaron.ballman added a comment. In D18961#2549303 , @njames93 wrote: > Now that there is a stable warning in clang for this check that is enabled > without specifying any warning flags, Is there reason to think about retiring > this check? I'd be fine wi

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

mgrang added a comment. Herald added a subscriber: JDevlieghere. Hi @jfb This patch results in a compiler crash when building a simple C program on a Windows X86 Debug build. I have filed this issue to track it. Repository: rG LLVM Github Monorep

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:110 +break; + default: +if (T->isUnsignedIntegerType() && T->isWideCharType()) I think we should use the prettier printing for `wchar_t` / `char8_t` / `char16_t` / `cha

[PATCH] D95055: [clang] Don't look into for C++ headers if they are found alongside the toolchain

tstellar added a comment. Sorry, it's too late for 11.1.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95055/new/ https://reviews.llvm.org/D95055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95055: [clang] Don't look into for C++ headers if they are found alongside the toolchain

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Sorry for missing this earlier! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95055/new/ https://reviews.llvm.org/D95055

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. Looks like an existing problem, but for building openmp via runtimes, with this patch applied this doesn't look in the right place and errors: 'error: No library 'libomptarget-amdgcn-gfx906.bc' found in the default clang lib directory or in LIBRARY_PATH. Please

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. This is similar enough to the original patch I'm comfortable signing off, even though @Bigcheese hasn't had a chance to take a look. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D18961: Add a readability-deleted-default clang-tidy check.

njames93 added a comment. Herald added a subscriber: mgorny. Now that there is a stable warning in clang for this check that is enabled without specifying any warning flags, Is there reason to think about retiring this check? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D96269: [clang][cli] Look up program action argument in a table

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96269/new/ https://reviews.llvm.org/D96269

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96056/new/ https://reviews.llvm.org/D96056

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, although the description seems incorrect: > This patch implements generation of remaining preprocessor options and tests > it by performing parse-generate-parse round trip. In f

[PATCH] D96158: [clang][cli] Generate and round-trip Target options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96158/new/ https://reviews.llvm.org/D96158

[PATCH] D96273: [clang][cli] Generate and round-trip DependencyOutput options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96273/new/ https://reviews.llvm.org/D96273

[PATCH] D96149: [clang][cli] Store InputKind in FrontendOptions

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96149/new/ https://reviews.llvm.org/D96149

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:745 + +A->render(Args, Rendered); } It's not obvious why this renders the

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96278/new/ https://reviews.llvm.org/D96278

[PATCH] D96280: [WIP][clang][cli] Round-trip the whole CompilerInvocation

dexonsmith added a comment. Mostly looks great; happy to see this come full circle and remove the round-tripping boilerplate. Just a couple of questions inline below. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1940-1941 case EDK_ProfileList: - GenerateArg(

[PATCH] D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules

akyrtzi updated this revision to Diff 322166. akyrtzi added a comment. clang-format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96246/new/ https://reviews.llvm.org/D96246 Files: clang/include/clang/Serialization/ASTReader.h clang/lib/

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for this patch @FarisRehman , it's great to see more tests being ported to the new driver! Although this patches touches many files, it mostly just generalizes the `RUN` lin

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo some testing requests. Thanks! Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + ---

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2582-2584 +int64_t BitfieldSize = Field->getBitWidthValue(Context); +if (BitfieldSize > FieldSizeInBits) + return llvm::None; steakhal wrote: > Why do you return `None` here? The

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5977 +checkSwiftAsyncErrorBlock(S, D, ErrorAttr, AsyncAttr); +} + aaron.ballman wrote: > Should there be a diagnostic to combine `swift_error` and `swift_async_error` > on the

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington updated this revision to Diff 322152. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Get rid of a useless `return`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96175/new/ https://reviews.llvm.org/D96175 Files: clang/include/clang/

[PATCH] D96281: Add options to flag individual core increments and to ignore macros to cognitive complexity check.

massberg created this revision. massberg added reviewers: lebedev.ri, alexfh. Herald added a subscriber: nullptr.cpp. massberg requested review of this revision. Herald added a project: clang. Often you are only interested in the overall cognitive complexity of a function and not every individual

[PATCH] D96280: [WIP][clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Finally, this patch moves from round-tripping one `CompilerInvocation` at a time to round

[PATCH] D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the cl_khr_subgroup_extended_types extension t

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch splits out the last two option groups (`Filesy

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

sdesmalen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:153 + compiler should use fixed-width or scalable vectorization. Fixed-width is + assumed by default. Scalable vectorization is an experimental feature for + targets that support it, such as Arm targets

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining diagnostic

[PATCH] D86376: [HIP] Simplify kernel launching

yaxunl added a comment. In D86376#2239618 , @tra wrote: > In D86376#2239391 , @yaxunl wrote: > >> For example, in HIP program, there is a kernel `void foo(int*)`. If a C++ >> program wants to launch it, the desirab

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

njames93 added a comment. I'm unable to cleanly apply this patch, looks like something was a bit off when you created the diff. ➜ llvm-project git:(main) ✗ arc patch D95714 INFO Base commit is not in local repository; trying to fetch. Created and checked out b

[PATCH] D96273: [clang][cli] Generate and round-trip DependencyOutput options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining dependency

[PATCH] D96158: [clang][cli] Generate and round-trip Target options

jansvoboda11 updated this revision to Diff 322128. jansvoboda11 added a comment. Switch to static functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96158/new/ https://reviews.llvm.org/D96158 Files: clang/include/clang/Driver/Options.td c

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

spatel added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9352 static __inline__ double __DEFAULT_FN_ATTRS512 _mm512_reduce_add_pd(__m512d __W) { return __builtin_ia32_reduce_fadd_pd512(0.0, __W); } Ah - this is where the +0.0 is specified

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

david-arm created this revision. david-arm added reviewers: sdesmalen, willlovett, c-rhodes. david-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96270 Files: clang/do

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3363 + +When ``pragma float_control(source, off)`` or +``pragma float_control(double, off)`` or I'd like to add Intel ICL compatible syntax, but 'off' doesn't make too much sense to me.

[PATCH] D96156: [clang][cli] Generate and round-trip PreprocessorOutput options

jansvoboda11 updated this revision to Diff 322124. jansvoboda11 added a comment. Switch from member functions to static ones Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96156/new/ https://reviews.llvm.org/D96156 Files: clang/include/clang/Driv

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 322123. svenvh added a comment. Do not assume cast to Enum/TypedefDecl is always successful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ModuleFileExtension.h:75 + ModuleFileExtensionKind getKind() const { return Kind; } + I'm not sure what the best approach is here. `ModuleFileExtension` is an abstract class. Wh

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

poelmanc added a comment. In D95714#2548735 , @njames93 wrote: > LGTM, Same as last time for the commit? That would be great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95714/new/ https://reviews.llvm.org/D95714

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

spatel added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13829 CGM.getIntrinsic(Intrinsic::vector_reduce_fadd, Ops[1]->getType()); +Builder.getFastMathFlags().setAllowReassoc(true); return Builder.CreateCall(F, {Ops[0], Ops[1]}); ---

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 updated this revision to Diff 322121. jansvoboda11 added a comment. Fix whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96155/new/ https://reviews.llvm.org/D96155 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 updated this revision to Diff 322120. jansvoboda11 added a comment. Document getProgramActionOpt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96155/new/ https://reviews.llvm.org/D96155 Files: clang/include/clang/Driver/Options.td

[clang] 6b1e2fc - [FE] Manipulate the first byte of guard variable type in both load and store operation

Author: Xiangling Liao Date: 2021-02-08T11:14:34-05:00 New Revision: 6b1e2fc89327a64c9300d543e00f12435c32dfcf URL: https://github.com/llvm/llvm-project/commit/6b1e2fc89327a64c9300d543e00f12435c32dfcf DIFF: https://github.com/llvm/llvm-project/commit/6b1e2fc89327a64c9300d543e00f12435c32dfcf.diff

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e2fc89327: [FE] Manipulate the first byte of guard variable type in both load and store… (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

jansvoboda11 updated this revision to Diff 322118. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96056/new/ https://reviews.llvm.org/D96056 Files: clang/include/clang/Basic/XRayInstr.h clang/include/clang/D

  1   2   >