thakis added inline comments.
================
Comment at: lld/tools/lld/lld.cpp:74
.CasesLower("ld64", "ld64.lld", "darwin", Darwin)
- .CasesLower("darwinnew", "ld64.lld.darwinnew", DarwinNew)
.Default(Invalid);
----------------
very nit: You could keep darwinnew around for a bit too and make it mean the
same thing as just ld64.lld. Then people could update to a new build, then do
the (then) no-op change of replacing darwinnew with nothing. As is, updating
toolchain and changing build files have to happen in the same change, which is
always a bit annoying.
But since this was advertised as an unstable flag, it's not necessary, just
kind of friendly. Up to you. (If you do this, consider reverting the change to
the .gn file too.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95204/new/
https://reviews.llvm.org/D95204
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
