LuoYuanke added inline comments.
================ Comment at: clang/lib/Headers/amxintrin_experiment.h:12 + * This file is experiment interface for AMX new programming model. + */ + ---------------- pengfei wrote: > It's better to add such macros: > ``` > #ifndef __AMXINTRIN_EXPERIMENT_H > #define __AMXINTRIN_EXPERIMENT_H > #ifdef __x86_64__ > ``` Sure. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96315/new/ https://reviews.llvm.org/D96315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits