tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/hip-rdc-device-only.hip:50-61
 // COMMON: [[CLANG:".*clang.*"]] "-cc1" "-mllvm" 
"--amdhsa-code-object-version={{[0-9]+}}" "-triple" "amdgcn-amd-amdhsa"
 // COMMON-SAME: "-aux-triple" "x86_64-unknown-linux-gnu"
 // EMITBC-SAME: "-emit-llvm-bc"
 // EMITLL-SAME: "-emit-llvm"
 // COMMON-SAME: {{.*}} "-main-file-name" "a.cu"
-// COMMON-SAME: "-fcuda-is-device" "-fgpu-rdc" 
"-fcuda-allow-variadic-functions" "-fvisibility" "hidden"
+// COMMON-SAME: "-fcuda-is-device" "-fcuda-allow-variadic-functions" 
"-fvisibility" "hidden"
 // COMMON-SAME: "-fapply-global-visibility-to-externs"
----------------
At some point we should probably convert `-SAME` to `-DAG` so we don't have to 
shuffle the options around every time they change order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96105/new/

https://reviews.llvm.org/D96105

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D96105: [CUDA][HIP]... Artem Belevich via Phabricator via cfe-commits

Reply via email to