[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. anyway, I'm fine with this change, feel free to submit it as-is (or do any refinements), don't really want the naming to block this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:723 + syntax::UserDefinedLiteralExpression * + buildUserDefinedLiteral(UserDefinedLiteral *S) { +switch (S->getLiteralOperatorKind()) {

[clang] 50f2433 - Add diagnostic option backing field for -fansi-escape-codes

Author: Daniel Grumberg Date: 2020-07-10T07:26:56+01:00 New Revision: 50f24331fd91e70de6bf6c3efe45272ddfc711fd URL: https://github.com/llvm/llvm-project/commit/50f24331fd91e70de6bf6c3efe45272ddfc711fd DIFF: https://github.com/llvm/llvm-project/commit/50f24331fd91e70de6bf6c3efe45272ddfc711fd.dif

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f24331fd91: Add diagnostic option backing field for -fansi-escape-codes (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1210 + 12_t; // call: operator<'1', '2'> "" _x() | kind: integer + 1.2_t; // call: operator<'1', '2'> "" _x() | kind: float } gribozavr2 wrote: > call -> calls? (as in,

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276919. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Use right function to get TokSpelling, answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://review

[PATCH] D83511: [clangd] Config: If.PathExclude

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:73 + Frag.If.PathMatch.emplace_back("b.*"); + Frag.If.PathExclude.emplace_back(".*r"); + EXPECT_F

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276916. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-ext

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:196 switch (E->getStmtClass()) { case Stmt::CXXDependentScopeMemberExprClass: { const auto *ME = llvm::cast(E); hokein wrote: > I'm doubting whether we will miss some oth

[clang-tools-extra] 98d763a - [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

Author: Nathan Ridge Date: 2020-07-10T01:58:34-04:00 New Revision: 98d763ad051f5eab89fa46167516fc8a84f471d0 URL: https://github.com/llvm/llvm-project/commit/98d763ad051f5eab89fa46167516fc8a84f471d0 DIFF: https://github.com/llvm/llvm-project/commit/98d763ad051f5eab89fa46167516fc8a84f471d0.diff

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG98d763ad051f: [clangd] Factor out some helper functions related to heuristic resolution in… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge updated this revision to Diff 276911. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-ext

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Yes I committed this a while ago, I duplicated all the functionality in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574 ___ c

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1246 + +// AIX `power` alignment does not apply the preferred alignment for +// non-union classes if the source of the alignment (the current base in Move the

[clang] ceb76d2 - [CMake][Fuchsia] Move runtimes to outer scope

Author: Petr Hosek Date: 2020-07-09T21:07:44-07:00 New Revision: ceb76d2fe73d39f2230bf55d47b8fd68849d47d7 URL: https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7 DIFF: https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7.diff LO

[PATCH] D83509: CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

jfb added a comment. I don't remember if this will auto-close, since I forgot to add the Phabricator ID to the commit message. In any case it's in: 00c9a504aeed2603bd8bc9b89d753534e929c8e8 Repository: rG LLVM Github Monor

[clang] 00c9a50 - CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

Author: Oliver Hunt Date: 2020-07-09T20:27:33-07:00 New Revision: 00c9a504aeed2603bd8bc9b89d753534e929c8e8 URL: https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8 DIFF: https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8.diff L

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. This helps avoiding hacks downstream. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83529 Files: clang/include/clang/AST/Stmt.h c

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

zequanwu updated this revision to Diff 276899. zequanwu added a comment. Herald added subscribers: usaxena95, kadircet, jkorous. Fix clangd unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83514/new/ https://reviews.llvm.org/D83514 Files: clang-tools-extra/clangd/SemanticHigh

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

rjmccall added a comment. I agree that avoiding the copy is best. However, at the very least, if that function isn't going to handle the aggregate case correctly, it should assert that it isn't in it. Otherwise this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 276891. asbirlea added a comment. Nit: re-add `const`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 Files: llvm/include/llvm/IR/Dominators.h llvm/include/llvm/S

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 276890. asbirlea added a comment. This revision is now accepted and ready to land. Updated to include the part of the patch that's moving the Updates to a CFGDiff object. Splitting off from the clean-up work merging the two branches when BUI is null. This p

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[clang] 7462793 - Move default argument instantiation to SemaTemplateInstantiateDecl.cpp.

Author: Richard Smith Date: 2020-07-09T17:24:19-07:00 New Revision: 7462793be771712092de4c31fef1b04ac365ccea URL: https://github.com/llvm/llvm-project/commit/7462793be771712092de4c31fef1b04ac365ccea DIFF: https://github.com/llvm/llvm-project/commit/7462793be771712092de4c31fef1b04ac365ccea.diff

[clang] f721e05 - PR46648: Do not eagerly instantiate default arguments for a generic

Author: Richard Smith Date: 2020-07-09T17:24:20-07:00 New Revision: f721e0582b158c60c56d2601235b6d60758f4d7a URL: https://github.com/llvm/llvm-project/commit/f721e0582b158c60c56d2601235b6d60758f4d7a DIFF: https://github.com/llvm/llvm-project/commit/f721e0582b158c60c56d2601235b6d60758f4d7a.diff

[clang] a5569f0 - Push parameters into the local instantiation scope before instantiating

Author: Richard Smith Date: 2020-07-09T17:24:20-07:00 New Revision: a5569f089844209dbea2e3241460173d7b6b1420 URL: https://github.com/llvm/llvm-project/commit/a5569f089844209dbea2e3241460173d7b6b1420 DIFF: https://github.com/llvm/llvm-project/commit/a5569f089844209dbea2e3241460173d7b6b1420.diff

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk updated this revision to Diff 276881. amyk added a comment. Rebased patch, and addressed review comments of having a single `CHECK`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 Files: clang/lib/H

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.isRequired(), llvm::Any(&IR)); return Shoul

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 276866. Xiangling_L marked 9 inline comments as done. Xiangling_L added a comment. Fixed a base class related case by adding `IsFirstNonEmpty` flag; Split the `aix-Wpacked.cpp` testcase into two; Addressed other comments; CHANGES SINCE LAST ACTION http

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl added a comment. Thank you, for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583 ___ cfe-commits mailing list cfe-commi

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 ___

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true -

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

ahatanak added a comment. In D82513#2142596 , @rjmccall wrote: > This seems fine. I do wonder if the "real" bug is that this ought to be > handled properly in EmitReturnFromThunk, but regardless, the fix seems > acceptable. Since `EmitReturnFromThunk`

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

zequanwu reopened this revision. zequanwu added a comment. This revision is now accepted and ready to land. Reverted. It broke unit test SemanticHighlighting.GetsCorrectTokens in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83514/new/ http

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. This uses pass instrumentation callbacks to skip optional passes. PassInfoMixin now declares that passes

[clang] 8be204f - Revert "[Lexer] Fix missing coverage line after #endif"

Author: Zequan Wu Date: 2020-07-09T15:51:02-07:00 New Revision: 8be204fe75caac4ce6ed1e2cf5659011476bde79 URL: https://github.com/llvm/llvm-project/commit/8be204fe75caac4ce6ed1e2cf5659011476bde79 DIFF: https://github.com/llvm/llvm-project/commit/8be204fe75caac4ce6ed1e2cf5659011476bde79.diff LOG

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

ahatanak updated this revision to Diff 276858. ahatanak added a comment. Add test case for `trivial_abi`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82513/new/ https://reviews.llvm.org/D82513 Files: clang/lib/CodeGen/CGVTables.cpp clang/tes

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk requested changes to this revision. amyk added a comment. This revision now requires changes to proceed. This will need to be rebased against your 2608 instruction definitions patch. But yes, I believe you are missing the clang and llc test case for this patch. Requesting changes due to mis

[clang] 227db86 - Switch to using -debug-info-kind=constructor as default (from =limited)

Author: Amy Huang Date: 2020-07-09T15:26:46-07:00 New Revision: 227db86a1b7dd6f96f7df14890fcd071bc4fe1f5 URL: https://github.com/llvm/llvm-project/commit/227db86a1b7dd6f96f7df14890fcd071bc4fe1f5 DIFF: https://github.com/llvm/llvm-project/commit/227db86a1b7dd6f96f7df14890fcd071bc4fe1f5.diff LOG

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

This revision was automatically updated to reflect the committed changes. Closed by commit rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 276853. amyk added a comment. Fix assignment of variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Co

[PATCH] D83516: [PowerPC][Power10] RFC 2608 Instruction definitions and MC Tests

Conanap created this revision. Conanap added reviewers: power-llvm-team, PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. This implements instruction definitions and MC tests for RFC2608. Please note that some instrs have classes that will need to be changed later

[clang] 672ae62 - [Lexer] Fix missing coverage line after #endif

Author: Zequan Wu Date: 2020-07-09T15:15:40-07:00 New Revision: 672ae621e91ff5cdefb2535bdd530641536685ea URL: https://github.com/llvm/llvm-project/commit/672ae621e91ff5cdefb2535bdd530641536685ea DIFF: https://github.com/llvm/llvm-project/commit/672ae621e91ff5cdefb2535bdd530641536685ea.diff LOG

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

This revision was automatically updated to reflect the committed changes. Closed by commit rG672ae621e91f: [Lexer] Fix missing coverage line after #endif (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83514/new/ https://review

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn marked 3 inline comments as done. kpn added a comment. Thanks for the reviews and the fast turnaround! I do appreciate it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 ___ cfe-commits mailing

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ffec4672028: [PowerPC][Power10] Add Instruction definition/MC Tests for Load/Store Rightmost… (authored by Conanap, committed by amyk). Changed prior to commit: https://reviews.llvm.org/D83364?vs=2765

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83514/new/ https://reviews.llvm.org/D83514

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

zequanwu created this revision. zequanwu added reviewers: vsk, efriedma, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. bug reported here: https://bugs.llvm.org/show_bug.cgi?id=46660 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D835

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

MaskRay accepted this revision. MaskRay added a comment. LG with some nits Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3287 + if (Args.hasArg(OPT_fexperimental_strict_floating_point)) { +Opts.ExpStrictFP = true; + } Delete redundant braces ===

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added a comment. In D82436#2142631 , @kbobyrev wrote: > In D82436#2141953 , @sammccall wrote: > > > Tests :-) > > > I was hoping glorious DocumentSymbols super tested API would shield me from > that :P

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. I tested locally the standalone build of Clang with D83426 . I just want to make sure that we all agree this is right way moving forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 276844. amyk added a comment. Address review comments - update comments - pull out common code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500 Files: clang/include/clan

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk marked 3 inline comments as done. amyk added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14273 +// The third argument to vec_replace_elt will be emitted to either +// the vinsw or vinsd instruction. It must be a compile time constant. +ConstantIn

[PATCH] D83513: [AST][ObjC] Fix crash when printing invalid objc categories

dgoldman created this revision. dgoldman added reviewers: sammccall, gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. If no valid interface definition was found previously we would crash. With this change instead we just print `<>` in place of the NULL interface.

[PATCH] D83511: [clangd] Config: If.PathExclude

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83511 Files: clang-tools-e

[PATCH] D83509: CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

ojhunt updated this revision to Diff 276837. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83509/new/ https://reviews.llvm.org/D83509 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Frontend/SerializedDiagnosticPrinter.cpp

[PATCH] D83509: CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:123 +def warn_fe_serialized_diag_failure_during_finalisation : Warning< +"Received warning after diagnostic

[PATCH] D83509: CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

ojhunt created this revision. ojhunt added a reviewer: jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Add a guard for re-entering an SDiagsWriter's HandleDiagnostics method after we've started finalizing. This is a generic catch all for unexpected fatal erro

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch fixes redundant hover with information about Decl which is not under cursor. Repository: rG LLVM Github Monorepo ht

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

nlopes added a subscriber: tgt. nlopes added a comment. In D83360#2142457 , @efriedma wrote: > > that's fine but I still don't understand why the counterexample to my > > version says %x2 in @src can be undef > > If I'm understanding correctly, this reduc

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu marked 5 inline comments as done. zequanwu added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/CGProfile.cpp:64 // Ignore error here. Indirect calls are ignored if this fails. - (void)(bool)Symtab.create(M); + (void)(bool) Symtab.create(M); fo

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 276834. zequanwu added a comment. Add comments and fix test failure in http://45.33.8.238/linux/22500/step_7.txt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev marked an inline comment as done. kbobyrev added a comment. In D82436#2141953 , @sammccall wrote: > Tests :-) I was hoping glorious DocumentSymbols super tested API would shield me from that :P Didn't think of reasonable testing strategy but fa

[PATCH] D83502: Change behavior with zero-sized static array extents

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2515 +} else { + AI->addAttr(llvm::Attribute::NonNull); +} Isn't the old logic still correct? If the element size is static and the element

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

rjmccall added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10068 +isa(D) && cast(D)->isFileVarDecl() && +cast(D)->getStorageClass() == SC_Static) { + return GVA_StrongExternal; JonChesterfield wrote: > yaxunl wrote: > > rjmccall

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:83 +return PD->getDefinition(); + // Objective-C classes can have three types of declarations: + // This is a really useful comment,

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

rjmccall added a comment. This seems fine. I do wonder if the "real" bug is that this ought to be handled properly in EmitReturnFromThunk, but regardless, the fix seems acceptable. Is there a similar bug with trivial_abi? Should we have a test case for that? Repository: rG LLVM Github Mon

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. Seems like the general approach we want. Could you: - Fix the lint warnings - Find out why the unit tests failed - Add strcmp - Modify the memcmp/strcmp unit tests to show that we can solve them with/without ASan After that I'll take a closer look. Repository: rG

[PATCH] D83426: Unbreak Clang standalone build.

michele.scandale added a comment. Thanks. Would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83426/new/ https://reviews.llvm.org/D83426 ___ cfe-commits mailing

[clang] c025bdf - Revert D83013 "[LPM] Port CGProfilePass from NPM to LPM"

Author: Fangrui Song Date: 2020-07-09T13:34:04-07:00 New Revision: c025bdf25a59a79d60a2e99962c8653547a825d8 URL: https://github.com/llvm/llvm-project/commit/c025bdf25a59a79d60a2e99962c8653547a825d8 DIFF: https://github.com/llvm/llvm-project/commit/c025bdf25a59a79d60a2e99962c8653547a825d8.diff

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

Conanap marked an inline comment as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:939 + // The XFormMemOp flag for the following 8 insts is set on the instruction format. + let mayLoad = 1, mayStore = 1 in { +def LXVRBX : X_XT6_

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

lebedev.ri added a comment. This seems to have broken the build http://45.33.8.238/linux/22500/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 ___ cf

[clang] 53e38c8 - [CMake][Fuchsia] Support for building with MSVC

Author: Petr Hosek Date: 2020-07-09T13:07:12-07:00 New Revision: 53e38c85a8a6cdcf7776b936d72fb94ec737dc84 URL: https://github.com/llvm/llvm-project/commit/53e38c85a8a6cdcf7776b936d72fb94ec737dc84 DIFF: https://github.com/llvm/llvm-project/commit/53e38c85a8a6cdcf7776b936d72fb94ec737dc84.diff LO

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG53e38c85a8a6: [CMake][Fuchsia] Support for building with MSVC (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D73810?vs=241822&id=276815#toc Repository: rG LLVM Github Monorep

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added a comment. Some inline nits. I see you've already committed and that's fine - I still don't think we should do it, but we can delete it again soon :) Comment at: clang/lib/CodeGen/BackendUtil.cpp:623 PMBuilder.LoopVectorize = CodeGenOpts.VectorizeLoop; + PMB

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

efriedma added a subscriber: tgt. efriedma added a comment. > that's fine but I still don't understand why the counterexample to my version > says %x2 in @src can be undef If I'm understanding correctly, this reduces to something like the following: define i32 @src() { %x2 = freeze i32 undef

[clang] c92a8c0 - [LPM] Port CGProfilePass from NPM to LPM

Author: Zequan Wu Date: 2020-07-09T13:03:42-07:00 New Revision: c92a8c0a0f68fbbb23e3fdde071007e63a552e82 URL: https://github.com/llvm/llvm-project/commit/c92a8c0a0f68fbbb23e3fdde071007e63a552e82 DIFF: https://github.com/llvm/llvm-project/commit/c92a8c0a0f68fbbb23e3fdde071007e63a552e82.diff LOG

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc92a8c0a0f68: [LPM] Port CGProfilePass from NPM to LPM (authored by zequanwu). Repository: rG LLVM Github Monorepo CHA

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 276813. zequanwu added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/include/clang/Basic/CodeGenOptions.def clang/lib/CodeGen/Bac

[PATCH] D83502: Change behavior with zero-sized static array extents

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, echristo, dblaikie, rjmccall. Currently, Clang diagnoses this code by default: `void f(int a[static 0]);` saying that "static has no effect on zero-length arrays" and this diagnostic is accurate for our implementation.

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

JDevlieghere added a comment. LGTM. I verified this works for the build-tree standalone build of LLDB, but please still keep an eye on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ after you land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

rjmccall added a comment. Either way, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

rjmccall added a comment. Would it be sensible to use a technical design more like what the matrix folks are doing, where LLVM provides a small interface for emitting operations with various semantics? FixedPointSemantics would move to that header, and Clang would just call into it. That way

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

lei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14273 +// The third argument to vec_replace_elt will be emitted to either +// the vinsw or vinsd instruction. It must be a compile time constant. +ConstantInt *ArgCI = dyn_cast(Ops[2]); ---

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 276808. zequanwu added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/include/clang/Basic/CodeGenOptions.def clang/lib/C

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:276 getDeclAtPosition(AST, CurLoc, Relations, NodeKind)) { // Special case: void foo() ^override: jump to the overridden method. if (const auto *CMD = llvm::dyn_cast(D)) { ---

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3857 + + // TODO: This misses out on the sanitizer check below. + if (Ops.isFixedPointOp()) I don't suppose you could file a bug for this and CC me on it so we can remember to do

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 276804. amyk added a comment. Updated for clang format changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/CodeGen/CGBuiltin.cpp clang/lib/H

[clang] 25ec96d - [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

Author: David Tenty Date: 2020-07-09T15:15:30-04:00 New Revision: 25ec96d91a3a5326a403496fa5532ff0bdb6a15b URL: https://github.com/llvm/llvm-project/commit/25ec96d91a3a5326a403496fa5532ff0bdb6a15b DIFF: https://github.com/llvm/llvm-project/commit/25ec96d91a3a5326a403496fa5532ff0bdb6a15b.diff L

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ec96d91a3a: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D82476?vs=273071&id=276803#toc Repository: rG

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

bsaleil added a comment. Shouldn't we have test cases to test `vec_sl`, `vec_sr` and `vec_sra` ? Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:800 def int_ppc_altivec_vsrw : PowerPC_Vec_WWW_Intrinsic<"vsrw">; +def int_ppc_altivec_vsrq : PowerPC_Vec_QQQ_Intrinsic<"vs

[clang] e81f9cd - [AST][test] Add regression test forPointerExprEvaluator::VisitCXXNewExpr

Author: Jan Korous Date: 2020-07-09T12:11:08-07:00 New Revision: e81f9cd2137f258fd1ec6a169db836387bcca84a URL: https://github.com/llvm/llvm-project/commit/e81f9cd2137f258fd1ec6a169db836387bcca84a DIFF: https://github.com/llvm/llvm-project/commit/e81f9cd2137f258fd1ec6a169db836387bcca84a.diff LO

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

leonardchan added a comment. > It wouldn't just be restricted to fixed-point intrinsics, though. It would > have to be added to intrinsics like uadd.sat and usub.sat as well, which > aren't really tied to fixed-point at all. Oh wait, sorry. I think I'm starting to understand now. You're saying

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

hans accepted this revision. hans added a comment. In D83013#2142271 , @nikic wrote: > New compile-time numbers: > https://llvm-compile-time-tracker.com/compare.php?from=0b39d2d75275b80994dac06b7ad05031cbd09393&to=fd070b79e063fff2fad3cd4a467f64dfca83eb90&

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

bsaleil added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:939 + // The XFormMemOp flag for the following 8 insts is set on the instruction format. + let mayLoad = 1, mayStore = 1 in { +def LXVRBX : X_XT6_RA5_RB5<31, 13, "lxvrbx", vsrc, []>; -

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk marked 2 inline comments as done. amyk added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:339 +BUILTIN(__builtin_altivec_vec_replace_elt, "V4UiV4UiULLiIi", "t") +BUILTIN(__builtin_altivec_vec_replace_unaligned, "V4UiV4UiULLiIi", "t") -

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:88-92 + if (const auto *ID = dyn_cast(D)) { +if (const auto *IMD = ID->getImplementation()) + return IMD; +return ID->getDefinition(); + } Let me know if there's a bette

  1   2   3   >