[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur updated this revision to Diff 234663. Meinersbur added a comment. - Adapt for refactored ASTRecordReader/Writer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70572/new/ https://reviews.llvm.org/D70572 Files: clang/include/clang/Serial

[PATCH] D69091: [Sema] #pragma clang transform

Meinersbur updated this revision to Diff 234659. Meinersbur added a comment. - Rework TransformedTree a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69091/new/ https://reviews.llvm.org/D69091 Files: clang/include/clang/AST/ASTNodeTraverser.

[PATCH] D71541: [NFC] [Clang]: fix spelling mistake in assert message

Jim added a comment. Do you need someone to commit this change for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71541/new/ https://reviews.llvm.org/D71541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void updated this revision to Diff 234657. void added a comment. Check that the use isn't in the fallthrough block. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedV

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61011 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61011 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo created this revision. echristo added reviewers: chandlerc, hfinkel, asbirlea. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. echristo updated this revision to Diff 234656. echristo added a comment. Formatting and parens chang

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 234656. echristo added a comment. Formatting and parens changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c llvm/lib/P

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:127 + +// Ignore this instance, because this matches an +// expanded class e

[PATCH] D71686: Fix false positive in magic number checker

0x8000- created this revision. 0x8000- added a reviewer: aaron.ballman. 0x8000- added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix false positive in magic number checker https://bugs.llvm.org/show_bug.cgi?id=40640: cppcoregu

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234650. skan added a comment. move the code that checks if we can reuse the current `MCBoundaryAlignFragment` into the function `X86AsmBackend::getOrCreateBoundaryAlignFragment` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234652. kamleshbhalui added a comment. added assert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files: clang/lib/Sema/SemaDecl.cpp clang/test/AST/pr43983.cpp Index: clang/test/AST/pr43983.cp

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ added a comment. In D70836#1789059 , @xazax.hun wrote: > Will this also work as intended with sugared types? (e.g. typedefs) > I believe this might be one of the main reason why the original author used > canonical types in the first place. Whoops

[clang] f0ced2d - [analysis] Re-discard type sugar when casting values retrieved from the Store.

Author: Artem Dergachev Date: 2019-12-18T18:00:57-08:00 New Revision: f0ced2ddb44e4bd970fec310591891a0cdb4462c URL: https://github.com/llvm/llvm-project/commit/f0ced2ddb44e4bd970fec310591891a0cdb4462c DIFF: https://github.com/llvm/llvm-project/commit/f0ced2ddb44e4bd970fec310591891a0cdb4462c.dif

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

andrew.w.kaylor added a comment. In D71635#1790611 , @MaskRay wrote: > Before: > > % clang -frounding-math -fsyntax-only -x c /dev/null > clang-10: warning: Support for floating point control option frounding-math > is incomplete and experimental [-We

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

rupprecht abandoned this revision. rupprecht added a comment. In D71635#1790611 , @MaskRay wrote: > Before: > > % clang -frounding-math -fsyntax-only -x c /dev/null > clang-10: warning: Support for floating point control option frounding-math > is inc

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

MadCoder created this revision. MadCoder added reviewers: rjmccall, arphaman, erik.pilkington, ahatanak. MadCoder added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. MadCoder edited the summary of this revision. Today the optimization is limited to: - `[ClassName alloc]` -

[PATCH] D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg.

MaskRay added a comment. Before: % clang -frounding-math -fsyntax-only -x c /dev/null clang-10: warning: Support for floating point control option frounding-math is incomplete and experimental [-Wexperimental-float-control] CC1 will do rounding math things. After % clang -frounding-math

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

This revision was automatically updated to reflect the committed changes. Closed by commit rG553a727f5f64: [clang] Remove -Wexperimental-float-control. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71671/new/ https://reviews

[clang] 553a727 - [clang] Remove -Wexperimental-float-control.

Author: Jordan Rupprecht Date: 2019-12-18T16:51:55-08:00 New Revision: 553a727f5f6407fb6db7ac2dae5f5b2a536d38fc URL: https://github.com/llvm/llvm-project/commit/553a727f5f6407fb6db7ac2dae5f5b2a536d38fc DIFF: https://github.com/llvm/llvm-project/commit/553a727f5f6407fb6db7ac2dae5f5b2a536d38fc.di

[clang] 07b8f8e - [Remarks][Driver] Place temporary remark files next to temporary object files

Author: Francis Visoiu Mistrih Date: 2019-12-18T16:42:02-08:00 New Revision: 07b8f8e5f5cad9c4d92c39a4bea50e21e9f0e9f1 URL: https://github.com/llvm/llvm-project/commit/07b8f8e5f5cad9c4d92c39a4bea50e21e9f0e9f1 DIFF: https://github.com/llvm/llvm-project/commit/07b8f8e5f5cad9c4d92c39a4bea50e21e9f0e

[clang] f550961 - [Docs] Fix indentation in remarks section

Author: Francis Visoiu Mistrih Date: 2019-12-18T16:41:52-08:00 New Revision: f550961c6e833cb828416f1bdee904f4aadbf37d URL: https://github.com/llvm/llvm-project/commit/f550961c6e833cb828416f1bdee904f4aadbf37d DIFF: https://github.com/llvm/llvm-project/commit/f550961c6e833cb828416f1bdee904f4aadbf

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

steveire updated this revision to Diff 234636. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71680/new/ https://reviews.llvm.org/D71680 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/ASTMatchers/AS

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

steveire updated this revision to Diff 234635. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71680/new/ https://reviews.llvm.org/D71680 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/ASTMatchers/AS

[PATCH] D71648: [WebAssembly] Add avgr_u intrinsics and require nuw in patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rG71eb8023d85e: [WebAssembly] Add avgr_u intrinsics and require nuw in patterns (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71648/new/

[clang] 71eb802 - [WebAssembly] Add avgr_u intrinsics and require nuw in patterns

Author: Thomas Lively Date: 2019-12-18T15:31:38-08:00 New Revision: 71eb8023d85e5201d32ea24194ec5bc07db23527 URL: https://github.com/llvm/llvm-project/commit/71eb8023d85e5201d32ea24194ec5bc07db23527 DIFF: https://github.com/llvm/llvm-project/commit/71eb8023d85e5201d32ea24194ec5bc07db23527.diff

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang] 12038be - [Concepts] Fix crash in D41910

I've temporarily reverted the D41910 patchset in order to get the lldb bot unstuck (5094e6dad64). vedant > On Dec 18, 2019, at 1:34 PM, Vedant Kumar wrote: > > Hey Saar, > Do you expect this to address this crash seen on the lldb bot after D41910 > landed? > > Assertion failed: (Idx < size()

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234627. riccibruno added a comment. Add missing patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71680 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/ASTMatchers/ASTMa

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor added a comment. In D71677#1790458 , @rnk wrote: > Where is {0:P} actually documented? I don't see it in LangRef, but I do see > it in the code. https://llvm.org/docs/LangRef.html#asm-template-argument-modifiers, under X86; specifically documen

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && ghvg1313 wrote: > MyDeveloperDay wrote: > > I'm

[PATCH] D70613: Add method to ignore invisible AST nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rG98e8f774eb6c: Add method to ignore invisible AST nodes (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D70613?vs=233183&id=234623#toc Repository: rG LLVM Github Monorepo

[PATCH] D71675: [Remarks][Driver] Run dsymutil when remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGd79b11fefb8e: [Remarks][Driver] Run dsymutil when remarks are enabled (authored by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71675/new/ https

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Basic/FileManager.cpp:551 StringRef FileManager::getCanonicalName(const DirectoryEntry *Dir) { // FIXME: use llvm::sys::fs::canonical() when it gets

[clang] a9f597b - Output names in the AST in tests

Author: Stephen Kelly Date: 2019-12-18T22:33:23Z New Revision: a9f597b62ebdb670392fec2d5a5154e43b6398aa URL: https://github.com/llvm/llvm-project/commit/a9f597b62ebdb670392fec2d5a5154e43b6398aa DIFF: https://github.com/llvm/llvm-project/commit/a9f597b62ebdb670392fec2d5a5154e43b6398aa.diff LOG:

[clang] 84fd2be - Trim trailing whitespace

Author: Stephen Kelly Date: 2019-12-18T22:33:23Z New Revision: 84fd2bedf4096e78b892165138051b8563169fe3 URL: https://github.com/llvm/llvm-project/commit/84fd2bedf4096e78b892165138051b8563169fe3 DIFF: https://github.com/llvm/llvm-project/commit/84fd2bedf4096e78b892165138051b8563169fe3.diff LOG:

[clang] a8c678c - [Remarks][Driver][NFC] Make shouldEmitRemarks more available in the Driver

Author: Francis Visoiu Mistrih Date: 2019-12-18T14:31:41-08:00 New Revision: a8c678cb9a90c4f82505f573e9b9fa23fec93a64 URL: https://github.com/llvm/llvm-project/commit/a8c678cb9a90c4f82505f573e9b9fa23fec93a64 DIFF: https://github.com/llvm/llvm-project/commit/a8c678cb9a90c4f82505f573e9b9fa23fec93

[clang] d79b11f - [Remarks][Driver] Run dsymutil when remarks are enabled

Author: Francis Visoiu Mistrih Date: 2019-12-18T14:31:41-08:00 New Revision: d79b11fefb8e92660893b8ccf9e21d23668a6c73 URL: https://github.com/llvm/llvm-project/commit/d79b11fefb8e92660893b8ccf9e21d23668a6c73 DIFF: https://github.com/llvm/llvm-project/commit/d79b11fefb8e92660893b8ccf9e21d23668a6

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 234621. ghvg1313 added a comment. - Handle parameter break between blocks - Fix test cases and move them to objcTest - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

rnk added a comment. Where is {0:P} actually documented? I don't see it in LangRef, but I do see it in the code. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2871 + // differently when referenced in MS-style inline assembly. + if (Name.startswith("call") || Nam

[clang] bce1cce - [analyzer] Teach MismatchedDealloc about initWithBytesNoCopy with deallocator.

Author: Artem Dergachev Date: 2019-12-18T14:19:17-08:00 New Revision: bce1cce6bf1286541c57690ab1129fbc02c60f93 URL: https://github.com/llvm/llvm-project/commit/bce1cce6bf1286541c57690ab1129fbc02c60f93 DIFF: https://github.com/llvm/llvm-project/commit/bce1cce6bf1286541c57690ab1129fbc02c60f93.dif

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60853 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka updated this revision to Diff 234617. vvereschaka edited the summary of this revision. vvereschaka added a comment. Renamed configuration arguments to REMOTE_TEST_HOST and REMOTE_TEST_USER Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik updated this revision to Diff 234619. shafik marked 3 inline comments as done. shafik added a comment. - Fix typo - Adjust error handing - clang-format test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 Files: clang/lib/AST/ASTImporte

[clang] 3ced239 - Refactor CompareReferenceRelationship and its callers in preparation for

Author: Richard Smith Date: 2019-12-18T14:05:57-08:00 New Revision: 3ced23976aa8a86a17017c87821c873b4ca80bc2 URL: https://github.com/llvm/llvm-project/commit/3ced23976aa8a86a17017c87821c873b4ca80bc2 DIFF: https://github.com/llvm/llvm-project/commit/3ced23976aa8a86a17017c87821c873b4ca80bc2.diff

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. > But in RISCV clang emits the same IR for different ABI (-mabi), This is not true. For simple cases, it does, yes, but there are some weird edge cases for functions with many arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] a6d57a8 - Use hasOffsetApplied to initialize member HasOffsetApplied

Author: Akira Hatanaka Date: 2019-12-18T13:56:59-08:00 New Revision: a6d57a8cd4cfa2a8395eaa6599fc12f7509f98f0 URL: https://github.com/llvm/llvm-project/commit/a6d57a8cd4cfa2a8395eaa6599fc12f7509f98f0 DIFF: https://github.com/llvm/llvm-project/commit/a6d57a8cd4cfa2a8395eaa6599fc12f7509f98f0.diff

[PATCH] D71427: Move TypeSourceInfo to Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG71f9c30b5348: Move TypeSourceInfo to Type.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71427/new/ https://reviews.llvm.org/D71427 Fil

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Pushing code review approval button. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71650/new/ https://reviews.llvm.org/D71650 _

[PATCH] D71677: Summary:Use "P" modifier on operands to call instructions in inline X86 assembly.

epastor created this revision. epastor added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is documented as the appropriate template modifier for call operands. Fixes PR44272, and adds a regression test. Also adds support

[clang] 71f9c30 - Move TypeSourceInfo to Type.h

Author: Reid Kleckner Date: 2019-12-18T13:47:00-08:00 New Revision: 71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a URL: https://github.com/llvm/llvm-project/commit/71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a DIFF: https://github.com/llvm/llvm-project/commit/71f9c30b5348bbb2b41d4ffa6c7688dec8e0074a.diff

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

mstorsjo added a comment. Ok, so if you're in agreement on this one, can either of you give the stamp of approval? :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71650/new/ https://reviews.llvm.org/D71650

[PATCH] D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

Re: [clang] 12038be - [Concepts] Fix crash in D41910

Hey Saar, Do you expect this to address this crash seen on the lldb bot after D41910 landed? Assertion failed: (Idx < size() && "Out-of-bounds Bit access."), function operator[], file /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h, line 452.

[PATCH] D71675: [Remarks][Driver] Run dsymutil when remarks are enabled

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71675/new/ https://reviews.llvm.org/D71675 ___ cf

[PATCH] D71675: [Remarks][Driver] Run dsymutil when remarks are enabled

JDevlieghere added inline comments. Comment at: clang/test/Driver/darwin-opt-record.c:21 +// -gline-tables-only and would need -fno-save-optimization-record to +// completely disable it. +// CHECK-DSYMUTIL-G0: "-cc1" thegameg wrote: > The other choice would be ho

[PATCH] D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG I think this is correct solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71674/new/ https://reviews.llvm.org/D71674 __

[PATCH] D71675: [Remarks][Driver] Run dsymutil when remarks are enabled

thegameg marked an inline comment as done. thegameg added inline comments. Comment at: clang/test/Driver/darwin-opt-record.c:21 +// -gline-tables-only and would need -fno-save-optimization-record to +// completely disable it. +// CHECK-DSYMUTIL-G0: "-cc1" The oth

[PATCH] D71675: [Remarks][Driver] Run dsymutil when remarks are enabled

thegameg created this revision. thegameg added reviewers: friss, JDevlieghere, aprantl. thegameg added projects: clang, debug-info. When clang is invoked with a source file without -c or -S, it creates a cc1 job, a linker job and if debug info is requested, a dsymutil job. In case of remarks, we

[PATCH] D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP

mgorny created this revision. mgorny added reviewers: baloghadamsoftware, jdoerfert, ABataev. Herald added subscribers: lebedev.ri, guansong, rnkovacs. Herald added a reviewer: lebedev.ri. Use LLVM_LINK_COMPONENTS to link the FrontendOpenMP library instead of passing it explicitly to LINK_LIBS. T

[clang] e3fa460 - Change triple in test case to not include triples the test shouldn't

Author: Amy Huang Date: 2019-12-18T13:17:39-08:00 New Revision: e3fa4604076d01d2fe48d44d86fc2d6a48d4970c URL: https://github.com/llvm/llvm-project/commit/e3fa4604076d01d2fe48d44d86fc2d6a48d4970c DIFF: https://github.com/llvm/llvm-project/commit/e3fa4604076d01d2fe48d44d86fc2d6a48d4970c.diff LOG

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5037 Anon = VarDecl::Create(Context, Owner, DS.getBeginLoc(), Record->getLocation(), /*IdentifierInfo=*/nullptr, Should we apply the attributes to the variabl

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk planned changes to this revision. rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:653 template DynTypedNodeList getParents(const NodeT &Node) { return getParents(ast_type_traits::DynTypedNode::create(N

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

phosek added a comment. This seems to be failing on aarch64-linux-gnu: TEST 'Clang :: CodeGenCXX/mangle-ptr-size-address-space.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/clang -cc1 -in

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

steven_wu added a comment. Commited in: 9366397f057d18401e680b2cb28a0ee17c59d4a6 Phabriactor might not update this because the patch was created on libunwind repo, not the monorepo. Repository: rUNW libunwind CHANGES SIN

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1790211 , @rupprecht wrote: > In D62731#1789122 , @rupprecht wrote: > > > In D62731#1788902 , > > @andrew.w.kaylor wrote: > > > > > In D62

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60990 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

This revision was automatically updated to reflect the committed changes. Closed by commit rG9366397f057d (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 Files: libunwind/src/DwarfI

[libunwind] 9366397 - [libunwind] Fix evaluating DWARF operation DW_OP_pick

Author: Steven Wu Date: 2019-12-18T12:22:21-08:00 New Revision: 9366397f057d18401e680b2cb28a0ee17c59d4a6 URL: https://github.com/llvm/llvm-project/commit/9366397f057d18401e680b2cb28a0ee17c59d4a6 DIFF: https://github.com/llvm/llvm-project/commit/9366397f057d18401e680b2cb28a0ee17c59d4a6.diff LOG

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

mibintc added a comment. thanks for taking care of this. looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71671/new/ https://reviews.llvm.org/D71671 ___ cfe-commits mailing list cfe-commi

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added a comment. In D62731#1789122 , @rupprecht wrote: > In D62731#1788902 , @andrew.w.kaylor > wrote: > > > In D62731#1788838 , @rupprecht > > wrote: > > > > > I

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

steven_wu accepted this revision. steven_wu added a comment. In D69893#1786222 , @kamleshbhalui wrote: > In D69893#1786202 , @steven_wu wrote: > > > The fix LGTM. Do you have a reproducer that can be used as a test

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

rupprecht created this revision. rupprecht added reviewers: mibintc, chandlerc, echristo, rjmccall, kpn, erichkeane, rsmith, andrew.w.kaylor. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per D62731 , the behavior of clang with `-froundin

[clang] badba51 - [analyzer] NonnullGlobalConstants: Add support for kCFNull.

Author: Artem Dergachev Date: 2019-12-18T12:08:15-08:00 New Revision: badba5118ff5cc6d61aeca6ee2dc2ead5bb5286f URL: https://github.com/llvm/llvm-project/commit/badba5118ff5cc6d61aeca6ee2dc2ead5bb5286f DIFF: https://github.com/llvm/llvm-project/commit/badba5118ff5cc6d61aeca6ee2dc2ead5bb5286f.dif

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

tra added a comment. In D69990#1790154 , @6yearold wrote: > > It's somewhat old and misses few glue functions needed by CUDA-10, but it > > should work well enough for CUDA-9. > > Interesting, thanks for sharing. However, at quick look, it seems to requir

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

rjmccall added a comment. We do have a static assert. I won't insist on the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71650/new/ https://reviews.llvm.org/D71650 ___ cfe-commits mailing li

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

6yearold added a comment. In D69990#1790047 , @tra wrote: > > ... I'm curious if it's particularly useful. Last time I checked NVIDIA > > didn't ship libcudart for FreeBSD and without it it's rather cumbersome to > > use CUDA in practice. > > FYI, I've j

[PATCH] D70701: Fix more VFS tests on Windows

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rG738b5c9639b4: Fix more VFS tests on Windows (authored by amccarth). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D70701?vs=

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[clang] 11d5fa6 - [Concepts] Fix incorrect move out of temporary in D41910

Author: Saar Raz Date: 2019-12-18T21:43:53+02:00 New Revision: 11d5fa6e87e3584f72056ecc2b17f88c58323dde URL: https://github.com/llvm/llvm-project/commit/11d5fa6e87e3584f72056ecc2b17f88c58323dde DIFF: https://github.com/llvm/llvm-project/commit/11d5fa6e87e3584f72056ecc2b17f88c58323dde.diff LOG:

[clang] 738b5c9 - Fix more VFS tests on Windows

Author: Adrian McCarthy Date: 2019-12-18T11:38:04-08:00 New Revision: 738b5c9639b4323f75b03e21494bef13d9adfa86 URL: https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86 DIFF: https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86.dif

[clang] 9d38fd8 - [NFC] Update FIXME for one VFS test

Author: Adrian McCarthy Date: 2019-12-18T11:38:04-08:00 New Revision: 9d38fd8d0be3074af036e9e3e36489f5b854faf4 URL: https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4 DIFF: https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4.dif

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

This revision was automatically updated to reflect the committed changes. Closed by commit rG12038be20ee6: [Concepts] Fix crash in D41910 (authored by saar.raz). Changed prior to commit: https://reviews.llvm.org/D41910?vs=232457&id=234587#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 12038be - [Concepts] Fix crash in D41910

Author: Saar Raz Date: 2019-12-18T21:31:33+02:00 New Revision: 12038be20ee6a903cdbd3fddce65535ef683e31d URL: https://github.com/llvm/llvm-project/commit/12038be20ee6a903cdbd3fddce65535ef683e31d DIFF: https://github.com/llvm/llvm-project/commit/12038be20ee6a903cdbd3fddce65535ef683e31d.diff LOG:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

rnk added a comment. I agree, in this case I think the comment will just be extra noise. The comment is likely to outlive the use of these buggy GCC versions. If someone runs into this bug again, it will probably happen somewhere else far away from this code, and the comment isn't going to help

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

thakis added a comment. This makes clang crash when running tests: http://45.33.8.238/linux/5976/step_7.txt Please use "Differential Revision: https://reviews.llvm.org/D41910"; instead of "Phabricator: D41910 " so that phab auto-closes the review and other auto

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

jonpa closed this revision. jonpa added a comment. ca52059 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71669/new/ https://reviews.llvm.org/D71669 ___ cfe-commits mailin

[clang] ca52059 - [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

Author: Jonas Paulsson Date: 2019-12-18T11:04:13-08:00 New Revision: ca520592c081a76b45613ec794ebee4920933c1c URL: https://github.com/llvm/llvm-project/commit/ca520592c081a76b45613ec794ebee4920933c1c DIFF: https://github.com/llvm/llvm-project/commit/ca520592c081a76b45613ec794ebee4920933c1c.diff

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

rjmccall added a comment. In D71650#1790067 , @mstorsjo wrote: > In D71650#1789897 , @rjmccall wrote: > > > Wow, that's novel. Please add a comment explaining that this is a compiler > > workaround, but otherwise

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

mstorsjo added a comment. In D71650#1789897 , @rjmccall wrote: > Wow, that's novel. Please add a comment explaining that this is a compiler > workaround, but otherwise LGTM. The post-patch form doesn't look that odd to me (and we wouldn't want one com

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71669/new/ https://reviews.llvm.org/D71669 ___ cfe-commits mailing list cfe-comm

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

tra added a comment. > ... I'm curious if it's particularly useful. Last time I checked NVIDIA > didn't ship libcudart for FreeBSD and without it it's rather cumbersome to > use CUDA in practice. FYI, I've just got our internal proof-of-concept runtime support library which may get CUDA apps r

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa85f5efd9597: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71039/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

  1   2   >