rupprecht abandoned this revision. rupprecht added a comment. In D71635#1790611 <https://reviews.llvm.org/D71635#1790611>, @MaskRay wrote:
> Before: > > % clang -frounding-math -fsyntax-only -x c /dev/null > clang-10: warning: Support for floating point control option frounding-math > is incomplete and experimental [-Wexperimental-float-control] > > > CC1 will do rounding math things. > > After > > % clang -frounding-math -fsyntax-only -x c /dev/null > clang-10: warning: optimization flag '-frounding-math' is not supported > [-Wignored-optimization-argument] > > > CC1 will not do rounding math things. -fexperimental-rounding-math if the > user really wants to use the feature. > > Is my understanding correct? If yes, this patch seems pretty reasonable to > me, because -frounding-math is currently incomplete/unsafe. > > You may consider not changing CC1 options as they are not user facing. I landed D71671 <https://reviews.llvm.org/D71671> instead, as apparently the -frounding-math option is safe, although perhaps incomplete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71635/new/ https://reviews.llvm.org/D71635 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
