rnk added a comment. I agree, in this case I think the comment will just be extra noise. The comment is likely to outlive the use of these buggy GCC versions. If someone runs into this bug again, it will probably happen somewhere else far away from this code, and the comment isn't going to help them avoid it.
I feel similarly about some MSVC workaround comments. The one that comes to mind is the fact that MSVC always gives unfixed enums the underlying type of `int`. We shouldn't sprinkle comments about this everywhere, we should document it once well in CodingStandards or something. In this case, I'm not sure we even need that. It seems like something better caught by a static assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71650/new/ https://reviews.llvm.org/D71650 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
