rupprecht added a comment. In D62731#1789122 <https://reviews.llvm.org/D62731#1789122>, @rupprecht wrote:
> In D62731#1788902 <https://reviews.llvm.org/D62731#1788902>, @andrew.w.kaylor > wrote: > > > In D62731#1788838 <https://reviews.llvm.org/D62731#1788838>, @rupprecht > > wrote: > > > > > It seems the discussion of whether or not this is incomplete died out -- > > > I'd prefer to assume it is incomplete if there is no consensus. Mailed > > > D71635 <https://reviews.llvm.org/D71635> to rename `-frounding-math` to > > > `-fexperimental-rounding-math`. > > > > > > Alternatively we could remove the warning. I still don't see a good > > > argument for the middle ground of having it called `-frounding-math` but > > > also generate a warning. > > > > > > It's definitely incomplete but the results will not be any worse than you > > get when -frounding-math is ignored. > > > > My preference would be to change the text of the warning that is issued but > > allow -frounding-math to be enabled by this commit without requiring an > > additional option. > > > If other reviewers agree, then let's just remove the warning. I can send a > patch tomorrow unless someone else wants to do that. Mailed D71671 <https://reviews.llvm.org/D71671> to do this. If neither patch is acceptable, then I would like to revert this commit instead, as we are having issues with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
