[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

steven_wu added a comment. In D69327#1719411 , @ychen wrote: > Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points > you brought up. One last thing I'm not quite sure is the caching of > `-fthin-link-bitcode`. It is a `-cc1` option

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > I think this line is the issue: where someone doesn't specify `-march`, y

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points you brought up. One last thing I'm not quite sure is the caching of `-fthin-link-bitcode`. It is a `-cc1` option since it is a kind of implementation of ThinLTO, right? I'm a little hesitant to beg

[PATCH] D69363: [www] Change URLs to HTTPS.

zoecarver added a comment. Thanks for updating all these links! LGTM :) Comment at: clang/www/cxx_status.html:78 Rvalue references - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n2118.html";>N2118 + https://wg21.link/n2118";>N2118 Clang 2.9 --

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT marked an inline comment as done. STL_MSFT added inline comments. Comment at: clang/www/cxx_status.html:78 Rvalue references - http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n2118.html";>N2118 + https://wg21.link/n2118";>N2118 Clang 2.9 -

[PATCH] D69363: [www] Change URLs to HTTPS.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Nice! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69363/new/ https://reviews.llvm.org/D69363 ___ cfe-commits

[PATCH] D69363: [www] Change URLs to HTTPS.

zoecarver added a comment. GitHub PRs can't come soon enough :) There was a round table meeting about that earlier today which I am anxious to hear about. Comment at: clang/www/cxx_status.html:78 Rvalue references - http://www.open-std.org/jtc1/sc22/wg21/docs/paper

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, ldionne, mclow.lists, zoecarver. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, arphaman, dexonsmith, christof. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This changes most URLs

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > vhscampos wrote: > > > compnerd wrote: > > > > I don't see

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1499b90dc4: Improve Clang's getting involved document and make it more inclusive in wording. (authored by chandlerc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] dc1499b - Improve Clang's getting involved document and make it more inclusive in wording.

Author: Chandler Carruth Date: 2019-10-23T16:11:24-07:00 New Revision: dc1499b90dc41838e1ee8c7052bbe9535b3609bb URL: https://github.com/llvm/llvm-project/commit/dc1499b90dc41838e1ee8c7052bbe9535b3609bb DIFF: https://github.com/llvm/llvm-project/commit/dc1499b90dc41838e1ee8c7052bbe9535b3609bb.di

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. this patch refactor representation of materialized temporaries to prevent an issue raised

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9635 +if (IsExpr) { + Base = APValue::LValueBase(ReadExpr(F), CallIndex, Version); + ElemTy = Base.get()->getType(); T

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

tejohnson added a comment. In D69327#1719295 , @tejohnson wrote: > I was just typing up a response similar to @steven_wu 's response... I don't > think clang should be in the business of caching the outputs of a prior clang > invocation, the build system

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

tejohnson added a comment. I was just typing up a response similar to @steven_wu 's response... I don't think clang should be in the business of caching the outputs of a prior clang invocation, the build system should and usually does avoid re-executing if the inputs have not changed. Note that

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

steven_wu added a comment. Can you clarify what do you mean by 'waste time optimizing a file that finally hit the object file cache'? No matter what build system to use, it should figure out during an incremental build that the input wasn't changed and not rerun the clang invocation on the sam

[PATCH] D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal.

CodaFi added a comment. @MaskRay I have a refactoring in https://reviews.llvm.org/D59425 that covers that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51899/new/ https://reviews.llvm.org/D51899 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. Yes, that's the point, since 8548 is an alias. A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I discovered that this patch was not committed anyhow at all: https://reviews.llvm.org/D54583#1444288 Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. In D69327#1719109 , @tejohnson wrote: > I haven't read through the patch in detail yet, but from the description it > sounds like a cache is being added for the compile step outputs, e.g. the > bitcode output object of the "clang -

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 59518 tests passed, 1 failed and 763 were skipped. failed: Clangd.Clangd/rename.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. @vit9696 The only thing GCC defines for mcpu=8548 is __NO_LWSYNC__, the SPE-specific #defines are from -mspe. That said, since I explicitly do enable SPE for e500 CPU, I guess it makes sense to add it to the test. Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 ___ c

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc updated this revision to Diff 226171. chandlerc marked an inline comment as done. chandlerc added a comment. Address feedback from Manuel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 Files:

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc marked 2 inline comments as done. chandlerc added a comment. Thanks, updated. Comment at: clang/www/get_involved.html:113 + + A high-quality implementation: The implementation must fit well into + Clang's architecture, follow LLVM's coding conventions, and meet Clan

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc updated this revision to Diff 226174. chandlerc marked 3 inline comments as done. chandlerc added a comment. More fixes from Manuel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 Files: clang/

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226170. stevewan added a comment. Avoid blank else block when assertion is off Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. @jhibbits Should not the test in test/Preprocessor/init.c also ensure that `__SPE__` and `__NO_FPRS__` macros are defined with CPU 8548? The rest looks good to me, thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ http

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

klimek added inline comments. Comment at: clang/www/get_involved.html:94 + + A complete specification: The specification must be sufficient to + understand the design of the feature as well as interpret the meaning of Remove "complete" - the explanation afterwa

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc created this revision. chandlerc added a reviewer: klimek. Herald added a subscriber: mcrosier. Herald added a project: clang. Working with Meike and others to improve the wording in this document. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69351 Files: clang/w

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 226166. lewis-revill added a comment. Rebase on top of shrink wrapping patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Driver/ToolChains/

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. You know that feeling when you are doing a review and you think... I'm just not a compiler... I feel given the previous discussion and the level of extra tests maybe this is just worth going ahead with as long as you are prepared to support it in the interim.

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. Needs a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

tejohnson added a comment. I haven't read through the patch in detail yet, but from the description it sounds like a cache is being added for the compile step outputs, e.g. the bitcode output object of the "clang -flto=thin -c" step? Typically the build system takes care of incremental build ha

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I agree with the changes and want to see this go in, but it needs a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.or

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

aaron.ballman added a comment. Thank you for this! I don't think that the check should live in `misc`. It should have an alias in the `CERT` module, but maybe we want to have this live in a `posix` module? If not, this should probably live in `bugprone`. Comment at: clang-too

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/CMakeLists.txt:33 ToolChains/Arch/X86.cpp + ToolChains/AIX.cpp ToolChains/Ananas.cpp jasonliu wrote: > Looks like this list is following alphabetical or

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. https://github.com/ClangBuiltLinux/linux/issues/488#issuecomment-545218125 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/CMakeLists.txt:33 ToolChains/Arch/X86.cpp + ToolChains/AIX.cpp ToolChains/Ananas.cpp Looks like this list is following alphabetical order here, which means we should probably put "ToolChains/AIX

LLVM buildmaster will be updated and restarted later today

Hello everyone, LLVM buildmaster will be updated and restarted on or after 5:00 PM PDT. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 226164. ajpaverd added a comment. Split cfguard_setjmp test into target-specific tests and add missing cfguard_longjmp pass for ARM and AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226163. Typz added a comment. Rebased on master, integrating required code from https://reviews.llvm.org/D32478 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: c

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bda5f20674d: [clangd] abort if shutdown takes more than a minute. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D69329?vs=226135&id=226148#toc Repository: rG LLVM Github

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler updated this revision to Diff 226147. dcandler added a comment. Updated with the new name for the option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/ https://reviews.llvm.org/D67216 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver

[clang-tools-extra] 8bda5f2 - [clangd] abort if shutdown takes more than a minute.

Author: Sam McCall Date: 2019-10-23T17:52:59+02:00 New Revision: 8bda5f20674df1765bce8f0866204dff93ed244c URL: https://github.com/llvm/llvm-project/commit/8bda5f20674df1765bce8f0866204dff93ed244c DIFF: https://github.com/llvm/llvm-project/commit/8bda5f20674df1765bce8f0866204dff93ed244c.diff LO

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

glider added a comment. In D64742#1717054 , @mehdi_amini wrote: > In D64742#1606244 , @glider wrote: > > > As a data point, Linus Torvalds suggested that we need a similar feature > > for GCC so that the "kernel C

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Sorry I somehow missed the fact that I was a reviewer :D LGTM Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe86fdb86e1e: [analyzer] Fix off-by-one in operator call parameter binding. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69155/ne

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 59475 tests passed, 2 failed and 805 were skipped. failed: Clangd.Clangd/rename.test failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-

[clang] be86fdb - [analyzer] Fix off-by-one in operator call parameter binding.

Author: Artem Dergachev Date: 2019-10-23T08:17:02-07:00 New Revision: be86fdb86e1efd6921c81f25ac0c0a78903c0a2d URL: https://github.com/llvm/llvm-project/commit/be86fdb86e1efd6921c81f25ac0c0a78903c0a2d DIFF: https://github.com/llvm/llvm-project/commit/be86fdb86e1efd6921c81f25ac0c0a78903c0a2d.dif

[PATCH] D69338: [clangd] Collect name references in the index.

merge_guards_bot added a comment. Build result: fail - 59566 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary requested changes to this revision. lenary added a comment. This revision now requires changes to proceed. Sorry for approving, and then requesting changes. I've been investigating issues with this patch. When I try to use `-print-multi-lib` (a clang option that is very under-documented,

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov added a comment. Adding myself to the reviewers since I've already looked at it. Unless anyone objects. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads don't

[PATCH] D69338: [clangd] Collect name references in the index.

hokein updated this revision to Diff 226139. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69338/new/ https://reviews.llvm.org/D69338 Files: clang-tools-extra/clan

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 226137. hokein marked 13 inline comments as done. hokein added a comment. - address comments; - add more FIXMEs; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

merge_guards_bot added a comment. Build result: fail - 59568 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added a comment. In D69263#1718525 , @ilya-biryukov wrote: > In D69263#1717985 , @hokein wrote: > > > Thinking more about this -- we have a dynamic index (for all opened files) > > which is overlaid on a st

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added a comment. Mostly comments about tests, the implementation itself LG. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:68 +llvm::Optional getSemiColonForDecl(const FunctionDecl *FD) { + const SourceManager &SM = FD->getASTContext().ge

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69225/new/ https://reviews.llvm.org/D69225 _

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet updated this revision to Diff 226134. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Handle template parameters when copying function and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D692

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1574 + ExtraFiles["Test.cpp"] = ""; + EXPECT_EQ(apply("void fo^o() { return; }", &EditedFiles), "void foo() ;"); + EXPECT_THAT(EditedFiles,

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

sammccall updated this revision to Diff 226135. sammccall added a comment. change timeout to 5 min Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69329/new/ https://reviews.llvm.org/D69329 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 ___ cfe-commits mailing lis

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor issue. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewAlignmentCheck.cpp:30-31 + // Check not applicable in C++17 or newer. + if (getLangOpts().CPlusPlus17 || getLan

[clang] a9c3c17 - Reland "[Support] Add a way to run a function on a detached thread""

Author: Sam McCall Date: 2019-10-23T15:51:44+02:00 New Revision: a9c3c176ad741b9c2b915abc59dd977d0299c53f URL: https://github.com/llvm/llvm-project/commit/a9c3c176ad741b9c2b915abc59dd977d0299c53f DIFF: https://github.com/llvm/llvm-project/commit/a9c3c176ad741b9c2b915abc59dd977d0299c53f.diff LO

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. In D68877#1718729 , @kmclaughlin wrote: > There is not yet support for vector selects, so for this patch the intention > was that any passthru which

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:869-873 +if (Ident->isKeyword(getLangOpts()

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

This revision was automatically updated to reflect the committed changes. Closed by commit rG10c8dbcb840c: [clangd] Propogate context in TUScheduler::run (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://review

[PATCH] D69338: [clangd] Collect name references in the index.

merge_guards_bot added a comment. Build result: fail - 59565 tests passed, 2 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: cmake-log.txt

[PATCH] D66564: [clang-tidy] new performance struct pack align check

aaron.ballman added a comment. I sort of understand why this was asked to be put into `performance`, but I'm not convinced that's the right place to put it. Performance could be degraded by packing structures on some architectures depending on how the objects are accessed. I worry that people w

[PATCH] D69338: [clangd] Collect name references in the index.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:268 - // decide to implement renaming with index support. - if ((Roles & static_cast(index::SymbolRole::Nam

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

ymandel added a comment. In D69184#1718427 , @ymandel wrote: > In D69184#1715256 , @gribozavr wrote: > > > What are the use cases for non-text values? > > > > I like the name `text` much better... If the name confli

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin marked an inline comment as done. kmclaughlin added a comment. In D68877#1717820 , @dmgreen wrote: > I'm not sure if there is support yet for vector selects in the SVE codegen? There is not yet support for vector selects, so for this patch th

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin updated this revision to Diff 226123. kmclaughlin added a comment. - Removed unnecessary pseudo from SVEInstrFormats.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68877/new/ https://reviews.llvm.org/D68877 Files: llvm/include/llvm/CodeGen/SelectionDAG.h llvm/lib/Code

[PATCH] D69338: [clangd] Collect name references in the index.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:633 + Annotations Header(R"( +class $foo[[Foo]] { +public: --

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook added a comment. In D67185#1718459 , @luismarques wrote: > @simoncook: your commit doesn't include handling the case of TLS lowering > when `-ffixed-x4` is used. I looked at this, and did start writing the patch that covers the use of TP/X4 f

[PATCH] D69338: [clangd] Collect name references in the index.

hokein created this revision. hokein added reviewers: kadircet, ilya-biryukov. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. This is used for cross-file rename. When renaming a class, we expect to rename all related constructors/destructors. Repo

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

kadircet updated this revision to Diff 226122. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://reviews.llvm.org/D69328 Files: clang-tools-ex

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1525 +TEST_F(DefineOutlineTest, TriggersOnFunctionDecl) { + // Not available unless in a header file. + EX

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > vhscampos wrote: > > compnerd wrot

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:59 +// different location. Contains both function signature and body. +llvm::Optional moveFunctionDef(const FunctionDecl *FD) { + auto &SM = FD->getASTContext().getSourceManager(

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I've read this through again and it looks good. If no one else has any issues, then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67161/

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const SelectionTree::Node *N) { --

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

merge_guards_bot added a comment. Build result: fail - 59344 tests passed, 2 failed and 812 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: cmake-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

sammccall added a comment. In D69328#1718549 , @kadircet wrote: > In D69328#1718509 , @sammccall wrote: > > > Oops, this doesn't actually work - you're not setting the cloned context > > anywhere... > > > I am movi

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226109. serge-sans-paille added a comment. Temporarily comment out call support as free probe, everything else passes validation but a call may have some stack effect I don't handle (yet). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6872

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov updated this revision to Diff 226106. ilya-biryukov added a comment. - Add the added bit to serialization - Mention contains-errors in the AST dump. Still not tests in this revision, see D69330 for an expression that is actually preserved and has t

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

merge_guards_bot added a comment. Build result: fail - 59551 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:924 +Action = std::move(Action)]() mutable { Action(); }; + PreambleTasks->runAsync(Name, std::move(ActionWithCtx)); } Maybe inline `ActionWithCtx`

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added subscribers: usaxena95, erik.pilkington, kadircet, arphaman. Herald added a project: clang. Normally clang avoids creating expressions when it encounters semantic errors, even if the parser knows which expres

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

ilya-biryukov added a comment. Not sure 60 is enough, e.g. building a preamble can often take more than a minute and the users will see clangd crashing for (seemingly) no reason on shutdown. In the long run, we should probably attempt to cancel long-running operations within a much shorter time

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added a comment. In D68694#1711035 , @aaron.ballman wrote: > LGTM aside from a small nit. Thanks, fixed it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 226101. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. In D69263#1717985 , @hokein wrote: > Thinking more about this -- we have a dynamic index (for all opened files) > which is overlaid on a static index (which is a background index in > open-source world), so for all affected

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Oops, this doesn't actually work - you're not setting the cloned context anywhere... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay. Herald added a project: clang. A certain class of bug (e.g. infloop on an AST worker thread) currently means clangd never terminates, even if t

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can you modify `TEST_F(TUSchedulerTests, Run)` to verify? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://reviews.llvm.o

  1   2   >