kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
Sorry I somehow missed the fact that I was a reviewer :D LGTM ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads don't access other members. + llvm::Optional<ClangdServer> Server; }; ---------------- ilya-biryukov wrote: > Maybe call `Server.reset()` in destructor? > This ensures `ClangdServer` is terminated first even if the members are > re-ordered later +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69329/new/ https://reviews.llvm.org/D69329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
