ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov added a comment.
Adding myself to the reviewers since I've already looked at it. Unless anyone objects. ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219 + // destroyed first, to ensure worker threads don't access other members. + llvm::Optional<ClangdServer> Server; }; ---------------- Maybe call `Server.reset()` in destructor? This ensures `ClangdServer` is terminated first even if the members are re-ordered later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69329/new/ https://reviews.llvm.org/D69329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
