ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:633
+  Annotations Header(R"(
+    class $foo[[Foo]] {
+    public:
----------------
maybe use unnamed ranges?
having `$foo[[]]` instead of `[[]]` only hurt readability


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69338/new/

https://reviews.llvm.org/D69338



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to