[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

Hahnfeld added inline comments. Comment at: clang/docs/OpenMPSupport.rst:233 ++--+--+--++ +| device extension | mapping lamb

[PATCH] D65635: Sidestep false positive due to a matching git repository name

rogfer01 created this revision. rogfer01 added reviewers: eli.friedman, ddunbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. rogfer01 edited reviewers, added: efriedma; removed: eli.friedman. I have failures in this test because the `grep @b` gets confused by the `clang

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

phosek added a comment. Looks like this change broke `Profile/gcc-flag-compatibility.c` test on macOS: TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED Script: -- : 'RUN: at line 10'; /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_di

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 212974. Manikishan added a comment. Added Tests for using and not using SortPriority Field, Now, even if the SortPriorityis not set it will be set to the value of Category by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 updated this revision to Diff 212970. rogfer01 added a comment. ChangeLog - Rebase change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/Driver/ToolChains/Clang.cpp Ind

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Hi @lenary, sure I can rebase this. However, I think it may be better to do the `lp64d` change in another phab so we can keep this one NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

This revision was automatically updated to reflect the committed changes. Closed by commit rL367649: Improve raw_ostream so that you can "write" colors using operator<< (authored by ruiu, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D65

r367649 - Improve raw_ostream so that you can "write" colors using operator<

Author: ruiu Date: Thu Aug 1 21:48:30 2019 New Revision: 367649 URL: http://llvm.org/viewvc/llvm-project?rev=367649&view=rev Log: Improve raw_ostream so that you can "write" colors using operator<< 1. raw_ostream supports ANSI colors so that you can write messages to the termina with colors. Pre

[PATCH] D65631: [clang-format] Fix a bug that doesn't break braces before unions for Allman

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367648: [clang-format] Fix a bug that doesn't break braces before unions for Allman (authored by owenpan, committed by ).

r367648 - [clang-format] Fix a bug that doesn't break braces before unions for Allman

Author: owenpan Date: Thu Aug 1 21:30:42 2019 New Revision: 367648 URL: http://llvm.org/viewvc/llvm-project?rev=367648&view=rev Log: [clang-format] Fix a bug that doesn't break braces before unions for Allman Differential Revision: https://reviews.llvm.org/D65631 Modified: cfe/trunk/lib/Form

[PATCH] D65631: [clang-format] Fix a bug that doesn't break braces before unions for Allman

owenpan created this revision. owenpan added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR42155 Repository: rC Clang https://reviews.llvm.org/D65631 Files: clang/lib/Format/Format.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cp

[PATCH] D65192: [Sema] Make -Wbitwise-op-parentheses and -Wlogical-op-parentheses disabled-by-default

MaskRay updated this revision to Diff 212962. MaskRay added a comment. test/Parser/cxx2a-spaceship.cpp does not need a change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65192/new/ https://reviews.llvm.org/D65192 Files: include/clang/Basic/DiagnosticSemaKind

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

ruiu marked an inline comment as done. ruiu added inline comments. Comment at: clang/tools/diagtool/TreeView.cpp:30 - TreePrinter(llvm::raw_ostream &out) - : out(out), ShowColors(hasColors(out)), Internal(false) {} - - void setColor(llvm::raw_ostream::Colors Color) { -

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

ruiu updated this revision to Diff 212959. ruiu added a comment. - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65564/new/ https://reviews.llvm.org/D65564 Files: clang/include/clang/AST/ASTDumperUtils.h clang/lib/Analysis/CFG.cpp cl

[PATCH] D65192: [Sema] Make -Wbitwise-op-parentheses and -Wlogical-op-parentheses disabled-by-default

MaskRay updated this revision to Diff 212958. MaskRay retitled this revision from "[Sema] Disable some enabled-by-default -Wparentheses diagnostics" to "[Sema] Make -Wbitwise-op-parentheses and -Wlogical-op-parentheses disabled-by-default". MaskRay edited the summary of this revision. MaskRay add

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert updated this revision to Diff 212957. jdoerfert added a comment. Improve based on two comments by @Hahnfeld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files: clang/docs/OpenMPSupport.rst I

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

rsmith added a comment. Can you reduce this patch to only the `&&` within `||` and `&` within `|` changes? I think we have reasonable consensus that that should not be enabled by default, so let's land that part now. If you want to continue discussing `-Wshift-op-parentheses` after that, we can

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc created this revision. pcc added reviewers: hctim, tejohnson. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. The default behavior of Clang's indirect function call checker will replace the address of each CFI-checked f

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, Def

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Reduce phase has been parallelized and a execution time was reduced by 60% with this. The reading o

[PATCH] D65627: [clang-doc] Continue after mapping error

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. The tool used to stop execution if there was an error in the mapping phase. It will now show the er

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge added a comment. As background, some discussion of this took place on the mailing list a few months ago: http://lists.llvm.org/pipermail/clangd-dev/2019-January/000232.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65625/new/ https://re

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

seiya accepted this revision. seiya added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65564/new/ https://reviews.llvm.org/D65564 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This is useful for multi-project setups where each project has its own compilation database, and particularly in cases w

[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

ahatanak updated this revision to Diff 212942. ahatanak marked 2 inline comments as done. ahatanak added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. - Emit member access, compound literal, and call expressions as subexpressions of `ExprWithCleanups` if the expres

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

Oh! Interesting! Thanks for investigating this. I'm happy to review the patch. > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi wrote: > > Hi Jan, Thanks for the follow up! > > Me and Compnerd narrowed down the issue to the inotify file count limit being > exceeded as the cause. DirectoryWatcherLinu

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. and the diff is shorter now :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65615/new/ https://reviews.llvm.org/D65615 __

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. HTML generator has been included in clang-tools-extra release notes. clang-doc documentation file has been updated. https://reviews.llvm.org/D65

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jdoerfert added a comment. In D58531#1599209 , @probinson wrote: > We've started running into this too in building the PS4 system. +jdoerfert > who added pthread_create to the builtin list. > > Looking at the patch, it seems straightforward enough althoug

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

yonghong-song updated this revision to Diff 212926. yonghong-song added a comment. reorder parameter arrayType to make it with default nullptr and simplifies the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65615/new/ https://reviews.llvm.org/D65615 File

r367632 - [DirectoryWatcher] Relax assumption to prevent test flakiness

Author: jkorous Date: Thu Aug 1 16:24:30 2019 New Revision: 367632 URL: http://llvm.org/viewvc/llvm-project?rev=367632&view=rev Log: [DirectoryWatcher] Relax assumption to prevent test flakiness Modified: cfe/trunk/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp cfe/trunk/unittests/Dir

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3402 QualType eltType, bool inbounds, - bool signedIndices, SourceLocation loc, +

[PATCH] D65545: Handle some fs::remove failures

jfb added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:647-649 + if (std::error_code EC = llvm::sys::fs::remove(OF.TempFilename)) +getDiagnostics().Report(diag::err_fe_error_removing) + << OF.TempFilename << EC.message();

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

yonghong-song added a comment. The corresponding IR intrinsic interface change is at https://reviews.llvm.org/D65617 The BPF backend to utilize this information is at https://reviews.llvm.org/D65618 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65615/new/ https

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

ast added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3402 QualType eltType, bool inbounds, - bool signedIndices, SourceLocation loc, + bool signedIndices, QualTy

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A created this revision. Romain-Geissler-1A added reviewers: serge-sans-paille, chandlerc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, This simple patch ignores -fsemantic-interposition/-fno-semantic-interposition that may be used by some gcc users

[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: kristina, arphaman, aprantl. Herald added a project: clang. Previously, debuginfo types are annotated to IR builtin preserve_struct_access_index() and preserve_union_access_index(), but not preserve

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. I was hoping Richard would take a look, but I reproduced the crash, and I'd rather see the fix land sooner than later. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

This revision was automatically updated to reflect the committed changes. xur marked an inline comment as done. Closed by commit rL367628: [PGO] Add PGO support at -O0 in the experimental new pass manager (authored by xur, committed by ). Changed prior to commit: https://reviews.llvm.org/D64029

r367628 - [PGO] Add PGO support at -O0 in the experimental new pass manager

Author: xur Date: Thu Aug 1 15:36:34 2019 New Revision: 367628 URL: http://llvm.org/viewvc/llvm-project?rev=367628&view=rev Log: [PGO] Add PGO support at -O0 in the experimental new pass manager Add PGO support at -O0 in the experimental new pass manager to sync the behavior of the legacy pass m

[PATCH] D65545: Handle some fs::remove failures

jkorous added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:107-111 TemporaryFiles::~TemporaryFiles() { llvm::MutexGuard Guard(Mutex); for (const auto &File : Files) -llvm::sys::fs::remove(File.getKey()); +if (std::error_code EC = llvm::sy

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur marked 3 inline comments as done. xur added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 +PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, + /* RunProfileGen */ PGOOpt->Action == +

r367622 - Fix Windows branch of FileManagerTest changes

Author: harlanhaskins Date: Thu Aug 1 14:58:56 2019 New Revision: 367622 URL: http://llvm.org/viewvc/llvm-project?rev=367622&view=rev Log: Fix Windows branch of FileManagerTest changes Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp Modified: cfe/trunk/unittests/Basic/FileManagerTes

r367620 - Fix use-after-move in ClangBasicTests

Author: harlanhaskins Date: Thu Aug 1 14:50:16 2019 New Revision: 367620 URL: http://llvm.org/viewvc/llvm-project?rev=367620&view=rev Log: Fix use-after-move in ClangBasicTests Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp UR

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with two nits addressed, thanks! Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 +PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, +

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL367618: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure (authored by harlanhaskins, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[clang-tools-extra] r367617 - [clang-tools-extra] Adopt FileManager's error-returning APIs

Author: harlanhaskins Date: Thu Aug 1 14:32:01 2019 New Revision: 367617 URL: http://llvm.org/viewvc/llvm-project?rev=367617&view=rev Log: [clang-tools-extra] Adopt FileManager's error-returning APIs The FileManager has been updated to return llvm::ErrorOr from getFile and getDirectory, this com

r367616 - [clang] Adopt new FileManager error-returning APIs

Author: harlanhaskins Date: Thu Aug 1 14:31:56 2019 New Revision: 367616 URL: http://llvm.org/viewvc/llvm-project?rev=367616&view=rev Log: [clang] Adopt new FileManager error-returning APIs Update the callers of FileManager::getFile and FileManager::getDirectory to handle the new llvm::ErrorOr-

r367615 - [clang] Adopt llvm::ErrorOr in FileManager methods

Author: harlanhaskins Date: Thu Aug 1 14:31:49 2019 New Revision: 367615 URL: http://llvm.org/viewvc/llvm-project?rev=367615&view=rev Log: [clang] Adopt llvm::ErrorOr in FileManager methods Previously, the FileManager would use NULL returns to signify whether a file existed, but that doesn’t co

[PATCH] D64592: [OpenMP] Fix declare target link implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367613: [OpenMP] Fix declare target link implementation (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

r367613 - [OpenMP] Fix declare target link implementation

Author: gbercea Date: Thu Aug 1 14:15:58 2019 New Revision: 367613 URL: http://llvm.org/viewvc/llvm-project?rev=367613&view=rev Log: [OpenMP] Fix declare target link implementation Summary: This patch fixes the case where variables in different compilation units or the same compilation unit are

[PATCH] D65487: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I thereby confirm that i've no idea what was this code about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65487/new/ https://reviews.llvm.org/D65487

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sry, should have approved this ages ago >.< Comment at: clang/test/Analysis/uninit-vals.c:181 void testUseHalfPoint() { - struct Point p = getHalfPoint(); // expected-note{{Calli

[PATCH] D65545: Handle some fs::remove failures

jfb updated this revision to Diff 212899. jfb marked 11 inline comments as done. jfb added a comment. - Return llvm::Error from ASTUnit::Save - Update per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65545/new/ https://reviews.llvm.org/D

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

This revision was automatically updated to reflect the committed changes. Closed by commit rL367608: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its… (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

r367608 - [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Author: charusso Date: Thu Aug 1 13:41:13 2019 New Revision: 367608 URL: http://llvm.org/viewvc/llvm-project?rev=367608&view=rev Log: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile Summary: It allows discriminating between stack frames of the same call that is

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

NoQ added a comment. Fantastic! Let's open the wording bikeshed season? I suspect that a simple "(The) Value -> Condition value" change would have worked better. Another variant: "Value ..., which participates in a condition later". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso added a comment. Thanks for the review and for the idea! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65587/new/ https://reviews.llvm.org/D65587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso added a subscriber: george.karpenkov. Charusso added inline comments. Comment at: clang/test/Analysis/loop-unrolling.cpp:349-353 #ifdef DFS -clang_analyzer_numTimesReached(); // expected-warning {{10}} +clang_analyzer_numTimesReached(); // expected-warning {{16}

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso updated this revision to Diff 212895. Charusso marked an inline comment as done. Charusso edited the summary of this revision. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65587/new/ https://reviews.llvm.org/D65587 Files: clang/include/clang

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang updated this revision to Diff 212890. czhang marked an inline comment as done. czhang added a comment. Add example in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTi

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 212889. Nathan-Huckleberry added a comment. - Support python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files: clang-tools-extra/docs/clang-tidy/che

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked 3 inline comments as done. czhang added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-dynamic-static-initializers.hpp:33-35 + // This may work fine when optimization is enabled because bar() can + // be turned into a constant 7. But wit

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous accepted this revision. jkorous marked an inline comment as done. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for all the work here! Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(temp

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">, GCC<"designated_init">]; + let Subjects = SubjectList<[Record]>; emmettneyman wr

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ah, omission of the century :/ Thanks, this looks immediately good! Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:305 + // The 'NodeBuilderContext::blockCount(

[PATCH] D65573: Add User docs for ASTImporter

shafik added a comment. Thank you for writing this up! I just have a few minor comments. Comment at: clang/docs/LibASTImporter.rst:110 + +Now we create the Importer and do the import: + Maybe helpful to link to the [Matching the Clang AST](https://clang.llvm.o

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev updated this revision to Diff 212882. AntonBikineev added a comment. Roman, -ast-dump shows the correct result, because the correct address space is encoded in qualifiers and is passed to Context.getAddrSpaceQualType(...) later in this function. This is why this bug is not observab

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. This seems reasonable to me except for the fact that the script doesn't run when I try it locally. c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python gen-static-analyzer-docs.py Traceback (most recent call last): File "gen-static-analyzer-docs.p

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 212878. SjoerdMeijer added a comment. Fixed the string problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/ParsePragma.cpp ===

[PATCH] D65543: Use library basenames when autolinking on Windows

thakis added a comment. I kind of like the current behavior since it's consistent with how resource dirs are passed to cc1, and how __FILE__ expands if you give a relative work to clang, and how debug info paths look if you pass relative paths to clang. Repository: rG LLVM Github Monorepo C

[PATCH] D65597: WIP: Builtins: Start adding half versions of math builtins

arsenm created this revision. arsenm added reviewers: rsmith, rjmccall, Anastasia, yaxunl. Herald added a subscriber: wdng. The implementation of the OpenCL builtin currently library uses 2 different hacks to get to the corresponding IR intrinsics from the source. This will allow removal of thos

r367602 - Test linux only for absolute paths in the -fuse-ld option

Author: yuanfang Date: Thu Aug 1 11:49:59 2019 New Revision: 367602 URL: http://llvm.org/viewvc/llvm-project?rev=367602&view=rev Log: Test linux only for absolute paths in the -fuse-ld option Some target do not use this option and may emit a error message for using it. Modified: cfe/trunk/t

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. Hi Puyan, I failed to reproduce with llvm.org/master (5faa533e47b0e54b04166b0257c5ebb48e6ffcaa ) on Ubuntu 18.04.1 LTS both in debug and release build. Since it sounds like you can reproduce "reliabl

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

rnk added a comment. Thanks! Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, Is it feasible to make this an `enum class`? I'm worried about namespace clashes on these otherwise very short names

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins updated this revision to Diff 212860. harlanhaskins marked 8 inline comments as done. harlanhaskins added a comment. Updated in response to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins marked 6 inline comments as done and an inline comment as not done. harlanhaskins added inline comments. Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(tempPath); + if (newE) { +remap(origFE, *newE); -

[PATCH] D65582: IR: accept and print numbered %N names for function args

rnk added a comment. This is awesome! Thanks for doing the test updates. As I read it, LLVM will still read old-style IR just fine, which seems nice. I think it would be worth noting this in the 10.0 release notes, since it will affect someone upgrading a frontend as you mention. Otherwise, I

[PATCH] D65543: Use library basenames when autolinking on Windows

rnk added a comment. I'll look into that. I also noticed that check-ubsan fails. I think we should also change clang's driver to add this libpath when it invokes the linker, so that this works transparently when using the GCC-style driver. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE |

[PATCH] D65579: Don't try emitting dllexported explicitly defaulted non-trivial ctors twice during explicit template instantiation definition (PR42857)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm yeesh. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65579/new/ https://reviews.llvm.org/D65579 ___ cfe-commits mailing list cfe-commits

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1606256 , @rdwampler wrote: > In D64695#1605676 , @Manikishan > wrote: > > > In D64695#1590948 , @Manikishan > > wrote: > > > > > In D

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added a project: clang. ilya-biryukov added a parent revision: D65591: [AST] Add a flag indicating if any subexpression had errors. Suppress those diagnostics if lhs of a member expression contains errors. Typo co

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added a subscriber: jfb. Herald added a project: clang. ilya-biryukov added a child revision: D65592: [Parser] Avoid spurious 'missing template' error in presence of typos. The only subexpression that is considere

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

lebedev.ri added a comment. This really needs a test, likely an astdump-one will show it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-comm

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, klimek. AntonBikineev added a project: clang. Interestingly enough, but this wasn't caught in tests. I wonder if it's possible to write a test case for it. Repository: rC Clang https://reviews.llvm.org/D65589 Files:

[PATCH] D65582: IR: accept and print numbered %N names for function args

jdoerfert resigned from this revision. jdoerfert added a comment. I like the idea but I am not the right person to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65582/new/ https://reviews.llvm.org/D65582 _

[PATCH] D65573: Add User docs for ASTImporter

aprantl added a comment. Thanks, the extra documentation is highly appreciated! Comment at: clang/docs/LibASTImporter.rst:19 +``ASTContext`` holds long-lived AST nodes (such as types and decls) that can be referred to throughout the semantic analysis of a file. +There are case

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:486 const StackFrameContext *getStackFrame(AnalysisDeclContext *Ctx, - LocationContext const *Paren

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. With this addition we can distinguish between `StackSpa

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3859 ToTypeSourceInfo, D->getStorageClass(), /*DefaultArg*/ nullptr)) return ToParm; This should be `DefaultArg` now?

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:84 +DependencyScanningFilesystemSharedCache() { + NumShards = 8; + CacheShards = llvm::make_unique(NumShards); arphaman wrote: > aganea wrote: >

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

andreadb accepted this revision. andreadb added a comment. This revision is now accepted and ready to land. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65564/new/ https://reviews.llvm.org/D65564 __

[PATCH] D65582: IR: accept and print numbered %N names for function args

jyknight added a comment. Herald added a subscriber: wuzish. +1 for doing this. I started looking at fixing this when I modified the printer to print proper labels for numbered basic-blocks (instead of comments), but I didn't do so because of the amount of test churn was off-putting. I think th

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, DefaultIgnore; MaskRay

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard updated this revision to Diff 212833. ostannard added a comment. - Add LTOPostLink metadata, instead of internalising vcall visibility at LTO time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. Looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, though I have some comments. Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135 + +struct DefParmContext { + static const int I; Perhaps we co

  1   2   >