yonghong-song marked an inline comment as done.
yonghong-song added inline comments.
================
Comment at: lib/CodeGen/CGExpr.cpp:3402
QualType eltType, bool inbounds,
- bool signedIndices, SourceLocation loc,
+ bool signedIndices, QualType *arrayType,
+ SourceLocation loc,
----------------
ast wrote:
> would it make sense to reorder and make it 'QualType *arrayType = nullptr',
> so only explicit pointers would be passed and the rest will get 'nullptr'
> automatically?
Yes, that makes sense. Previous I thought about grouping related fields
together. But make nullptr as the default is a good idea.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65615/new/
https://reviews.llvm.org/D65615
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
