xur marked 3 inline comments as done. xur added inline comments.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 + PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, + /* RunProfileGen */ PGOOpt->Action == + PGOOptions::IRInstr, ---------------- chandlerc wrote: > Minor nit, here and else where with the comment-named bools I'd use the > style: `/*RunProfileGen=*/PGOOpt->Action == PGOOPtions::IRInstr` > > This was suggested as more consistent w/ Clang style, and it seems a bit > cleaner. Also, clang-tidy will recognize and check that the comment uses the > same name as the parameter. Thanks for the suggestion and the reasoning. I actually wrote it in one line. This was produced by "clang/tools/clang-format/clang-format-diff.py". :-) I'm using now "/*RunProfileGen=*/ (PGOOpt->Action == PGOOPtions::IRInstr)" so clang-format-diff.py won't complain CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64029/new/ https://reviews.llvm.org/D64029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
