jyknight added a comment. Herald added a subscriber: wuzish. +1 for doing this. I started looking at fixing this when I modified the printer to print proper labels for numbered basic-blocks (instead of comments), but I didn't do so because of the amount of test churn was off-putting.
I think that after this change, there's only one local entity left which uses a local-value-number but doesn't print it: the entry block. That also would cause a quite-large amount of test-churn to add. ================ Comment at: llvm/lib/IR/AsmWriter.cpp:3561 + else + Out << "<badref>"; } ---------------- I think you need a space before this string? Although, then shouldn't llvm/unittests/IR/AsmWriterTest.cpp be failing? (it has a space there...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65582/new/ https://reviews.llvm.org/D65582 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
