[PATCH] D60760: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

sberg added a comment. Added missing tests at https://reviews.llvm.org/D61479 "Add tests for 'Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO'". Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60760/new/ https://reviews.llvm.org/D60760 ___

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

o.gyorgy added a comment. Great, at least the users will not enable the debug checkers by accident! We will check on the CodeChecker side if any configuration needs to be updated. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak updated this revision to Diff 197918. ahatanak marked 2 inline comments as done. ahatanak added a comment. - Instead of passing a flag to `CreateMetadataVar` that indicates the section is in segment `__DATA`, just scan the section name string inside `CreateMetadataVar`. - Fix test case

r359859 - Revert "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Author: leonardchan Date: Thu May 2 20:28:06 2019 New Revision: 359859 URL: http://llvm.org/viewvc/llvm-project?rev=359859&view=rev Log: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" This reverts commit fc40cbd9d8c63e65eed3590ba925321afe782e1d. Removed:

Re: r359814 - [Sema] Emit warning for visibility attribute on internal-linkage declaration

This also breaks building libc++ [1]. Reverted for now in r359858. 1: FAILED: obj/buildtools/third_party/libc++/libc++/new.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++/libc++/new.o.d -D_LIBCPP_BUILDING_LIBRARY -DLIBCXX_BUILDING_LIBCXXABI -DU

r359858 - Revert r359814 "[Sema] Emit warning for visibility attribute on internal-linkage declaration"

Author: nico Date: Thu May 2 20:16:07 2019 New Revision: 359858 URL: http://llvm.org/viewvc/llvm-project?rev=359858&view=rev Log: Revert r359814 "[Sema] Emit warning for visibility attribute on internal-linkage declaration" See cfe-commits thread for r359814. Modified: cfe/trunk/include/cl

[PATCH] D61456: [gn] Update the clangd test lit site configuration

thakis closed this revision. thakis added a comment. This landed in r359825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61456/new/ https://reviews.llvm.org/D61456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

Re: [PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

> In any case, it seems like your examples argue for disallowing a return-type mismatch between host and device overloads, not disallowing observing the type? Oh no, we have to allow return-type mismatches between host and device overloads, that is a common thing in CUDA code I've seen. You can s

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hfinkel added a comment. > Only if they also differ in some other way. C++ does not (generally) have > return-type-based overloading. The two functions described would even mangle > the same way if CUDA didn't include host/device in the mangling. Certainly. I didn't mean to imply otherwise. R

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

rjmccall added a comment. In D61458#1488972 , @hfinkel wrote: > In D61458#1488970 , @jlebar wrote: > > > Here's one for you: > > > > __host__ float bar(); > > __device__ int bar(); > > __host__ __device__ auto

Re: [PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

Thanks, Justin. It sees like we have the standard set of options: We can disallow the mismatch. We can allow it with a warning. We can allow it without a warning. We can say that if the mismatch contributes to the type of a kernel function, that's illformed (NDR). In any case, it seems like you

Re: r359814 - [Sema] Emit warning for visibility attribute on internal-linkage declaration

Hi Richard,Thank you for the heads up. Feel free to revert, or I can when I can get back to a terminal. I'm not sure where the right place is to warn if using the linkage calculator here is too early, so it might take a bit of time for me to fix the patch.Thanks,ScottOn May 2, 2019 9:42 PM, Richard

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 197911. gtbercea added a comment. - Address comments. - Add math and cmath inclusion tests. - Add driver test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/Too

Re: [PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

> So, actually, I wonder if that's not the right answer. We generally allow different overloads to have different return types. What if, for example, the return type on the host is __float128 and on the device it's `MyLongFloatTy`? The problem is that conceptually compiling for host/device does no

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hfinkel added a comment. In D61458#1488970 , @jlebar wrote: > Here's one for you: > > __host__ float bar(); > __device__ int bar(); > __host__ __device__ auto foo() -> decltype(bar()) {} > > > What is the return type of `foo`? :) > > I don't believe

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

jlebar added a subscriber: rsmith. jlebar added a comment. Here's one for you: __host__ float bar(); __device__ int bar(); __host__ __device__ auto foo() -> decltype(bar()) {} What is the return type of `foo`? :) I don't believe the right answer is, "float when compiling for host, int wh

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

ZaMaZaN4iK created this revision. ZaMaZaN4iK added reviewers: NoQ, JonasToth. ZaMaZaN4iK added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the release notes from JetBrains (https://www.jetbrains.com/resharper-cpp/whatsnew/#v201

[PATCH] D61474: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case

gtbercea created this revision. gtbercea added reviewers: tra, ABataev, caomhin. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. The bug was reported on the OpenMP-dev list: .../obj-release/lib/clang/9.0.0/include/__clang_cuda_intrinsics.h:173:35: error: '__nvvm_

Re: r359814 - [Sema] Emit warning for visibility attribute on internal-linkage declaration

This will trigger computation and caching the linkage of the declaration too early (before we actually know it) in some cases. For instance, I believe this is causing a rejects-valid on: typedef struct __attribute__((visibility("hidden"))) {} A; ... which we used to accept but now reject with: :

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. In D51329#1488918 , @JDevlieghere wrote: > I think this is change is causing an assertion to be hit: > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/25103/consoleFull#-239233992d489585b-5106-414a-ac11-3ff90657619c

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

JDevlieghere added a comment. I think this is change is causing an assertion to be hit: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/25103/consoleFull#-239233992d489585b-5106-414a-ac11-3ff90657619c http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56122/console Can you ha

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

dblaikie marked an inline comment as done. dblaikie added a comment. In D61357#1488839 , @rsmith wrote: > In D61357#1485581 , @dblaikie wrote: > > > Oh, @rsmith - if there's any better/different testing (if you can

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

This revision was automatically updated to reflect the committed changes. Closed by commit rC359854: SemaOverload: Complete candidates before emitting the error, to ensure… (authored by dblaikie, committed by ). Changed prior to commit: https://reviews.llvm.org/D61357?vs=197491&id=197901#toc R

r359854 - SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

Author: dblaikie Date: Thu May 2 17:44:50 2019 New Revision: 359854 URL: http://llvm.org/viewvc/llvm-project?rev=359854&view=rev Log: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload no

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

hfinkel added a comment. In D61399#1488366 , @ABataev wrote: > In D61399#1488329 , @hfinkel wrote: > > > In D61399#1488309 , @ABataev wrote: > > > > > In D61399#1488299

[PATCH] D61464: [RiscV] Typo in register aliases

jrtc27 added a comment. Ouch; LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61464/new/ https://reviews.llvm.org/D61464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61464: [RiscV] Typo in register aliases

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Sorry I didn't notice this earlier. -eric CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61464/new/ https://reviews.llvm.org/D61464 __

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

rsmith added a comment. In D61357#1485581 , @dblaikie wrote: > Oh, @rsmith - if there's any better/different testing (if you can figure out > how to reduce the test case down further, now that we know the cause - or if > you'd like testing for other code

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lib/Sema/SemaOverload.cpp:3518-3519 << false << From->getType() << From->getSourceRange() << ToType; } else return false; + -

r359844 - Fix -Wunsequenced false-positives in code controlled by a branch on

Author: rsmith Date: Thu May 2 16:21:28 2019 New Revision: 359844 URL: http://llvm.org/viewvc/llvm-project?rev=359844&view=rev Log: Fix -Wunsequenced false-positives in code controlled by a branch on __builtin_constant_p. If the operand of __builtin_constant_p is not constant and has side-effect

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

xbolva00 added a comment. Also please update https://clang.llvm.org/cxx_status.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:3961 + // linkage so that the linker preserves the symbol name. + llvm::GlobalValue::LinkageTypes LT = ExplicitDataSegment || Section.empty() + ? llvm::GlobalValue::I

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. If "$sysroot/lib" ends up coming to mean "wasm32" because people come to depend on that, then wasm64 may end up needing to be different in a gratuitous way, which I'd like to avoid. I'd like to keep our sysroots tidy when we can. If some libraries are installed in `lib

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:3961 + // linkage so that the linker preserves the symbol name. + llvm::GlobalValue::LinkageTypes LT = ExplicitDataSegment || Section.empty() +

[PATCH] D61470: [CUDA] Do not pass deprecated option fo fatbinary

This revision was automatically updated to reflect the committed changes. Closed by commit rC359838: [CUDA] Do not pass deprecated option fo fatbinary (authored by tra, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D61470?vs=197876&id=197880#to

r359838 - [CUDA] Do not pass deprecated option fo fatbinary

Author: tra Date: Thu May 2 15:37:19 2019 New Revision: 359838 URL: http://llvm.org/viewvc/llvm-project?rev=359838&view=rev Log: [CUDA] Do not pass deprecated option fo fatbinary CUDA 10.1 tools deprecated some command line options. fatbinary no longer needs --cuda. Differential Revision: https

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

vsk added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:3961 + // linkage so that the linker preserves the symbol name. + llvm::GlobalValue::LinkageTypes LT = ExplicitDataSegment || Section.empty() + ? llvm::GlobalValue::Intern

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak updated this revision to Diff 197877. ahatanak marked 6 inline comments as done. ahatanak edited the summary of this revision. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/ https://reviews.llv

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thank you! Comment at: clang/lib/Sema/SemaInit.cpp:9359 // The converting constructors of T are candidate functions. if (Kind.isCopyInit() && !Lis

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:1978 +? llvm::GlobalVariable::InternalLinkage +: llvm::GlobalValue::PrivateLinkage); // FIXME. Fix section. rj

Re: r359809 - Use primary template parameter names for variable template debug info

On Thu, 2 May 2019 at 10:43, Reid Kleckner via cfe-commits wrote: > > Author: rnk > Date: Thu May 2 10:45:54 2019 > New Revision: 359809 > > URL: http://llvm.org/viewvc/llvm-project?rev=359809&view=rev > Log: > Use primary template parameter names for variable template debug info > > Summary: > F

[PATCH] D61470: [CUDA] Do not pass deprecated option fo fatbinary

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: bixia. CUDA 10.1 tools have deprecated some command line options, so fatbinary no longer needs --cuda parameter. https://reviews.llvm.org/D61470 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny created this revision. jdenny added reviewers: akyrtzi, Eugene.Zelenko, rsmith. Herald added subscribers: dexonsmith, mgorny. Herald added a project: clang. Some Rewrite functions are already overloaded to accept CharSourceRange, and this extends others in the same manner. I'm calling the

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

tra added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10407-10409 bool IsAllowedCUDACall(const FunctionDecl *Caller, const FunctionDecl *Callee) { +if (llvm::any_of(ExprEvalContexts, One more thing. The idea of th

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1488553 , @erik.pilkington wrote: > In D61165#1487328 , @rjmccall wrote: > > > In D61165#1487100 , > > @erik.pilkington wrote: > > > > >

[PATCH] D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX359827: [libc++][test] Remove non-portable assumption that thread's constructor… (authored by CaseyCarter, committed by ). Herald added subscribers: libcxx-commits, jfb, ldionne. Changed prior to commit

[PATCH] D61466: [Rewrite][NFC] Add FIXME about RemoveLineIfEmpty

jdenny created this revision. jdenny added reviewers: akyrtzi, Eugene.Zelenko, rsmith. Herald added a subscriber: dexonsmith. Herald added a project: clang. I'd like to add these comments to warn others of problems I encountered when trying to use RemoveLineIfEmpty. I originally tried to fix the

[PATCH] D61464: [RiscV] Typo in register aliases

JohnLLVM updated this revision to Diff 197864. JohnLLVM added a comment. Proper context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61464/new/ https://reviews.llvm.org/D61464 Files: lib/Basic/Targets/RISCV.cpp Index: lib/Basic/Targets/RISCV.cpp ==

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

tra added a comment. In D61458#1488550 , @hliao wrote: > In D61458#1488523 , @tra wrote: > > > Perhaps we should allow this in all unevaluated contexts? > > I.e. `int s = sizeof(foo(x));` should also work. > > > g

[PATCH] D61464: [RiscV] Typo in register aliases

JohnLLVM created this revision. JohnLLVM added a reviewer: echristo. JohnLLVM added a project: clang. Herald added subscribers: cfe-commits, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, ap

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hliao marked an inline comment as done. hliao added a comment. In D61458#1488523 , @tra wrote: > Perhaps we should allow this in all unevaluated contexts? > I.e. `int s = sizeof(foo(x));` should also work. good point, do we have a dedicated context for

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hliao updated this revision to Diff 197860. hliao added a comment. simplify the logic using `llvm::any_of`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61458/new/ https://reviews.llvm.org/D61458 Files: clang/include/clang/Sema/Sema.h clang/t

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > Jake, I am still not sure what you would prefer for moving forward. The > current patch can output the yaml format I originally proposed or the one > that looks similar to the one you proposed. What I need to know is: > > Do you want the merging if the "ifo" file

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1487328 , @rjmccall wrote: > In D61165#1487100 , @erik.pilkington > wrote: > > > It seems like the most common sense interpretation here is to just treat > > the initiali

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang closed this revision. akhuang added a comment. Committed in r359823 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 ___ cfe-commits mailing list cfe-com

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rC359826: [Attribute/Diagnostics] Print macro if definition is an attribute declaration (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D51329?vs=197454&id=1978

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

tra added a comment. Perhaps we should allow this in all unevaluated contexts? I.e. `int s = sizeof(foo(x));` should also work. Comment at: clang/include/clang/Sema/Sema.h:10411 + auto I = + std::find_if(ExprEvalContexts.rbegin(), ExprEvalContexts.rend(), +

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. In D51329#1488465 , @rsmith wrote: > Thanks, looks great! > > I think the handling of the expansion location in the `MacroQualifiedTypeLoc` > isn't quite right yet (it looks like it will never actually be set at all, > becaus

r359826 - [Attribute/Diagnostics] Print macro if definition is an attribute declaration

Author: leonardchan Date: Thu May 2 13:38:14 2019 New Revision: 359826 URL: http://llvm.org/viewvc/llvm-project?rev=359826&view=rev Log: [Attribute/Diagnostics] Print macro if definition is an attribute declaration If an address_space attribute is defined in a macro, print the macro instead when

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. Even in the case of wasm64 it might well be that somebody wants to build two different sysroots (as they would be arm and arm64 on linux). Even if we don't choose to ship a single arch sysroot for wasi somebody else might. This doesn't seem like it does any harm to me.

[clang-tools-extra] r359824 - [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching

Author: jkorous Date: Thu May 2 13:32:56 2019 New Revision: 359824 URL: http://llvm.org/viewvc/llvm-project?rev=359824&view=rev Log: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Within `decltype`, expressions are only type-inspected. The restriction on CUDA calls should be relaxed. Repository: rG LLVM Github Monorepo htt

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197851. akhuang added a comment. Change dyn_cast to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExpr

r359823 - Change the metadata for heapallocsite calls when the type is cast.

Author: akhuang Date: Thu May 2 13:07:35 2019 New Revision: 359823 URL: http://llvm.org/viewvc/llvm-project?rev=359823&view=rev Log: Change the metadata for heapallocsite calls when the type is cast. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/CodeGen/CGExprScalar.cpp cf

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks great! I think the handling of the expansion location in the `MacroQualifiedTypeLoc` isn't quite right yet (it looks like it will never actually be set at all, because the code

[PATCH] D61418: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL359820: Another attempt to fix "could not find clang-check" lit warning in analyzer… (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r359820 - Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

Author: nico Date: Thu May 2 12:47:05 2019 New Revision: 359820 URL: http://llvm.org/viewvc/llvm-project?rev=359820&view=rev Log: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds r359717 added clang-check as a dep of check-clang unconditionally because I h

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang added a comment. In D60349#1488411 , @efriedma wrote: > LGTM, assuming it passes testing on electron Thanks Eli. @richard.townsend.arm Can you please confirm whether Electron works with this patch and D60348 ? C

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked an inline comment as done. ymandel added a comment. In D61386#1487735 , @JonasToth wrote: > I like the new framework! Great! Comment at: clang-tools-extra/unittests/clang-tidy/TransformerTidyTest.cpp:38 + IfInverterTid

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197836. ymandel marked 2 inline comments as done. ymandel added a comment. responded to comments and shortened (unnecessarily long) variable name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https:

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek added a comment. In D61456#1488383 , @thakis wrote: > Thanks! This is incomplete: > > - Create clangd_lit_site_cfg_files.gni next to this build file, but path to > generated files there > - Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek updated this revision to Diff 197837. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61456/new/ https://reviews.llvm.org/D61456 Files: llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn llvm/utils/gn/secondary/clang-tools-extra/clangd/test/clangd_lit_site_cfg_files

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. In D61399#1488329 , @hfinkel wrote: > In D61399#1488309 , @ABataev wrote: > > > In D61399#1488299 , @hfinkel wrote: > > > > > In D61399#1488262

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. The value of supporting single-arch sysroots is unclear to me. It's always possible to have a sysroot with libraries for just one architecture installed, even with multi-arch paths. Is this just about compatibility with build scripts and tools which are hard-coded to "$

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek created this revision. phosek added a reviewer: thakis. Herald added subscribers: llvm-commits, cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This reflects changes made in r359763. Repository: rCTE Clang Tools Extra https://revie

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma accepted this revision. efriedma added a comment. LGTM, assuming it passes testing on electron CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL359814: [Sema] Emit warning for visibility attribute on internal-linkage declaration (authored by scott.linder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r359814 - [Sema] Emit warning for visibility attribute on internal-linkage declaration

Author: scott.linder Date: Thu May 2 12:03:57 2019 New Revision: 359814 URL: http://llvm.org/viewvc/llvm-project?rev=359814&view=rev Log: [Sema] Emit warning for visibility attribute on internal-linkage declaration GCC warns on these cases, but we currently just silently ignore the attribute. D

[PATCH] D61456: [gn] Update the clangd test lit site configuration

thakis added a comment. Thanks! This is incomplete: - Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there - Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there Else `out/gn/bin/llvm-lit clang-tools-extra/clangd/test/path

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. In D61452#1488330 , @sunfish wrote: > If libraries don't correctly install into multi-arch directories, can we fix > the libraries? We do this in the wasi-sdk repo to fix up the libc++ and > libc++abi libraries, for example. Sur

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

vsk added a comment. Thanks for working on this! Comment at: lib/CodeGen/CGObjCMac.cpp:1983 + else +GV->setSection("__OBJC,__cstring_object,regular,no_dead_strip"); + Are constant NSStrings within the shared cache ever dirtied? I was under the impression

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:463 - /// Returns true if this address space is a superset of the other one. + /// Returns true if address space A is a superset of B. /// OpenCL v2.0 defines conversion rules (OpenCLC v2.0 s6.5.5) and no

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall added a comment. I think it would be more reasonable to just change `getDeclLanguageLinkage` to check for a kernel function. Comment at: lib/AST/Decl.cpp:2940 + if (hasAttr()) +return true; return isDeclExternC(*this); Both of these changes sh

[PATCH] D61418: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61418/new/ https://reviews.llvm.org/D61418 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel added a comment. In D61335#1488212 , @ilya-biryukov wrote: > - Could you provide a few real-world motivating examples? Especially > interested in cases that were complicated before and are easy to do now? Sure, below are some examples based on

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. If libraries don't correctly install into multi-arch directories, can we fix the libraries? We do this in the wasi-sdk repo to fix up the libc++ and libc++abi libraries, for example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:1024 + bool AddToUsed, + bool ExplicitDataSegment); llvm::GlobalVariable *CreateMetadataVar(Twine Name, Plea

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

hfinkel added a comment. In D61399#1488309 , @ABataev wrote: > In D61399#1488299 , @hfinkel wrote: > > > In D61399#1488262 , @ABataev wrote: > > > > > I don't like this imple

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, with a minor tweak Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2068 +if (llvm::CallInst *CI = dyn_cast(Src)) + if (CI->getMetadata("heapallocsite") && dyn_cast(CE

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. In D61399#1488299 , @hfinkel wrote: > In D61399#1488262 , @ABataev wrote: > > > I don't like this implementation. Seems to me, it breaks one of the OpenMP > > standard requirements: the pro

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang marked 2 inline comments as done. akhuang added a comment. Reverted `getCompleteTypeIndex` change, to be fixed elsewhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 ___

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 197831. mgrang edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/C

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197830. akhuang marked an inline comment as done. akhuang added a comment. - Add test case for multiple casts - Remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

hfinkel added a comment. In D61399#1488262 , @ABataev wrote: > I don't like this implementation. Seems to me, it breaks one of the OpenMP > standard requirements: the program can be compiled without openmp support. I > assume, that with this includes the

[PATCH] D61455: Change the metadata for heapallocsite calls when the type is cast.

akhuang abandoned this revision. akhuang added a comment. accidentally created a new revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61455/new/ https://reviews.llvm.org/D61455 ___ cfe-commits ma

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak created this revision. ahatanak added reviewers: rjmccall, vsk. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This change is a continuation of https://reviews.llvm.org/D59234 and makes the symbols within __DATA visible. rdar://problem/48887111 Reposit

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

teemperor added a comment. I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB. Otherwise the LLDB part of this patch LGTM. Repository: rG LLVM Githu

[PATCH] D61455: Change the metadata for heapallocsite calls when the type is cast.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang abandoned this revision. akhuang added a comment. accidentally created a new revision Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61455 Files: clang/lib/CodeGen/C

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. Moreover, I think this will cause troubles even in simple cases. Assume we have `target if(cond)` construct. In this case we will need to compile the target region for both, the device and the host. If the target region uses some device-specific math functions, it will

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. I don't like this implementation. Seems to me, it breaks one of the OpenMP standard requirements: the program can be compiled without openmp support. I assume, that with this includes the program won't be able to be compiled without OpenMP support anymore because it may

  1   2   >