ahatanak marked an inline comment as done.
ahatanak added inline comments.
================
Comment at: lib/CodeGen/CGObjCMac.cpp:3961
+ // linkage so that the linker preserves the symbol name.
+ llvm::GlobalValue::LinkageTypes LT = ExplicitDataSegment || Section.empty()
+ ? llvm::GlobalValue::InternalLinkage
----------------
vsk wrote:
> Hm. I wonder whether it'd be less error-prone to simply define LT as
> 'Section.empty() || Section.startswith("__DATA")'. Is there an advantage to
> explicitly defining 'ExplicitDataSegment' in the caller?
I was just trying to avoid scanning the string, but probably doing so isn't
that expensive.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61454/new/
https://reviews.llvm.org/D61454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
