[PATCH] D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not sure I personally would ever write code like that ;-) , but if its legal C++ and it compiles we should handle it the same as foo<1>,foo,foo As there are a number of re

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

MyDeveloperDay added a comment. In D58922#1417605 , @jkorous wrote: > BTW I suggest you also add the original test case since the test cases you > added fail the expectation at FormatTest.cpp:74 and the message is a bit > unclear whether the testcase or

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D58811#1417959 , @amalykh wrote: > Thank you for your comments, Roman. > Despite the fact, that there are no official LLVM targets

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall added a comment. In the abstract, it would be nice to warn about casts that always have UB because the address spaces don't overlap; however, I'm worried about how people might be using address spaces in strange ways today, knowing that they *do* overlap, only in ways that the compiler

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

rjmccall added a comment. This seems eminently reasonable to warn about. I think people might legitimately complain about extending an existing warning to a new set of contexts without putting it under a new warning flag, though. How annoying would it be to clone the warnings and put them in

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: test/SemaObjC/boxing-illegal.m:70 + s = @(L"abc"); // expected-error {{illegal type 'int *' used in a boxed expression}} + s = @("\pabc"); // expected-error {{illegal type 'unsigned char *' used in a boxed expression}} +} --

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge added a comment. In D58880#1416754 , @kadircet wrote: > Sorry I didn't notice the mailing thread beforehand, looks like Sam had a > good point regarding performing operations on types rather than > symbols(http://lists.llvm.org/pipermail/clangd-de

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 189275. nridge added a comment. Add tests involving templates and template specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/cla

[PATCH] D58811: [clang] Fix misuses of char width to char align

amalykh added a comment. Thank you for your comments, Roman. Despite the fact, that there are no official LLVM targets that will be influenced by this patch, there are architectures which support only word addressing mode, for which the assumption of char align equals to 8 is not true. The patch

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:266 +auto *NewAttrTy = cast(T.getTypePtr()); +for (TypeAttrPair &A : AttrsForTypes) { + if (A.first == AttrTy) jkorous wrote: > Do you think it would make sense to ter

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

This revision was automatically updated to reflect the committed changes. Closed by commit rL355368: Replace clang::FileData with llvm::vfs::Status (authored by harlanhaskins, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:305 +UFE = &UniqueRealFiles[Status.getUniqueID()]; +Status = llvm::vfs::Status( + Status.getName(), Status.getUniqueID(), harlanhaskins wrote: > benlangmuir wrote: > > Why

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

harlanhaskins marked an inline comment as done. harlanhaskins added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:305 +UFE = &UniqueRealFiles[Status.getUniqueID()]; +Status = llvm::vfs::Status( + Status.getName(), Status.getUniqueID(),

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, although I made a small suggestion for clarity. FYI `InPCH` was used by PTH, which was removed a couple of months ago. Comment at: clang/lib/Basic/FileManag

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added reviewers: kadircet, gribozavr. jkorous added a comment. Adding clangd folks in case they want to take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing li

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous added reviewers: kadircet, gribozavr. jkorous added a comment. Adding clangd folks in case they want to take a look. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58749/new/ https://reviews.llvm.org/D58749 __

[PATCH] D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style

This revision was automatically updated to reflect the committed changes. Closed by commit rL355365: [clang-format][docs][NFC] Fix example for Allman brace breaking style (authored by jkorous, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r355365 - [clang-format][docs][NFC] Fix example for Allman brace breaking style

Author: jkorous Date: Mon Mar 4 17:45:31 2019 New Revision: 355365 URL: http://llvm.org/viewvc/llvm-project?rev=355365&view=rev Log: [clang-format][docs][NFC] Fix example for Allman brace breaking style I assume the example is wrong as it's clearly missing line-breaks before braces. I just ran

[PATCH] D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Good catch, left looks like K&R or something. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58941/new/ https://reviews.llvm.org/D58941 ___

[PATCH] D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style

jkorous created this revision. jkorous added reviewers: JDevlieghere, krasimir, benhamilton. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. I assume the example is wrong as it's clearly missing line-breaks before braces. That's about my level of understanding an

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson updated this revision to Diff 189237. aemerson retitled this revision from "[Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library." to "[Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.". aemerson edite

[PATCH] D58862: [cmake] Create exports for umbrella library targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL355354: [cmake] Create exports for umbrella library targets (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58862?vs=189019&id=189229#toc Repository: rL LLVM

r355354 - [cmake] Create exports for umbrella library targets

Author: smeenai Date: Mon Mar 4 16:38:32 2019 New Revision: 355354 URL: http://llvm.org/viewvc/llvm-project?rev=355354&view=rev Log: [cmake] Create exports for umbrella library targets When using the umbrella llvm-libraries and clang-libraries targets, we should export all library targets, other

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

efriedma added a comment. > This fails with the new asm constraint checks, since the dead branch is never > pruned. As far as I know, we didn't touch "i", only "n". Is there a bug filed for the issue you're describing? Comment at: clang/lib/CodeGen/CGStmt.cpp:1852 +

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith added a comment. In D58890#1417465 , @bruno wrote: > `InMemoryModuleCache` seems like a way more appropriate name here. Also > thanks for improving some of the comments. > > > Because of the move to Serialization we can no longer abuse the > >

[PATCH] D58862: [cmake] Create exports for umbrella library targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58862/new/ https://reviews.llvm.org/D58862 ___

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

jkorous added a comment. BTW I suggest you also add the original test case since the test cases you added fail the expectation at FormatTest.cpp:74 and the message is a bit unclear whether the testcase or the actual implementation is at fault. EXPECT_EQ(Expected.str(), format(Expected, Style)

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch(EnvironmentName) +// FIXME: We have to put XCOFF before COFF; +// perhaps an order-independent pattern matching is desired? If the conclusion

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

jkorous added a comment. I added couple other cases to your fix here: https://reviews.llvm.org/D58934 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58922/new/ https://reviews.llvm.org/D58922 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter

jkorous created this revision. jkorous added reviewers: klimek, djasper, JonasToth, alexfh, krasimir, MyDeveloperDay. Herald added subscribers: cfe-commits, jdoerfert, dexonsmith. Herald added a project: clang. Inspired by https://reviews.llvm.org/D58922 Since this code compiles I assume we shou

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. @NoQ Ping 2 for reviews please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 189222. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. Fixed some little nits, thanks @JonasToth! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-ti

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

joerg added a comment. The other problem is that we don't use the CFG machinery to prune dead branches. Consider the x86 in/out instructions: one variant takes an immediate, the other a register. The classic way to deal with that is something like static inline void outl(unsigned port, uint32

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, sfertile, chandlerc, apaprocki. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, aheejin, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. This patch adds an XCOFF tri

Re: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

Hi David, I can take a look at adding another test. Please read the code review which answers your question. A new flag is required. Thanks. From: David Blaikie Sent: Tuesday, March 5, 2019 12:51:27 AM To: Aaron Smith; Reid Kleckner; Adrian Prantl; Jonas Devliegh

[PATCH] D58893: Modules: Invalidate out-of-date PCMs as they're discovered

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for working on this, the approach & patch LGTM. Comment at: clang/include/clang/Serialization/InMemoryModuleCache.h:37 /// Track the timeline of when this was add

[PATCH] D58154: Add support for -fpermissive.

rsmith added a comment. In D58154#1417363 , @aaron.ballman wrote: > I'm not super keen on supporting -fpermissive -- what is the impetus for > supporting this? Is it just for GCC compatibility? Yes, exactly that -- this is to improve our drop-in compa

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

manmanren closed this revision. manmanren added a comment. r355333 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58751/new/ https://reviews.llvm.org/D58751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

bruno added a comment. `InMemoryModuleCache` seems like a way more appropriate name here. Also thanks for improving some of the comments. > Because of the move to Serialization we can no longer abuse the Preprocessor > to forward it to the ASTReader. Besides the rename and file move, that means

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 189205. jyu2 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D58891: Modules: Add -Rmodule-import

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, note that a subset of this information can be achieved with `-Wauto-import`, but this is way more general and solid, since it will handles `@import`s and pragma imports too. LGTM with a mi

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

harlanhaskins created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. harlanhaskins edited the summary of this revision. harlanhaskins added a reviewer: benlangmuir. Herald added a subscriber: ormris. `FileData` was only ever used as a container for the values

[PATCH] D58236: Make address space conversions a bit stricter.

efriedma added a comment. In D58236#1416765 , @Anastasia wrote: > In D58236#1414069 , @efriedma wrote: > > > > I think trying to reject code that is doing something dangerous is a good > > > thing! > > > > Refusing

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

jkorous added a comment. Thanks for fixing this! The patch LGTM. I am just wondering what else are we missing here. I guess arithmetic and logical operators are also allowed: template struct foo {}; int main() { auto lambda1 = []() -> foo { return foo{}; }; auto lambda2 =

[PATCH] D58317: [clang] Add install targets for API headers

smeenai added a comment. @phosek This is using the clang-headers name now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 ___ cfe-commits mailing list cfe-comm

[PATCH] D58317: [clang] Add install targets for API headers

smeenai updated this revision to Diff 189199. smeenai retitled this revision from "[clang] Add install targets for library headers" to "[clang] Add install targets for API headers". smeenai edited the summary of this revision. smeenai added a comment. Update target name Repository: rG LLVM Gi

r355340 - [build] Rename clang-headers to clang-resource-headers

Author: smeenai Date: Mon Mar 4 13:19:53 2019 New Revision: 355340 URL: http://llvm.org/viewvc/llvm-project?rev=355340&view=rev Log: [build] Rename clang-headers to clang-resource-headers Summary: The current install-clang-headers target installs clang's resource directory headers. This is diffe

[clang-tools-extra] r355340 - [build] Rename clang-headers to clang-resource-headers

Author: smeenai Date: Mon Mar 4 13:19:53 2019 New Revision: 355340 URL: http://llvm.org/viewvc/llvm-project?rev=355340&view=rev Log: [build] Rename clang-headers to clang-resource-headers Summary: The current install-clang-headers target installs clang's resource directory headers. This is diffe

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. In D57965#1417361 , @jkorous wrote: > Hi David, > I am just wondering - while you're here would you mind adding couple more > tests? It would be great to have a test for each attribute. > > Also, what do you think about Ben's su

[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

tra added a subscriber: ABataev. tra added a comment. The change looks OK as far as regular CUDA is concerned. That said, I'm not quite familiar with the use of bundling/unbundling actions and you should probably get someone who uses/depends on them to take a look. I think OpenMP uses them. Perh

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

DHowett-MSFT updated this revision to Diff 189193. DHowett-MSFT added a comment. Fixed corrupted patch. I know that the -str test case is not the _ideal_ location for the comdat test, but it is the only test whose invariants failed (the IR for the descriptor definition now contains `comdat, alig

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. needs another rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57965: Clean up ObjCPropertyDecl printing

jkorous added a comment. Hi David, I am just wondering - while you're here would you mind adding couple more tests? It would be great to have a test for each attribute. Also, what do you think about Ben's suggestion? I think it would be nice to be consistent with the style Objective-C documenta

[PATCH] D58154: Add support for -fpermissive.

aaron.ballman added a comment. I'm not super keen on supporting -fpermissive -- what is the impetus for supporting this? Is it just for GCC compatibility? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58154/new/ https://reviews.llvm.org/D58154 __

[PATCH] D58154: Add support for -fpermissive.

jyknight added a comment. Hm -- in GCC, -fpermissive has nothing at all to do with -pedantic/-pedantic-errors, but I suppose it should be fine to do this way. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58154/new/ https://reviews.llvm.org/D58154 ___

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, djasper, JonasToth, alexfh, krasimir. MyDeveloperDay added a project: clang-tools-extra. A Lamdba with a return type template with a boolean literal (true,false) behaves differently to an integer literal https://bugs.l

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache created this revision. modocache added reviewers: rsmith, andrewjcg. Herald added a project: clang. This patch addresses https://bugs.llvm.org/show_bug.cgi?id=39287. Clang creates a 'std' namespace in one of two ways: either it parses a `namespace std { ... }` declaration, or it creates

[PATCH] D58921: [CMake] Tell libc++ that we're using compiler-rt on Apple platforms

ldionne created this revision. ldionne added reviewers: beanz, arphaman. Herald added subscribers: cfe-commits, jdoerfert, dexonsmith, jkorous, mgorny, dberris. Herald added a reviewer: EricWF. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58921 Files: clang/

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

manmanren marked 3 inline comments as done. manmanren added inline comments. Comment at: include/clang/Driver/Options.td:774 +Group, Flags<[CoreOption]>, +HelpText<"Generate instrumented code to collect order file into default.profraw file (overridden by '=' form of opti

r355333 - Order File Instrumentation: add clang support for -forder-file-instrumentation

Author: mren Date: Mon Mar 4 12:30:30 2019 New Revision: 355333 URL: http://llvm.org/viewvc/llvm-project?rev=355333&view=rev Log: Order File Instrumentation: add clang support for -forder-file-instrumentation When -forder-file-instrumentation is on, we pass llvm flag to enable the order file in

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

This revision was automatically updated to reflect the committed changes. Closed by commit rL355332: [ASTImporter] Handle built-in when importing SourceLocation and FileID (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r355332 - [ASTImporter] Handle built-in when importing SourceLocation and FileID

Author: shafik Date: Mon Mar 4 12:25:54 2019 New Revision: 355332 URL: http://llvm.org/viewvc/llvm-project?rev=355332&view=rev Log: [ASTImporter] Handle built-in when importing SourceLocation and FileID Summary: Currently when we see a built-in we try and import the include location. Instead wh

[PATCH] D58885: Variable auto-init: split out small arrays

jfb marked an inline comment as done. jfb added a comment. Comparing clang stage2 in release mode, with an without this change, we see a 408 byte size difference, which is ~nothing. Here's details, nothing surprising: $ /s/bloaty/bloaty -d sections /s/llvm1/llvm/stage2/bin/clang-9 -- /s/llvm

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355331: [PGO] Clang part of change for context-sensitive PGO (part1) (authored by xur, committed by ). Changed prior to commit: https://reviews.llvm.org/D54176?vs=189167&id=189184#toc Repository: rC

r355331 - [PGO] Clang part of change for context-sensitive PGO (part1)

Author: xur Date: Mon Mar 4 12:21:31 2019 New Revision: 355331 URL: http://llvm.org/viewvc/llvm-project?rev=355331&view=rev Log: [PGO] Clang part of change for context-sensitive PGO (part1) Part 1 of CSPGO change in Clang. This includes changes in clang options and calls to llvm PassManager. Tes

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

DHowett-MSFT updated this revision to Diff 189183. DHowett-MSFT added a comment. This change caused a test to fail, so I took the opportunity to augment the test with COMDAT entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58807/new/ https://r

[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: jdoerfert. Herald added a project: clang. When -fno-gpu-rdc is set, device code is compiled, linked, and assembled into fat binary and embedded as string in object files. The object files are normal object fil

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

shafik accepted this revision. shafik added a comment. LGTM, thank you ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58502/new/ https://reviews.llvm.org/D58502 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

smeenai added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5312 + CmdArgs.push_back("-forder-file-instrumentation"); + // Enable order file instrumentation when ThinLTO is not on. When ThinLTO is + // on, we need to pass these flags as linker flags an

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Should the langref be updated (specifically the section on blockaddress): This value only has defined behavior when used as an operand to the ‘indirectbr’ instruction, or for comparisons against null. https://reviews.llvm.org/D53765 touched the langref, but I

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 ___ cfe-commits mailing list cfe-commits

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 189167. xur added a comment. Added usage example to UserManual.rst suggested by David. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: docs/UsersManual.rst include/clang/Basic/CodeGenOptions.h inclu

r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

Author: erichkeane Date: Mon Mar 4 10:47:21 2019 New Revision: 355322 URL: http://llvm.org/viewvc/llvm-project?rev=355322&view=rev Log: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms. The above builtins are currently implemented for MSVC mode, however GCC also implements these. This patch

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added a comment. It might be a good idea to add the nested lambda tests from D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) into your review to show how this patch c

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Looks good, thanks for adding a driver option for this! Comment at: include/clang/Driver/Options.td:774 +Group, Flags<[CoreOption]>, +HelpText<"Generate instrum

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes added a comment. Herald added a subscriber: ormris. In D58814#1415607 , @gribozavr wrote: > > These references were added to support using the index data for symbol > > rename. > > Understood -- thank you for providing the context (the original c

[PATCH] D58885: Variable auto-init: split out small arrays

glider accepted this revision. glider added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGDecl.cpp:1206 + bool canDoSingleStore = Ty->isIntOrIntVectorTy() || + Ty->isPtrOrPtrVectorTy() || Ty->isFPOrFPVectorTy

[PATCH] D58885: Variable auto-init: split out small arrays

jfb marked 3 inline comments as done. jfb added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1206 + bool canDoSingleStore = Ty->isIntOrIntVectorTy() || + Ty->isPtrOrPtrVectorTy() || Ty->isFPOrFPVectorTy(); + if (canDoSingleStore) { --

[PATCH] D58885: Variable auto-init: split out small arrays

glider added a comment. The change itself looks good. It doesn't seem to regress kernel performance on ARM64. I haven't got to testing on x86 yet, but don't anticipate any problems either. Comment at: lib/CodeGen/CGDecl.cpp:1206 + bool canDoSingleStore = Ty->isIntOrIntVectorT

[PATCH] D58885: Variable auto-init: split out small arrays

jfb updated this revision to Diff 189159. jfb added a comment. - Fix test labels. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58885/new/ https://reviews.llvm.org/D58885 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/auto-var-init.cpp Index: test/CodeGenCXX

[PATCH] D58885: Variable auto-init: split out small arrays

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: test/CodeGenCXX/auto-var-init.cpp:1025 // PATTERN-LABEL: @test_intptr4_uninit() -// PATTERN: call void @llvm.memcpy{{.*}} @__const.test_intptr4_uninit.uninit -// ZERO-LABEL: @test_intptr4_uninit() -// Z

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 189157. lewmpk added a comment. match lock() and unlock() calls by decl Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.t

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler marked an inline comment as done. rdwampler added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; LLVMStyle.AllowShortLoopsOnASi

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl added inline comments. Comment at: docs/UsersManual.rst:1792 + The profile generated by ``-fcs-profile-generate`` and ``-fprofile-generate`` + can be merged by llvm-profdata. + Please add a use example to show the typical flow with this option (both gen

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. Friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

Re: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

Hi Aaron, I don't see any mention of this in D44406 - so it might have been good to have a separate review for this (or included this in the review of D44406, which I think is possible with the monorepo). Specifically - this change is missing test coverage (there should be a clang test that goes

[PATCH] D58885: Variable auto-init: split out small arrays

glider added inline comments. Comment at: test/CodeGenCXX/auto-var-init.cpp:1025 // PATTERN-LABEL: @test_intptr4_uninit() -// PATTERN: call void @llvm.memcpy{{.*}} @__const.test_intptr4_uninit.uninit -// ZERO-LABEL: @test_intptr4_uninit() -// ZERO: call void @llvm.memset{{.*}},

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked 6 inline comments as not done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang

[PATCH] D58844: Give builtins and alloc/dealloc operators the default calling convention.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355317: Give builtins and alloc/dealloc operators the default calling convention. (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

r355317 - Give builtins and alloc/dealloc operators the default calling convention.

Author: erichkeane Date: Mon Mar 4 06:54:52 2019 New Revision: 355317 URL: http://llvm.org/viewvc/llvm-project?rev=355317&view=rev Log: Give builtins and alloc/dealloc operators the default calling convention. On SPIR targets, the default calling convention is SpirFunction. However, operator new

[PATCH] D35169: Refactor DragonFly BSD toolchain driver.

mgorny added inline comments. Herald added subscribers: jdoerfert, krytarowski. Comment at: lib/Driver/ToolChains/DragonFly.cpp:118 } - CmdArgs.push_back(Args.MakeArgString(getToolChain().GetFilePath("crti.o"))); -if (Args.hasArg(options::OPT_shared) || Args.hasArg(o

[PATCH] D58897: Make ODR error handling configurable

gamesh411 added a comment. This revision is the alternative of the abandoned D55646 . Now Sema uses the old behavior of emitting ODR errors while merging and importing is done in a more lenient way. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D58897: Make ODR error handling configurable

gamesh411 created this revision. Herald added subscribers: cfe-commits, jdoerfert, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. ODR errors are not necessarily true errors during the import of ASTs. ASTMerge and CrossTU should use the warning equivalent of eve

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. In D57914#1416215 , @jyknight wrote: > The intricate initialization-order workarounds apparently don't work in all > build modes, so I've updated this code to have constexpr functions and > initializations in rL355278

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia added a comment. In D58346#1413863 , @rjmccall wrote: > Hmm. Yeah, Embedded C allows these casts, so contra my previous comment, I > think we can't make them ill-formed outside of OpenCL mode. Ok, would these rules apply in regular C99 mode t

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong added a comment. Alexei, thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong updated this revision to Diff 189131. martong marked 2 inline comments as done. martong added a comment. - Fix some comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 Files: lib/AST/ASTImporter.cpp unitt

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1414069 , @efriedma wrote: > > I think trying to reject code that is doing something dangerous is a good > > thing! > > Refusing to compile code which is suspicious, but not forbidden by the > specification, will like

  1   2   >