Author: smeenai Date: Mon Mar 4 13:19:53 2019 New Revision: 355340 URL: http://llvm.org/viewvc/llvm-project?rev=355340&view=rev Log: [build] Rename clang-headers to clang-resource-headers
Summary: The current install-clang-headers target installs clang's resource directory headers. This is different from the install-llvm-headers target, which installs LLVM's API headers. We want to introduce the corresponding target to clang, and the natural name for that new target would be install-clang-headers. Rename the existing target to install-clang-resource-headers to free up the install-clang-headers name for the new target, following the discussion on cfe-dev [1]. I didn't find any bots on zorg referencing install-clang-headers. I'll send out another PSA to cfe-dev to accompany this rename. [1] http://lists.llvm.org/pipermail/cfe-dev/2019-February/061365.html Reviewers: beanz, phosek, tstellar, rnk, dim, serge-sans-paille Subscribers: mgorny, javed.absar, jdoerfert, #sanitizers, openmp-commits, lldb-commits, cfe-commits, llvm-commits Tags: #clang, #sanitizers, #lldb, #openmp, #llvm Differential Revision: https://reviews.llvm.org/D58791 Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake cfe/trunk/cmake/caches/BaremetalARM.cmake cfe/trunk/cmake/caches/DistributionExample-stage2.cmake cfe/trunk/cmake/caches/Fuchsia-stage2.cmake cfe/trunk/cmake/modules/AddClang.cmake cfe/trunk/docs/LibTooling.rst cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/examples/clang-interpreter/CMakeLists.txt cfe/trunk/lib/Headers/CMakeLists.txt cfe/trunk/test/CMakeLists.txt cfe/trunk/tools/driver/CMakeLists.txt cfe/trunk/tools/libclang/CMakeLists.txt Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/cmake/caches/Apple-stage2.cmake?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/cmake/caches/Apple-stage2.cmake (original) +++ cfe/trunk/cmake/caches/Apple-stage2.cmake Mon Mar 4 13:19:53 2019 @@ -60,7 +60,7 @@ set(LLVM_DISTRIBUTION_COMPONENTS clang LTO clang-format - clang-headers + clang-resource-headers cxx-headers ${LLVM_TOOLCHAIN_TOOLS} CACHE STRING "") Modified: cfe/trunk/cmake/caches/BaremetalARM.cmake URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/cmake/caches/BaremetalARM.cmake?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/cmake/caches/BaremetalARM.cmake (original) +++ cfe/trunk/cmake/caches/BaremetalARM.cmake Mon Mar 4 13:19:53 2019 @@ -41,7 +41,7 @@ set(LLVM_TOOLCHAIN_TOOLS set(LLVM_DISTRIBUTION_COMPONENTS clang lld - clang-headers + clang-resource-headers builtins-armv6m-none-eabi builtins-armv7m-none-eabi builtins-armv7em-none-eabi Modified: cfe/trunk/cmake/caches/DistributionExample-stage2.cmake URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/cmake/caches/DistributionExample-stage2.cmake?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/cmake/caches/DistributionExample-stage2.cmake (original) +++ cfe/trunk/cmake/caches/DistributionExample-stage2.cmake Mon Mar 4 13:19:53 2019 @@ -23,7 +23,7 @@ set(LLVM_DISTRIBUTION_COMPONENTS clang LTO clang-format - clang-headers + clang-resource-headers builtins runtimes ${LLVM_TOOLCHAIN_TOOLS} Modified: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/cmake/caches/Fuchsia-stage2.cmake?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/cmake/caches/Fuchsia-stage2.cmake (original) +++ cfe/trunk/cmake/caches/Fuchsia-stage2.cmake Mon Mar 4 13:19:53 2019 @@ -167,7 +167,7 @@ set(LLVM_DISTRIBUTION_COMPONENTS LTO clang-apply-replacements clang-format - clang-headers + clang-resource-headers clang-include-fixer clang-refactor clang-tidy Modified: cfe/trunk/cmake/modules/AddClang.cmake URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/cmake/modules/AddClang.cmake?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/cmake/modules/AddClang.cmake (original) +++ cfe/trunk/cmake/modules/AddClang.cmake Mon Mar 4 13:19:53 2019 @@ -133,7 +133,7 @@ macro(add_clang_tool name) endif() add_clang_executable(${name} ${ARGN}) - add_dependencies(${name} clang-headers) + add_dependencies(${name} clang-resource-headers) if (CLANG_BUILD_TOOLS) if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR Modified: cfe/trunk/docs/LibTooling.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/LibTooling.rst?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/docs/LibTooling.rst (original) +++ cfe/trunk/docs/LibTooling.rst Mon Mar 4 13:19:53 2019 @@ -187,8 +187,8 @@ Clang tools need their builtin headers a does. Thus, the default location to look for builtin headers is in a path ``$(dirname /path/to/tool)/../lib/clang/3.3/include`` relative to the tool binary. This works out-of-the-box for tools running from llvm's toplevel -binary directory after building clang-headers, or if the tool is running from -the binary directory of a clang install next to the clang binary. +binary directory after building clang-resource-headers, or if the tool is +running from the binary directory of a clang install next to the clang binary. Tips: if your tool fails to find ``stddef.h`` or similar headers, call the tool with ``-v`` and look at the search paths it looks through. Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/docs/ReleaseNotes.rst (original) +++ cfe/trunk/docs/ReleaseNotes.rst Mon Mar 4 13:19:53 2019 @@ -131,7 +131,7 @@ ABI Changes in Clang - ... OpenMP Support in Clang ----------------------------------- +----------------------- - Added emission of the debug information for NVPTX target devices. @@ -147,6 +147,17 @@ These are major API changes that have ha Clang. If upgrading an external codebase that uses Clang as a library, this section should help get you past the largest hurdles of upgrading. +Build System Changes +-------------------- + +These are major changes to the build system that have happened since the 8.0.0 +release of Clang. Users of the build system should adjust accordingly. + +- In 8.0.0 and below, the install-clang-headers target would install clang's + resource directory headers. This installation is now performed by the + install-clang-resource-headers target. Users of the old install-clang-headers + target should switch to the new install-clang-resource-headers target. + - ... AST Matchers Modified: cfe/trunk/examples/clang-interpreter/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/examples/clang-interpreter/CMakeLists.txt?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/examples/clang-interpreter/CMakeLists.txt (original) +++ cfe/trunk/examples/clang-interpreter/CMakeLists.txt Mon Mar 4 13:19:53 2019 @@ -16,7 +16,7 @@ add_clang_executable(clang-interpreter ) add_dependencies(clang-interpreter - clang-headers + clang-resource-headers ) target_link_libraries(clang-interpreter Modified: cfe/trunk/lib/Headers/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/CMakeLists.txt?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/lib/Headers/CMakeLists.txt (original) +++ cfe/trunk/lib/Headers/CMakeLists.txt Mon Mar 4 13:19:53 2019 @@ -157,8 +157,8 @@ clang_generate_header(-gen-arm-neon arm_ # Generate arm_fp16.h clang_generate_header(-gen-arm-fp16 arm_fp16.td arm_fp16.h) -add_custom_target(clang-headers ALL DEPENDS ${out_files}) -set_target_properties(clang-headers PROPERTIES +add_custom_target(clang-resource-headers ALL DEPENDS ${out_files}) +set_target_properties(clang-resource-headers PROPERTIES FOLDER "Misc" RUNTIME_OUTPUT_DIRECTORY "${output_dir}") @@ -167,10 +167,10 @@ set(header_install_dir lib${LLVM_LIBDIR_ install( DIRECTORY ${output_dir} DESTINATION ${header_install_dir} - COMPONENT clang-headers) + COMPONENT clang-resource-headers) if (NOT LLVM_ENABLE_IDE) - add_llvm_install_targets(install-clang-headers - DEPENDS clang-headers - COMPONENT clang-headers) + add_llvm_install_targets(install-clang-resource-headers + DEPENDS clang-resource-headers + COMPONENT clang-resource-headers) endif() Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CMakeLists.txt?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/test/CMakeLists.txt (original) +++ cfe/trunk/test/CMakeLists.txt Mon Mar 4 13:19:53 2019 @@ -46,7 +46,7 @@ if(CLANG_TEST_USE_VG) endif () list(APPEND CLANG_TEST_DEPS - clang clang-headers + clang clang-resource-headers clang-format c-index-test diagtool clang-tblgen Modified: cfe/trunk/tools/driver/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/CMakeLists.txt?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/tools/driver/CMakeLists.txt (original) +++ cfe/trunk/tools/driver/CMakeLists.txt Mon Mar 4 13:19:53 2019 @@ -60,7 +60,7 @@ if(CLANG_PLUGIN_SUPPORT) export_executable_symbols(clang) endif() -add_dependencies(clang clang-headers) +add_dependencies(clang clang-resource-headers) if(NOT CLANG_LINKS_TO_CREATE) set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp) Modified: cfe/trunk/tools/libclang/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CMakeLists.txt?rev=355340&r1=355339&r2=355340&view=diff ============================================================================== --- cfe/trunk/tools/libclang/CMakeLists.txt (original) +++ cfe/trunk/tools/libclang/CMakeLists.txt Mon Mar 4 13:19:53 2019 @@ -92,7 +92,7 @@ endif() add_clang_library(libclang ${ENABLE_SHARED} ${ENABLE_STATIC} OUTPUT_NAME ${output_name} ${SOURCES} - DEPENDS clang-headers + DEPENDS clang-resource-headers LINK_LIBS ${LIBS} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
