bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.

Thanks for working on this, the approach & patch LGTM.



================
Comment at: clang/include/clang/Serialization/InMemoryModuleCache.h:37
 
     /// Track the timeline of when this was added to the cache.
+    bool IsFinal = false;
----------------
Now that generation count is gone, update (or remove) this comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58893/new/

https://reviews.llvm.org/D58893



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D58893: Mo... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D5889... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D5889... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to